Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44586 )
Change subject: mb/google/dedede: Add support to override gpio config in bootblock ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Before learning more from Furquan, +1 first since this mechanism was in Octopus platform reviewed by Furquan as well.
https://review.coreboot.org/c/coreboot/+/44586/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44586/5//COMMIT_MSG@7 PS5, Line 7: Add support to override gpio config in bootblock
This generally doesn't work well and results into lot of manual errors. […]
variant_override_gpio_table is a similar implementation and adopted by multiple platforms already. As a result, I thought this is just another version in bootblock stage?