Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.16.4

[Dhyey Patel (Code Review)]

Dhyey Patel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.16.4
......................................................................

crossgcc: Upgrade cmake to version 3.16.4

Change-Id: I20b75b7c29be838c3c168547bcab25ea5c1af462
Signed-off-by: Griffin98 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
A util/crossgcc/sum/cmake-3.16.4.tar.gz.cksum
3 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/39258/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 9920799..f1d7e66 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -60,7 +60,7 @@
 # CLANG version number
 CLANG_VERSION=9.0.0
 MAKE_VERSION=4.2.1
-CMAKE_VERSION=3.16.2
+CMAKE_VERSION=3.16.4
 NASM_VERSION=2.14.02

# GCC toolchain archive locations
diff --git a/util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum b/util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
deleted file mode 100644
index c5190b2..0000000
--- a/util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
+++ /dev/null
@@ -1 +0,0 @@
-f514dbd9aa8332a28ba62dd8ce97b0aa0b099491  tarballs/cmake-3.16.2.tar.gz
diff --git a/util/crossgcc/sum/cmake-3.16.4.tar.gz.cksum b/util/crossgcc/sum/cmake-3.16.4.tar.gz.cksum
new file mode 100644
index 0000000..95df652
--- /dev/null
+++ b/util/crossgcc/sum/cmake-3.16.4.tar.gz.cksum
@@ -0,0 +1 @@
+3ae23da521d5c0e871dd820a0d3af5504f0bd6db  tarballs/cmake-3.16.4.tar.gz

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.16.4
......................................................................

Patch Set 1: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.16.4
......................................................................

Patch Set 1: Code-Review+2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.16.4
......................................................................

Patch Set 1:

3.17.0 released.
I think that cmake is used for llvm, so maybe we can wait for llvm-10 and then upgrade cmake to the latest version?

[Dhyey Patel (Code Review)]

Dhyey Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.16.4
......................................................................

Patch Set 1: Code-Review-1

I agree, LLVM-10 released yesterday (https://releases.llvm.org/). I will update llvm to 10 and cmake to 3.17.0

Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.17.0

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#2) to the change originally created by Dhyey Patel. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.17.0
......................................................................

crossgcc: Upgrade cmake to version 3.17.0

Change-Id: I20b75b7c29be838c3c168547bcab25ea5c1af462
Signed-off-by: Griffin98 
Signed-off-by: Elyes HAOUAS 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
A util/crossgcc/sum/cmake-3.17.0.tar.gz.cksum
3 files changed, 4 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/39258/2

Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.17.0

[Dhyey Patel (Code Review)]

Dhyey Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.17.0
......................................................................

Patch Set 2: Code-Review-1

Let's just wait for this till LLVM-10 sources are available in https://releases.llvm.org/10.0.0/

Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.17.0

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.17.0
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review-1
>
> Let's just wait for this till LLVM-10 sources are available in https://releases.llvm.org/10.0.0/

will they move it to releases.llvm.org ?
they didn't for 9.0.1

Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.17.0

[Dhyey Patel (Code Review)]

Dhyey Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.17.0
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2: Code-Review-1
> >
> > Let's just wait for this till LLVM-10 sources are available in https://releases.llvm.org/10.0.0/
>
> will they move it to releases.llvm.org ?
> they didn't for 9.0.1

LLVM-9.0 is available https://releases.llvm.org/9.0.0/ so does 8.0.0 is whereas 8.0.1 isn't. It seems like they are only moving major releases in.

Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.17.0

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.17.0
......................................................................

Patch Set 2:

(1 comment)
> Patch Set 2:
> > Patch Set 2:
> > > Patch Set 2: Code-Review-1
> > >
> > > Let's just wait for this till LLVM-10 sources are available in https://releases.llvm.org/10.0.0/
> >
> > will they move it to releases.llvm.org ?
> > they didn't for 9.0.1
>
> LLVM-9.0 is available https://releases.llvm.org/9.0.0/ so does 8.0.0 is whereas 8.0.1 isn't. It seems like they are only moving major releases in.

ok.
in any case, we have to wait for coreboot release.
also I did a mistake by adding "MAKE_VERSION=4.2.1" ...
Please fix that mistake when you'll update this patch.

https://review.coreboot.org/c/coreboot/+/39258/2/util/crossgcc/buildgcc 
File util/crossgcc/buildgcc:

https://review.coreboot.org/c/coreboot/+/39258/2/util/crossgcc/buildgcc@64 
PS2, Line 64: MAKE_VERSION=4.2.1
humm, why I added this ????

Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.17.0

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.17.0
......................................................................

Patch Set 2:

would you upgrade CMake to 3.17.2?

Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.17.0

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.17.0
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.17.2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#3) to the change originally created by Dhyey Patel. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.17.2
......................................................................

crossgcc: Upgrade cmake to version 3.17.2

Change-Id: I20b75b7c29be838c3c168547bcab25ea5c1af462
Signed-off-by: Griffin98 
Signed-off-by: Elyes HAOUAS 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
A util/crossgcc/sum/cmake-3.17.2.tar.gz.cksum
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/39258/3

Change in coreboot[master]: crossgcc: Upgrade cmake to version 3.17.2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade cmake to version 3.17.2
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/39258/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39258/3//COMMIT_MSG@7 
PS3, Line 7: cmake
CMake

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.17.2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#4) to the change originally created by Dhyey Patel. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.17.2
......................................................................

crossgcc: Upgrade CMake to version 3.17.2

Change-Id: I20b75b7c29be838c3c168547bcab25ea5c1af462
Signed-off-by: Griffin98 
Signed-off-by: Elyes HAOUAS 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
A util/crossgcc/sum/cmake-3.17.2.tar.gz.cksum
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/39258/4

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.17.2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.17.2
......................................................................

Patch Set 4:

(1 comment)

Thx

https://review.coreboot.org/c/coreboot/+/39258/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39258/3//COMMIT_MSG@7 
PS3, Line 7: cmake
> CMake

Done

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.17.2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.17.2
......................................................................

Patch Set 5: Code-Review+2

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.17.2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.17.2
......................................................................

Patch Set 5:

please see https://review.coreboot.org/c/coreboot/+/44101/2

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.18.1

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded a new patch set (#6) to the change originally created by Dhyey Patel. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.18.1
......................................................................

crossgcc: Upgrade CMake to version 3.18.1

Release Notes:
  https://cmake.org/cmake/help/v3.18/release/3.18.html

Change-Id: I20b75b7c29be838c3c168547bcab25ea5c1af462
Signed-off-by: Griffin98 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
A util/crossgcc/sum/cmake-3.18.1.tar.gz.cksum
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/39258/6

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.18.1

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.18.1
......................................................................

Patch Set 6:

#44101 abandoned.
Thx

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.18.1

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.18.1
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.18.1

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.18.1
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.18.1

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.18.1
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39258/6/util/crossgcc/buildgcc 
File util/crossgcc/buildgcc:

https://review.coreboot.org/c/coreboot/+/39258/6/util/crossgcc/buildgcc@69 
PS6, Line 69: 3.18
for a follow up: should we replace this with $(echo ${CMAKE_VERSION} | cut -d. -f-2)?

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.18.1

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.18.1
......................................................................

crossgcc: Upgrade CMake to version 3.18.1

Release Notes:
  https://cmake.org/cmake/help/v3.18/release/3.18.html

Change-Id: I20b75b7c29be838c3c168547bcab25ea5c1af462
Signed-off-by: Griffin98 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39258
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Patrick Georgi 
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
A util/crossgcc/sum/cmake-3.18.1.tar.gz.cksum
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, approved

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 503ca50..548bb53 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -45,7 +45,7 @@
 EXPAT_VERSION=2.2.9
 # CLANG version number
 CLANG_VERSION=9.0.0
-CMAKE_VERSION=3.16.2
+CMAKE_VERSION=3.18.1
 NASM_VERSION=2.15.03

# GCC toolchain archive locations
@@ -66,7 +66,7 @@
 CFE_ARCHIVE="https://releases.llvm.org/$%7BCLANG_VERSION%7D/cfe-$%7BCLANG_VERSION%7D.src...."
 CRT_ARCHIVE="https://releases.llvm.org/$%7BCLANG_VERSION%7D/compiler-rt-$%7BCLANG_VERSION..."
 CTE_ARCHIVE="https://releases.llvm.org/$%7BCLANG_VERSION%7D/clang-tools-extra-$%7BCLANG_V..."
-CMAKE_ARCHIVE="https://cmake.org/files/v3.16/cmake-$%7BCMAKE_VERSION%7D.tar.gz"
+CMAKE_ARCHIVE="https://cmake.org/files/v3.18/cmake-$%7BCMAKE_VERSION%7D.tar.gz"
 NASM_ARCHIVE="https://www.nasm.us/pub/nasm/releasebuilds/$%7BNASM_VERSION%7D/nasm-$%7BNASM..."

ALL_ARCHIVES="$GMP_ARCHIVE $MPFR_ARCHIVE $MPC_ARCHIVE \
diff --git a/util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum b/util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
deleted file mode 100644
index c5190b2..0000000
--- a/util/crossgcc/sum/cmake-3.16.2.tar.gz.cksum
+++ /dev/null
@@ -1 +0,0 @@
-f514dbd9aa8332a28ba62dd8ce97b0aa0b099491  tarballs/cmake-3.16.2.tar.gz
diff --git a/util/crossgcc/sum/cmake-3.18.1.tar.gz.cksum b/util/crossgcc/sum/cmake-3.18.1.tar.gz.cksum
new file mode 100644
index 0000000..c4f3ed2
--- /dev/null
+++ b/util/crossgcc/sum/cmake-3.18.1.tar.gz.cksum
@@ -0,0 +1 @@
+60c36386d0df016adc96c8bb3215d02de3777869  tarballs/cmake-3.18.1.tar.gz

Change in coreboot[master]: crossgcc: Upgrade CMake to version 3.18.1

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39258 )

Change subject: crossgcc: Upgrade CMake to version 3.18.1
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39258/6/util/crossgcc/buildgcc 
File util/crossgcc/buildgcc:

https://review.coreboot.org/c/coreboot/+/39258/6/util/crossgcc/buildgcc@69 
PS6, Line 69: 3.18
> for a follow up: should we replace this with $(echo ${CMAKE_VERSION} | cut -d. […]

sounds nice.