Attention is currently required from: Shelley Chen, Hung-Te Lin, Yu-Ping Wu.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56789 )
Change subject: libpayload/pci: Split PCI interfaces as common and chip related
......................................................................
Patch Set 13:
(1 comment)
File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/56789/comment/4e772d89_5e355c3e
PS12, Line 418:
Similar to coreboot's implementation, could we add ECAM_MMCONF_SUPPORT and ECAM_MMCONF_BASE_ADDRESS?
I don't think we need to add these configs.
For Intel platform, pci_io_ops.c will be used, and it already has the register information which the x86 platform is needed.
For other platforms(e.g. Mediatek) which does not support ECAM, they should provide 'pci_map_bus()' function like coreboot did to get the address of each device's config space, all they need is the register base address of PCIe hardware(CL:56794). I think maybe we can define this address or pass this information from the users(e.g. depthcharge).
Is that okay for you, what do you think?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie74801bd4f3de51cbb574e86cd9bb09931152554
Gerrit-Change-Number: 56789
Gerrit-PatchSet: 13
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 08 Mar 2022 12:14:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment