Attention is currently required from: Angel Pons, Václav Straka.
Nicholas Chin has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400 ......................................................................
Patch Set 11: Code-Review+2
(2 comments)
File src/mainboard/hp/pro_3x00_series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/85825/comment/a5029869_6af22359?usp... : PS10, Line 37: 2 0 Enable : 2 1 Disable
Removed. Should i also renumber the other enums? I was not sure so i left it as is.
I'd leave it as is. I think there's lots of other boards that have non sequential enum IDs, and I think the IDs are fairly consistent across boards for a given enum.
File src/mainboard/hp/pro_3x00_series/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/85825/comment/066d47b8_c849134c?usp... : PS10, Line 3: define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB : #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
I already made a follow up for this, as Angel Pons requested.
Oh right, I even gave +2 on that patch.
-
Nicholas Chin (Code Review)