Hello Selma Bensaid,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/vboot/+/38910
to review the following change.
Change subject: [Debug] Disable Wimplicit-fallthrough ......................................................................
[Debug] Disable Wimplicit-fallthrough
Signed-off-by: Selma BENSAID selma.bensaid@intel.corp-partner.google.com Change-Id: Ib50af965b30509ba96b01c937474a9a064836e1f --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/vboot refs/changes/10/38910/1
diff --git a/Makefile b/Makefile index 0539e8d..62c0307 100644 --- a/Makefile +++ b/Makefile @@ -142,7 +142,7 @@ -Wundef -Wmissing-prototypes -Wno-trigraphs -Wredundant-decls -Wshadow \ -Wwrite-strings -Wstrict-aliasing -Wdate-time -Wno-unknown-warning \ -Wno-address-of-packed-member -ffunction-sections -fdata-sections \ - -Wimplicit-fallthrough ${DEBUG_FLAGS} + ${DEBUG_FLAGS}
# Note: FIRMWARE_ARCH is defined by the Chromium OS ebuild. ifeq (${FIRMWARE_ARCH},arm)
Hello Patrick Georgi, Martin Roth, Selma Bensaid,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/vboot/+/38910
to look at the new patch set (#2).
Change subject: [Debug] Disable Wimplicit-fallthrough ......................................................................
[Debug] Disable Wimplicit-fallthrough
Signed-off-by: Selma BENSAID selma.bensaid@intel.corp-partner.google.com Change-Id: Ib50af965b30509ba96b01c937474a9a064836e1f --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/vboot refs/changes/10/38910/2
Attention is currently required from: Selma Bensaid.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/vboot/+/38910?usp=email )
Change subject: [Debug] Disable Wimplicit-fallthrough ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: Please submit to chromium.org. This is a read-only mirror.
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/vboot/+/38910?usp=email )
Change subject: [Debug] Disable Wimplicit-fallthrough ......................................................................
Abandoned