[XS] Change in coreboot[main]: mb/amd/onyx: Use BMC SOL by default - coreboot-gerrit

10 Oct 2023


      Attention is currently required from: Arthur Heymans, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76509?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/amd/onyx: Use BMC SOL by default
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
File src/mainboard/amd/onyx/Kconfig:
https://review.coreboot.org/c/coreboot/+/76509/comment/a946ada6_2325a744 :
PS12, Line 19: # Use BMC SOL console by default
maybe "Use BMC SOL console on SoC UART1 by default"? at least for me that would make it a bit clearer that the bmc's ap console is connected to the soc uart 1. at least i'd assume that this is the case; haven't checked the schematic
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76509?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iefe61d25367bbe5cff0cacbfbafa32607de77d0f
Gerrit-Change-Number: 76509
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Varshit Pandya pandyavarshit@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 09 Oct 2023 22:15:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment