Change in coreboot[master]: arch/x86/tables: Measure table creation times

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38316 )

Change subject: arch/x86/tables: Measure table creation times
......................................................................

arch/x86/tables: Measure table creation times

Change-Id: I99382c5e10c4158a53aa30bd224f3d6bbfc3ecdf
Signed-off-by: Paul Menzel 
---
M src/arch/x86/tables.c
1 file changed, 22 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/38316/1

diff --git a/src/arch/x86/tables.c b/src/arch/x86/tables.c
index 8ecf86d..002728e 100644
--- a/src/arch/x86/tables.c
+++ b/src/arch/x86/tables.c
@@ -23,6 +23,7 @@
 #include <string.h>
 #include <cbmem.h>
 #include <smbios.h>
+#include <timer.h>

static unsigned long write_pirq_table(unsigned long rom_table_end)
 {
@@ -198,20 +199,37 @@
 {
    size_t sz;
    unsigned long rom_table_end = 0xf0000;
+	struct stopwatch sw;

/* This table must be between 0x0f0000 and 0x100000 */
-	if (CONFIG(GENERATE_PIRQ_TABLE))
+	if (CONFIG(GENERATE_PIRQ_TABLE)) {
+		stopwatch_init_msecs(&sw);
    	rom_table_end = write_pirq_table(rom_table_end);
+		printk(BIOS_SPEW, "write_pirq_table() took %lu ms\n",
+			stopwatch_duration_msecs(&sw));
+	}

/* The smp table must be in 0-1K, 639K-640K, or 960K-1M */
-	if (CONFIG(GENERATE_MP_TABLE))
+	if (CONFIG(GENERATE_MP_TABLE)) {
+		stopwatch_init_msecs(&sw);
    	rom_table_end = write_mptable(rom_table_end);
+		printk(BIOS_SPEW, "write_mptable() took %lu ms\n",
+			stopwatch_duration_msecs(&sw));
+	}

-	if (CONFIG(HAVE_ACPI_TABLES))
+	if (CONFIG(HAVE_ACPI_TABLES)) {
+		stopwatch_init_msecs(&sw);
    	rom_table_end = write_acpi_table(rom_table_end);
+		printk(BIOS_SPEW, "write_acpi_table() took %lu ms\n",
+			stopwatch_duration_msecs(&sw));
+	}

-	if (CONFIG(GENERATE_SMBIOS_TABLES))
+	if (CONFIG(GENERATE_SMBIOS_TABLES)) {
+		stopwatch_init_msecs(&sw);
    	rom_table_end = write_smbios_table(rom_table_end);
+		printk(BIOS_SPEW, "write_smbios_table() took %lu ms\n",
+			stopwatch_duration_msecs(&sw));
+	}

sz = write_coreboot_forwarding_table(forwarding_table, coreboot_table);

[Paul Menzel (Code Review)]

Paul Menzel has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/38316 )

Change subject: arch/x86/tables: Measure table creation times
......................................................................

arch/x86/tables: Measure table creation times

Change-Id: I99382c5e10c4158a53aa30bd224f3d6bbfc3ecdf
Signed-off-by: Paul Menzel 
---
M src/arch/x86/tables.c
1 file changed, 22 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/38316/2

[Paul Menzel (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38316

to look at the new patch set (#4).

Change subject: arch/x86/tables: Measure table creation times
......................................................................

arch/x86/tables: Measure table creation times

From QEMU i440fx:

```
BS: BS_POST_DEVICE run times (exec / console): 0 / 1 ms
Timestamp - cbmem post: 649464915
Timestamp - write tables: 650621389
Copying Interrupt Routing Table to 0x000f0000... done.
Copying Interrupt Routing Table to 0x3ffa4000... done.
PIRQ table: 128 bytes.
write_pirq_table() took 1 ms
QEMU: found ACPI tables in fw_cfg.
QEMU: loading "etc/acpi/rsdp" to 0x3ff80000 (len 20)
QEMU: loading "etc/acpi/tables" to 0x3ff80040 (len 131072)
QEMU: loaded ACPI tables from fw_cfg.
Looking on 0x3ff80000 for valid checksum
Checksum 1 passed
Checksum 2 passed all OK
ACPI:     * SSDT
Found 2 CPU(s).
ACPI: added table 4/32, length now 52
ACPI tables: 131136 bytes.
write_acpi_table() took 7 ms
smbios_write_tables: 3ff7f000
SMBIOS: Unknown CPU
DOMAIN: 0000 (QEMU Northbridge i440fx)
QEMU: found smbios tables in fw_cfg (len 389).
QEMU: coreboot type0 table found at 0x3ff7f020.
QEMU: loading smbios tables to 0x3ff7f064
SMBIOS tables: 489 bytes.
write_smbios_table() took 3 ms
```

Change-Id: I99382c5e10c4158a53aa30bd224f3d6bbfc3ecdf
Signed-off-by: Paul Menzel 
---
M src/arch/x86/tables.c
1 file changed, 22 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/38316/4

[S] Change in coreboot[master]: arch/x86/tables: Measure table creation times

[Stefan Reinauer (Code Review)]

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38316?usp=email )

Change subject: arch/x86/tables: Measure table creation times
......................................................................

Abandoned