Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41926 )
Change subject: soc/intel/common/block: Remove unused headers ......................................................................
soc/intel/common/block: Remove unused headers
Change-Id: I8877a70661cacc57ea893da172d9a4b6d19ba06a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/common/block/cpu/cpulib.c M src/soc/intel/common/block/power_limit/power_limit.c 2 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/41926/1
diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c index c39b453..7201432 100644 --- a/src/soc/intel/common/block/cpu/cpulib.c +++ b/src/soc/intel/common/block/cpu/cpulib.c @@ -9,10 +9,6 @@ #include <intelblocks/cpulib.h> #include <intelblocks/fast_spi.h> #include <intelblocks/msr.h> -#include <soc/cpu.h> -#include <soc/iomap.h> -#include <soc/pm.h> -#include <soc/pci_devs.h> #include <stdint.h>
/* diff --git a/src/soc/intel/common/block/power_limit/power_limit.c b/src/soc/intel/common/block/power_limit/power_limit.c index 2ac82b3..e6c65c3 100644 --- a/src/soc/intel/common/block/power_limit/power_limit.c +++ b/src/soc/intel/common/block/power_limit/power_limit.c @@ -5,7 +5,6 @@ #include <intelblocks/cpulib.h> #include <intelblocks/power_limit.h> #include <soc/msr.h> -#include <soc/soc_chip.h> #include <soc/systemagent.h>
/* Convert time in seconds to POWER_LIMIT_1_TIME MSR value */
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41926 )
Change subject: soc/intel/common/block: Remove unused headers ......................................................................
Patch Set 2: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41926 )
Change subject: soc/intel/common/block: Remove unused headers ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/41926 )
Change subject: soc/intel/common/block: Remove unused headers ......................................................................
Removed Verified+1 by build bot (Jenkins) no-reply@coreboot.org
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41926 )
Change subject: soc/intel/common/block: Remove unused headers ......................................................................
soc/intel/common/block: Remove unused headers
Change-Id: I8877a70661cacc57ea893da172d9a4b6d19ba06a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41926 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/soc/intel/common/block/cpu/cpulib.c M src/soc/intel/common/block/power_limit/power_limit.c 2 files changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c index c39b453..7201432 100644 --- a/src/soc/intel/common/block/cpu/cpulib.c +++ b/src/soc/intel/common/block/cpu/cpulib.c @@ -9,10 +9,6 @@ #include <intelblocks/cpulib.h> #include <intelblocks/fast_spi.h> #include <intelblocks/msr.h> -#include <soc/cpu.h> -#include <soc/iomap.h> -#include <soc/pm.h> -#include <soc/pci_devs.h> #include <stdint.h>
/* diff --git a/src/soc/intel/common/block/power_limit/power_limit.c b/src/soc/intel/common/block/power_limit/power_limit.c index 2ac82b3..e6c65c3 100644 --- a/src/soc/intel/common/block/power_limit/power_limit.c +++ b/src/soc/intel/common/block/power_limit/power_limit.c @@ -5,7 +5,6 @@ #include <intelblocks/cpulib.h> #include <intelblocks/power_limit.h> #include <soc/msr.h> -#include <soc/soc_chip.h> #include <soc/systemagent.h>
/* Convert time in seconds to POWER_LIMIT_1_TIME MSR value */
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41926 )
Change subject: soc/intel/common/block: Remove unused headers ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4479 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4478 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4477 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4476
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Subrata Banik (Code Review)