Change in coreboot[master]: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in ...coreboot[master]:...

Pavel Sayekat (Code Review)

8 Feb 2020 8 Feb '20

3:58 p.m.

Pavel Sayekat has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl

Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com --- M src/superio/nuvoton/nct5539d/acpi/superio.asl 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/38782/1

diff --git a/src/superio/nuvoton/nct5539d/acpi/superio.asl b/src/superio/nuvoton/nct5539d/acpi/superio.asl index 70a84a2..73bc938 100644 --- a/src/superio/nuvoton/nct5539d/acpi/superio.asl +++ b/src/superio/nuvoton/nct5539d/acpi/superio.asl @@ -1,7 +1,8 @@ +/* # SPDX-License-Identifier: GPL-2.0-only # This file is part of the coreboot project.

-/* + * Include this file into a mainboard's DSDT _SB device tree and it will * expose the NCT5539D SuperIO and some of its functionality. *

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Pavel Sayekat (Code Review)

8 Feb 8 Feb

4:18 p.m.

Hello Felix Held, Angel Pons, Arthur Heymans, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38782

to look at the new patch set (#2).

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/38782/2

Arthur Heymans (Code Review)

4:37 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38782/2/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/38782/2/src/superio/nuvoton/nct5539... PS2, Line 2: # SPDX-License-Identifier: GPL-2.0-only : # This file is part of the coreboot project. Other files use:

/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 2 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 08 Feb 2020 15:37:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

4:47 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38782/2/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/38782/2/src/superio/nuvoton/nct5539... PS2, Line 2: # SPDX-License-Identifier: GPL-2.0-only : # This file is part of the coreboot project.

...

Other files use: […]

Yes, it would be better to just replace the wrong `#` comment with C-style comments

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 2 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 08 Feb 2020 15:47:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Pavel Sayekat (Code Review)

4:51 p.m.

Hello Felix Held, Angel Pons, Arthur Heymans, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38782

to look at the new patch set (#3).

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/38782/3

Pavel Sayekat (Code Review)

4:59 p.m.

Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38782/2/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/38782/2/src/superio/nuvoton/nct5539... PS2, Line 2: # SPDX-License-Identifier: GPL-2.0-only : # This file is part of the coreboot project.

...

Yes, it would be better to just replace the wrong `#` comment with C-style comments

done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 3 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 08 Feb 2020 15:59:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Pavel Sayekat (Code Review)

5:14 p.m.

Hello Felix Held, Angel Pons, Arthur Heymans, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38782

to look at the new patch set (#4).

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/38782/4

Arthur Heymans (Code Review)

6:27 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38782/4/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/38782/4/src/superio/nuvoton/nct5539... PS4, Line 1: # remove the #

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 4 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 08 Feb 2020 17:27:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Felix Held (Code Review)

6:54 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

Patch Set 4:

oh, seems that i messed that up during the spdx header conversion. would be good to have a board in the coreboot tree using this super io so jenkins/abuild can catch these sorts of bugs

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 4 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 08 Feb 2020 17:54:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

7:20 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

Patch Set 4: Code-Review+1

...

Patch Set 4:

oh, seems that i messed that up during the spdx header conversion. would be good to have a board in the coreboot tree using this super io so jenkins/abuild can catch these sorts of bugs

This SIO was saved from removal because CB:34603 is using it. However, it was not build-tested so well, things happen.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 4 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 08 Feb 2020 18:20:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Pavel Sayekat (Code Review)

9 Feb 9 Feb

5:55 a.m.

Hello Felix Held, Angel Pons, Arthur Heymans, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38782

to look at the new patch set (#5).

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/38782/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 5 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Pavel Sayekat (Code Review)

6:06 a.m.

Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

Patch Set 5:

(1 comment)

...

Patch Set 4: Code-Review+1

...
Patch Set 4:

oh, seems that i messed that up during the spdx header conversion. would be good to have a board in the coreboot tree using this super io so jenkins/abuild can catch these sorts of bugs

This SIO was saved from removal because CB:34603 is using it. However, it was not build-tested so well, things happen.

Ok, I get it (no, I didn't). But does that make it eligible to be merged?

https://review.coreboot.org/c/coreboot/+/38782/4/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/38782/4/src/superio/nuvoton/nct5539... PS4, Line 1: #

...

remove the #

removed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 5 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 09 Feb 2020 05:06:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Felix Held (Code Review)

8:44 a.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

Patch Set 5: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/38782/2/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/38782/2/src/superio/nuvoton/nct5539... PS2, Line 2: # SPDX-License-Identifier: GPL-2.0-only : # This file is part of the coreboot project.

...

done

Done

https://review.coreboot.org/c/coreboot/+/38782/4/src/superio/nuvoton/nct5539... File src/superio/nuvoton/nct5539d/acpi/superio.asl:

https://review.coreboot.org/c/coreboot/+/38782/4/src/superio/nuvoton/nct5539... PS4, Line 1: #

...

removed.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 5 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 09 Feb 2020 07:44:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Comment-In-Reply-To: Pavel Sayekat Gerrit-MessageType: comment

Felix Held (Code Review)

8:45 a.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl

Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38782 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/nuvoton/nct5539d/acpi/superio.asl 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved

diff --git a/src/superio/nuvoton/nct5539d/acpi/superio.asl b/src/superio/nuvoton/nct5539d/acpi/superio.asl index 70a84a2..6f49421 100644 --- a/src/superio/nuvoton/nct5539d/acpi/superio.asl +++ b/src/superio/nuvoton/nct5539d/acpi/superio.asl @@ -1,5 +1,5 @@ -# SPDX-License-Identifier: GPL-2.0-only -# This file is part of the coreboot project. +/* SPDX-License-Identifier: GPL-2.0-only */ +/* This file is part of the coreboot project. */

/* * Include this file into a mainboard's DSDT _SB device tree and it will

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 6 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

8:57 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38782 )

Change subject: superio/nuvoton/nct5539d/acpi: fix # comment in superio.asl ......................................................................

Patch Set 6:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/508 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/507 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/506

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/38782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2ba1f9b744014f97d318671bf86468f4d6c6469 Gerrit-Change-Number: 38782 Gerrit-PatchSet: 6 Gerrit-Owner: Pavel Sayekat Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Pavel Sayekat Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 09 Feb 2020 07:57:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1749

days inactive

1750

days old

coreboot-gerrit@coreboot.org

14 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Angel Pons (Code Review)
Arthur Heymans (Code Review)
Felix Held (Code Review)
Pavel Sayekat (Code Review)