the following patch was just integrated into master: commit 8d9ffd93b59781299bb2ed06d7f9ad30c7aac41b Author: Paul Menzel paulepanter@users.sourceforge.net Date: Sat Apr 13 18:25:56 2013 +0200
cbmem: map_memory: Use length modifier `j` and cast for an `off_t` argument
cbmem currently fails to build due to `-Werror` and the following warning.
$ make cc -O2 -Wall -Werror -iquote ../../src/include -iquote ../../src/src/arch/x86 -c -o cbmem.o cbmem.c cbmem.c: In function ‘map_memory’: cbmem.c:87:2: error: format ‘%zx’ expects argument of type ‘size_t’, but argument 2 has type ‘off_t’ [-Werror=format] […]
Casting the argument of type `off_t` to `intmax_t` and using the length modifier `j`
$ man 3 printf […] j A following integer conversion corresponds to an intmax_t or uintmax_t argument. […]
instead of `z` as suggested in [1] and confirmed by stefanct and segher in #coreboot on <irc.freenode.net>, gets rid of this warning and should work an 32-bit and 64-bit systems, as an `off_t` fits into `intmax_t`.
[1] http://www.pixelbeat.org/programming/gcc/int_types/
Change-Id: I1360abbc47aa1662e1edfbe337cf7911695c532f Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-on: http://review.coreboot.org/3083 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich rminnich@gmail.com
Build-Tested: build bot (Jenkins) at Tue Apr 16 14:22:55 2013, giving +1 Reviewed-By: Ronald G. Minnich rminnich@gmail.com at Tue Apr 16 17:46:23 2013, giving +2 See http://review.coreboot.org/3083 for details.
-gerrit