Change in coreboot[master]: mb/supermicro: convert x11ssh to variants-capable tree structure
Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11/Kconfig A src/mainboard/supermicro/x11/Kconfig.name R src/mainboard/supermicro/x11/Makefile.inc R src/mainboard/supermicro/x11/acpi/ec.asl R src/mainboard/supermicro/x11/acpi/mainboard.asl R src/mainboard/supermicro/x11/acpi/superio.asl R src/mainboard/supermicro/x11/acpi_tables.c R src/mainboard/supermicro/x11/bootblock.c R src/mainboard/supermicro/x11/cmos.layout R src/mainboard/supermicro/x11/devicetree.cb R src/mainboard/supermicro/x11/dsdt.asl R src/mainboard/supermicro/x11/ramstage.c R src/mainboard/supermicro/x11/romstage.c A src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig A src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig.name R src/mainboard/supermicro/x11/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt 24 files changed, 164 insertions(+), 148 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/1
diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index 08689b7..62d8dd3 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -111,7 +111,7 @@ ## Supermicro
- [X10SLM+-F](supermicro/x10slm-f.md) -- [X11SSH-TF](supermicro/x11ssh-tf.md) +- [X11SSH-TF](supermicro/x11/ssh-tf/x11ssh-tf.md)
## UP
diff --git a/Documentation/mainboard/supermicro/x11ssh-tf.md b/Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md similarity index 100% rename from Documentation/mainboard/supermicro/x11ssh-tf.md rename to Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md diff --git a/Documentation/mainboard/supermicro/x11ssh_flash.jpg b/Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg similarity index 100% rename from Documentation/mainboard/supermicro/x11ssh_flash.jpg rename to Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg Binary files differ diff --git a/src/mainboard/supermicro/x11ssh/Kconfig b/src/mainboard/supermicro/x11/Kconfig similarity index 74% rename from src/mainboard/supermicro/x11ssh/Kconfig rename to src/mainboard/supermicro/x11/Kconfig index 4f18a80..98e1125 100644 --- a/src/mainboard/supermicro/x11ssh/Kconfig +++ b/src/mainboard/supermicro/x11/Kconfig @@ -1,5 +1,7 @@ -config BOARD_SUPERMICRO_BASEBOARD_X11SSH - def_bool n +if BOARD_SUPERMICRO_X11SSH_TF + +config BOARD_SPECIFIC_OPTIONS + def_bool y select BOARD_ROMSIZE_KB_16384 select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES @@ -12,7 +14,17 @@ select GENERATE_SMBIOS_TABLES select IPMI_KCS
-if BOARD_SUPERMICRO_BASEBOARD_X11SSH +config MAINBOARD_DIR + string + default "supermicro/x11" + +config OVERRIDE_DEVICETREE + string + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" + +config MAINBOARD_FAMILY + string + default "Supermicro_X11"
config VBOOT select VBOOT_NO_BOARD_SUPPORT @@ -28,34 +40,18 @@ hex default 0x2a
+config CBFS_SIZE + hex + default 0xb00000 if VBOOT + config FMDFILE string default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/vboot-ro-rwab.fmd" if VBOOT_SLOTS_RW_AB
-config CBFS_SIZE - hex - default 0x009aa000 if !VBOOT - config IRQ_SLOT_COUNT int default 18
-config MAINBOARD_DIR - string - default "supermicro/x11ssh" - -config VARIANT_DIR - string - default "tf" if BOARD_SUPERMICRO_X11SSH_PLUS_TF - -config DEVICETREE - string - default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" - -config MAINBOARD_PART_NUMBER - string - default "X11SSH-TF" if BOARD_SUPERMICRO_X11SSH_PLUS_TF - config MAX_CPUS int default 8 @@ -76,4 +72,6 @@ int default 512
-endif # BOARD_SUPERMICRO_BASEBOARD_X11SSH +source "src/mainboard/supermicro/x11/variants/*/Kconfig" + +endif # BOARD_SUPERMICRO_X11SSH_TF diff --git a/src/mainboard/supermicro/x11/Kconfig.name b/src/mainboard/supermicro/x11/Kconfig.name new file mode 100644 index 0000000..ec23e7d --- /dev/null +++ b/src/mainboard/supermicro/x11/Kconfig.name @@ -0,0 +1 @@ +source "src/mainboard/supermicro/x11/variants/*/Kconfig.name" diff --git a/src/mainboard/supermicro/x11ssh/Makefile.inc b/src/mainboard/supermicro/x11/Makefile.inc similarity index 100% rename from src/mainboard/supermicro/x11ssh/Makefile.inc rename to src/mainboard/supermicro/x11/Makefile.inc diff --git a/src/mainboard/supermicro/x11ssh/acpi/ec.asl b/src/mainboard/supermicro/x11/acpi/ec.asl similarity index 100% rename from src/mainboard/supermicro/x11ssh/acpi/ec.asl rename to src/mainboard/supermicro/x11/acpi/ec.asl diff --git a/src/mainboard/supermicro/x11ssh/acpi/mainboard.asl b/src/mainboard/supermicro/x11/acpi/mainboard.asl similarity index 100% rename from src/mainboard/supermicro/x11ssh/acpi/mainboard.asl rename to src/mainboard/supermicro/x11/acpi/mainboard.asl diff --git a/src/mainboard/supermicro/x11ssh/acpi/superio.asl b/src/mainboard/supermicro/x11/acpi/superio.asl similarity index 100% rename from src/mainboard/supermicro/x11ssh/acpi/superio.asl rename to src/mainboard/supermicro/x11/acpi/superio.asl diff --git a/src/mainboard/supermicro/x11ssh/acpi_tables.c b/src/mainboard/supermicro/x11/acpi_tables.c similarity index 100% rename from src/mainboard/supermicro/x11ssh/acpi_tables.c rename to src/mainboard/supermicro/x11/acpi_tables.c diff --git a/src/mainboard/supermicro/x11ssh/bootblock.c b/src/mainboard/supermicro/x11/bootblock.c similarity index 97% rename from src/mainboard/supermicro/x11ssh/bootblock.c rename to src/mainboard/supermicro/x11/bootblock.c index 8bc8ab0..27653f5 100644 --- a/src/mainboard/supermicro/x11ssh/bootblock.c +++ b/src/mainboard/supermicro/x11/bootblock.c @@ -15,7 +15,7 @@
#include <bootblock_common.h> #include <soc/gpio.h> -#include "gpio.h" +#include <variant/gpio.h> #include <superio/aspeed/common/aspeed.h> #include <superio/aspeed/ast2400/ast2400.h> #include <delay.h> diff --git a/src/mainboard/supermicro/x11ssh/cmos.layout b/src/mainboard/supermicro/x11/cmos.layout similarity index 100% rename from src/mainboard/supermicro/x11ssh/cmos.layout rename to src/mainboard/supermicro/x11/cmos.layout diff --git a/src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb b/src/mainboard/supermicro/x11/devicetree.cb similarity index 60% rename from src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb rename to src/mainboard/supermicro/x11/devicetree.cb index ce6bfa5..ea4f7a1 100644 --- a/src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb +++ b/src/mainboard/supermicro/x11/devicetree.cb @@ -5,19 +5,6 @@ register "deep_s5_enable_dc" = "0" register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN"
- # GPE configuration - # Note that GPE events called out in ASL code rely on this - # route. i.e. If this route changes then the affected GPE - # offset bits also need to be changed. - register "gpe0_dw0" = "GPP_B" - register "gpe0_dw1" = "GPP_D" - register "gpe0_dw2" = "GPP_E" - - register "gen1_dec" = "0x007c0a01" # Super IO SWC - register "gen2_dec" = "0x000c0ca1" # IPMI KCS - register "gen3_dec" = "0x000c03e1" # UART3 - register "gen4_dec" = "0x000c02e1" # UART4 - # Enable "Intel Speed Shift Technology" register "speed_shift_enable" = "1"
@@ -102,23 +89,6 @@ # LPC register "serirq_mode" = "SERIRQ_CONTINUOUS"
- # PCIe configuration - # Enable JPCIE1 - register "PcieRpEnable[0]" = "1" - register "PcieRpClkReqSupport[0]" = "0" - - # Enable ASpeed PCI bridge - register "PcieRpEnable[2]" = "1" - register "PcieRpClkReqSupport[2]" = "0" - - # Enable X550T (10GbE) - register "PcieRpEnable[4]" = "1" - register "PcieRpClkReqSupport[4]" = "0" - - # Enable M.2 - register "PcieRpEnable[8]" = "1" - register "PcieRpClkReqSupport[8]" = "0" - # Enabling SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch # SLP_S3 Minimum Assertion Width. Values 0: 60us, 1: 1ms, 2: 50ms, 3: 2s register "PmConfigSlpS3MinAssert" = "0x02" @@ -201,90 +171,25 @@ device lapic 0 on end end device domain 0 on - device pci 00.0 on end # Host Bridge - device pci 01.0 on end # unused - device pci 01.1 on - smbios_slot_desc "SlotTypePciExpressGen3X8" "SlotLengthShort" "CPU SLOT6 PCI-E 3.0 X8" "SlotDataBusWidth4X" - end # PCIE Slot (JPCIE1) - device pci 04.0 on end # SA thermal subsystem - device pci 14.0 on end # USB xHCI - device pci 14.1 off end # USB xDCI (OTG) - device pci 14.2 on end # Thermal Subsystem - device pci 16.0 on end # Management Engine Interface 1 - device pci 16.1 on end # Management Engine Interface 2 - device pci 17.0 on end # SATA - device pci 1c.0 on - smbios_slot_desc "SlotTypePciExpressGen3X4" "SlotLengthLong" "PCH SLOT4 PCI-E 3.0 X2(IN X4)" "SlotDataBusWidth2X" - end # PCI Express Port 1 (Slot JPCIE1) - device pci 1c.2 on - device pci 00.0 on - device pci 00.0 on end # Aspeed 2400 VGA - end - end # PCI Express Port 3 - device pci 1c.4 on - device pci 00.0 on end # 10GbE - device pci 00.1 on end # 10GbE - end # PCI Express Port 5 - device pci 1d.0 on - smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2 2280" "SlotDataBusWidth4X" - end # PCI Express Port 9 - device pci 1f.0 on - chip drivers/ipmi - # On cold boot it takes a while for the BMC to start the IPMI service - register "wait_for_bmc" = "1" - register "bmc_boot_timeout" = "60" - device pnp ca2.0 on end # IPMI KCS - end + device pci 00.0 on end # Host Bridge + device pci 04.0 on end # SA thermal subsystem + device pci 14.0 on end # USB xHCI + device pci 14.1 off end # USB xDCI (OTG) + device pci 14.2 on end # Thermal Subsystem + device pci 16.0 on end # Management Engine Interface 1 + device pci 16.1 on end # Management Engine Interface 2 + device pci 17.0 on end # SATA + device pci 1f.0 on # LPC Interface chip superio/common - device pnp 2e.0 on - chip superio/aspeed/ast2400 - device pnp 2e.2 on # SUART1 - io 0x60 = 0x3f8 - irq 0x70 = 4 - end - device pnp 2e.3 on # SUART2 - io 0x60 = 0x2f8 - irq 0x70 = 3 - end - device pnp 2e.4 on # SWC - io 0x60 = 0xa00 - io 0x62 = 0xa10 - io 0x64 = 0xa20 - io 0x66 = 0xa30 - irq 0x70 = 0xb - end - device pnp 2e.5 on # Keyboard - io 0x60 = 0x60 - io 0x62 = 0x64 - irq 0x70 = 1 - irq 0x72 = 0xc - end - device pnp 2e.7 on # GPIO - end - device pnp 2e.b on # SUART3 - io 0x60 = 0x3e8 - irq 0x70 = 4 - end - device pnp 2e.c on # SUART4 - io 0x60 = 0x2e8 - irq 0x70 = 3 - end - device pnp 2e.d on # iLPC2AHB - end - device pnp 2e.e on # Mailbox - io 0x60 = 0xa40 - irq 0x70 = 0x00 - end - end - end + device pnp 2e.0 on end end - chip drivers/pc80/tpm + chip drivers/pc80/tpm # TPM device pnp 0c31.0 on end end - end # LPC Interface - device pci 1f.1 on end # P2SB - device pci 1f.2 on end # Power Management Controller - device pci 1f.4 on end # SMBus - device pci 1f.5 on end # SPI Controller + end + device pci 1f.1 on end # P2SB + device pci 1f.2 on end # Power Management Controller + device pci 1f.4 on end # SMBus + device pci 1f.5 on end # SPI Controller end end diff --git a/src/mainboard/supermicro/x11ssh/dsdt.asl b/src/mainboard/supermicro/x11/dsdt.asl similarity index 100% rename from src/mainboard/supermicro/x11ssh/dsdt.asl rename to src/mainboard/supermicro/x11/dsdt.asl diff --git a/src/mainboard/supermicro/x11ssh/ramstage.c b/src/mainboard/supermicro/x11/ramstage.c similarity index 96% rename from src/mainboard/supermicro/x11ssh/ramstage.c rename to src/mainboard/supermicro/x11/ramstage.c index 2672f73..f27aefc 100644 --- a/src/mainboard/supermicro/x11ssh/ramstage.c +++ b/src/mainboard/supermicro/x11/ramstage.c @@ -13,7 +13,7 @@
#include <bootstate.h> #include <soc/ramstage.h> -#include "gpio.h" +#include <variant/gpio.h>
void mainboard_silicon_init_params(FSP_SIL_UPD *params) { diff --git a/src/mainboard/supermicro/x11ssh/romstage.c b/src/mainboard/supermicro/x11/romstage.c similarity index 100% rename from src/mainboard/supermicro/x11ssh/romstage.c rename to src/mainboard/supermicro/x11/romstage.c diff --git a/src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig b/src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig new file mode 100644 index 0000000..f8954da --- /dev/null +++ b/src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig @@ -0,0 +1,15 @@ +if BOARD_SUPERMICRO_X11SSH_TF + +config VARIANT_DIR + string + default "ssh-tf" + +config MAINBOARD_PART_NUMBER + string + default "X11SSH-TF" + +config CBFS_SIZE + hex + default 0x009aa000 if !VBOOT + +endif # BOARD_SUPERMICRO_X11SSH_TF diff --git a/src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig.name b/src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig.name new file mode 100644 index 0000000..fe3bf71 --- /dev/null +++ b/src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig.name @@ -0,0 +1,2 @@ +config BOARD_SUPERMICRO_X11SSH_TF + bool "X11SSH-TF" diff --git a/src/mainboard/supermicro/x11ssh/variants/tf/board_info.txt b/src/mainboard/supermicro/x11/variants/ssh-tf/board_info.txt similarity index 61% rename from src/mainboard/supermicro/x11ssh/variants/tf/board_info.txt rename to src/mainboard/supermicro/x11/variants/ssh-tf/board_info.txt index f3eb3ef..893ccf4 100644 --- a/src/mainboard/supermicro/x11ssh/variants/tf/board_info.txt +++ b/src/mainboard/supermicro/x11/variants/ssh-tf/board_info.txt @@ -1,6 +1,7 @@ +Category: server Vendor name: Supermicro Board name: X11SSH-TF -Category: server +Board URL: https://www.supermicro.com/en/products/motherboard/X11SSH-TF ROM protocol: SPI ROM socketed: n Flashrom support: y diff --git a/src/mainboard/supermicro/x11/variants/ssh-tf/devicetree.cb b/src/mainboard/supermicro/x11/variants/ssh-tf/devicetree.cb new file mode 100644 index 0000000..f979b67 --- /dev/null +++ b/src/mainboard/supermicro/x11/variants/ssh-tf/devicetree.cb @@ -0,0 +1,103 @@ +chip soc/intel/skylake + + # GPE configuration + # Note that GPE events called out in ASL code rely on this + # route. i.e. If this route changes then the affected GPE + # offset bits also need to be changed. + register "gpe0_dw0" = "GPP_B" + register "gpe0_dw1" = "GPP_D" + register "gpe0_dw2" = "GPP_E" + + register "gen1_dec" = "0x007c0a01" # Super IO SWC + register "gen2_dec" = "0x000c0ca1" # IPMI KCS + register "gen3_dec" = "0x000c03e1" # UART3 + register "gen4_dec" = "0x000c02e1" # UART4 + + # PCIe configuration + # Enable JPCIE1 + register "PcieRpEnable[0]" = "1" + register "PcieRpClkReqSupport[0]" = "0" + + # Enable ASpeed PCI bridge + register "PcieRpEnable[2]" = "1" + register "PcieRpClkReqSupport[2]" = "0" + + # Enable X550T (10GbE) + register "PcieRpEnable[4]" = "1" + register "PcieRpClkReqSupport[4]" = "0" + + # Enable M.2 + register "PcieRpEnable[8]" = "1" + register "PcieRpClkReqSupport[8]" = "0" + + device domain 0 on + device pci 01.0 on end # unused + device pci 01.1 on + smbios_slot_desc "SlotTypePciExpressGen3X8" "SlotLengthShort" "CPU SLOT6 PCI-E 3.0 X8" "SlotDataBusWidth4X" + end # PCIE Slot (JPCIE1) + device pci 1c.0 on + smbios_slot_desc "SlotTypePciExpressGen3X4" "SlotLengthLong" "PCH SLOT4 PCI-E 3.0 X2(IN X4)" "SlotDataBusWidth2X" + end # PCI Express Port 1 (Slot JPCIE1) + device pci 1c.2 on + device pci 00.0 on + device pci 00.0 on end # Aspeed 2400 VGA + end + end # PCI Express Port 3 + device pci 1c.4 on + device pci 00.0 on end # 10GbE + device pci 00.1 on end # 10GbE + end # PCI Express Port 5 + device pci 1d.0 on + smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2 2280" "SlotDataBusWidth4X" + end # PCI Express Port 9 + device pci 1f.0 on # LPC Interface + chip drivers/ipmi + # On cold boot it takes a while for the BMC to start the IPMI service + register "wait_for_bmc" = "1" + register "bmc_boot_timeout" = "60" + device pnp ca2.0 on end # IPMI KCS + end + chip superio/common + device pnp 2e.0 on + chip superio/aspeed/ast2400 + device pnp 2e.2 on # SUART1 + io 0x60 = 0x3f8 + irq 0x70 = 4 + end + device pnp 2e.3 on # SUART2 + io 0x60 = 0x2f8 + irq 0x70 = 3 + end + device pnp 2e.4 on # SWC + io 0x60 = 0xa00 + io 0x62 = 0xa10 + io 0x64 = 0xa20 + io 0x66 = 0xa30 + irq 0x70 = 0xb + end + device pnp 2e.5 on # Keyboard + io 0x60 = 0x60 + io 0x62 = 0x64 + irq 0x70 = 1 + irq 0x72 = 0xc + end + device pnp 2e.7 on end # GPIO + device pnp 2e.b on # SUART3 + io 0x60 = 0x3e8 + irq 0x70 = 4 + end + device pnp 2e.c on # SUART4 + io 0x60 = 0x2e8 + irq 0x70 = 3 + end + device pnp 2e.d on end # iLPC2AHB + device pnp 2e.e on # Mailbox + io 0x60 = 0xa40 + irq 0x70 = 0x00 + end + end + end + end + end + end +end diff --git a/src/mainboard/supermicro/x11ssh/gpio.h b/src/mainboard/supermicro/x11/variants/ssh-tf/include/variant/gpio.h similarity index 100% rename from src/mainboard/supermicro/x11ssh/gpio.h rename to src/mainboard/supermicro/x11/variants/ssh-tf/include/variant/gpio.h diff --git a/src/mainboard/supermicro/x11ssh/vboot-ro-rwab.fmd b/src/mainboard/supermicro/x11/vboot-ro-rwab.fmd similarity index 100% rename from src/mainboard/supermicro/x11ssh/vboot-ro-rwab.fmd rename to src/mainboard/supermicro/x11/vboot-ro-rwab.fmd diff --git a/src/mainboard/supermicro/x11ssh/Kconfig.name b/src/mainboard/supermicro/x11ssh/Kconfig.name deleted file mode 100644 index a9b351b..0000000 --- a/src/mainboard/supermicro/x11ssh/Kconfig.name +++ /dev/null @@ -1,3 +0,0 @@ -config BOARD_SUPERMICRO_X11SSH_PLUS_TF - bool "X11SSH+-TF" - select BOARD_SUPERMICRO_BASEBOARD_X11SSH diff --git a/src/mainboard/supermicro/x11ssh/board_info.txt b/src/mainboard/supermicro/x11ssh/board_info.txt deleted file mode 100644 index 029d2a9..0000000 --- a/src/mainboard/supermicro/x11ssh/board_info.txt +++ /dev/null @@ -1,6 +0,0 @@ -Vendor name: Supermicro -Board name: X11SSH Baseboard -Category: server -ROM protocol: SPI -ROM socketed: n -Flashrom support: y
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#2).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11/Kconfig A src/mainboard/supermicro/x11/Kconfig.name R src/mainboard/supermicro/x11/Makefile.inc R src/mainboard/supermicro/x11/acpi/ec.asl R src/mainboard/supermicro/x11/acpi/mainboard.asl R src/mainboard/supermicro/x11/acpi/superio.asl R src/mainboard/supermicro/x11/acpi_tables.c R src/mainboard/supermicro/x11/bootblock.c R src/mainboard/supermicro/x11/cmos.layout R src/mainboard/supermicro/x11/devicetree.cb R src/mainboard/supermicro/x11/dsdt.asl R src/mainboard/supermicro/x11/ramstage.c R src/mainboard/supermicro/x11/romstage.c A src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig A src/mainboard/supermicro/x11/variants/ssh-tf/Kconfig.name R src/mainboard/supermicro/x11/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt 24 files changed, 164 insertions(+), 148 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
Please use lenovo/t530 as reference. Also naming the basefolder x11 seems to make no sense as there are 28 boards with that naming and at least one isn't compatible to x11ssh.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
Patch Set 2:
Please use lenovo/t530 as reference.
What _exactly_ do you mean?
Also naming the basefolder x11 seems to make no sense as there are 28 boards with that naming and at least one isn't compatible to x11ssh.
Then suggest a better naming, please. Naming it "x11ss" wouldn't fit, same problem. Naming it "x11ssh" would be wrong, too.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Please use lenovo/t530 as reference.
What _exactly_ do you mean?
If you mean the baseboard scheme: that would not be correct as there is no such. x11ssh and x11ssm and others are very similiar but are different boards. I used the Gigabyte boards' scheme.
Also naming the basefolder x11 seems to make no sense as there are 28 boards with that naming and at least one isn't compatible to x11ssh.
Then suggest a better naming, please. Naming it "x11ss" wouldn't fit, same problem. Naming it "x11ssh" would be wrong, too.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
(5 comments)
Patch Set 2:
Patch Set 2:
Patch Set 2:
Please use lenovo/t530 as reference.
What _exactly_ do you mean?
If you mean the baseboard scheme: that would not be correct as there is no such. x11ssh and x11ssm and others are very similiar but are different boards. I used the Gigabyte boards' scheme.
Which gigabyte boards? The GA-H61M-S2PV? The scheme here looks a bit different, though.
Also naming the basefolder x11 seems to make no sense as there are 28 boards with that naming and at least one isn't compatible to x11ssh.
Then suggest a better naming, please. Naming it "x11ss" wouldn't fit, same problem. Naming it "x11ssh" would be wrong, too.
The Gigabyte boards have the name of the first board that was added. If I were to rename them, I thought of "ga-h61m-series" because they all have the H61 PCH.
For these boards, I think the PCH differs, but the socket is constant. So I'd probably use "x11-lga1150-series" or something like that.
Or if you can't find a name that everybody likes, just leave the current name as-is and cut out the bikeshedding :-)
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 45: default 0xb00000 if VBOOT Did this change on purpose?
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 75: source "src/mainboard/supermicro/x11/variants/*/Kconfig" Is there a need for this? Now there will be more files to maintain :/
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 1: source "src/mainboard/supermicro/x11/variants/*/Kconfig.name" Is there a need for this either? Now there will be a lot of very short files :/
Plus this file usually shows which variants are in a mainboard, for instance.
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 174: I'd suggest using tabs for this
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 177: Otherwise, misalignments happen like this one
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
Patch Set 2:
(5 comments)
Patch Set 2:
Patch Set 2:
Patch Set 2:
Please use lenovo/t530 as reference.
What _exactly_ do you mean?
If you mean the baseboard scheme: that would not be correct as there is no such. x11ssh and x11ssm and others are very similiar but are different boards. I used the Gigabyte boards' scheme.
Which gigabyte boards? The GA-H61M-S2PV? The scheme here looks a bit different, though.
Also naming the basefolder x11 seems to make no sense as there are 28 boards with that naming and at least one isn't compatible to x11ssh.
Then suggest a better naming, please. Naming it "x11ss" wouldn't fit, same problem. Naming it "x11ssh" would be wrong, too.
The Gigabyte boards have the name of the first board that was added. If I were to rename them, I thought of "ga-h61m-series" because they all have the H61 PCH.
For these boards, I think the PCH differs, but the socket is constant. So I'd probably use "x11-lga1150-series" or something like that.
Or if you can't find a name that everybody likes, just leave the current name as-is and cut out the bikeshedding :-)
Well, I am not sure what Patrick meant... if he meant Kconfig style I based this on the scheme ga-b75m Gigabyte boards used which do not have a baseboard, too. Further IMHO my Kconfig style here is way more readable as it does not use "if" in every second line but pulls the settings from the variants folder.
What about x11-c236-series?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 75: source "src/mainboard/supermicro/x11/variants/*/Kconfig"
Is there a need for this? Now there will be more files to maintain :/
This makes the Kconfig style way more readable by omitting "if" in every second line and moving variant-specific config to the variants folder. see https://review.coreboot.org/c/coreboot/+/35427
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 1: source "src/mainboard/supermicro/x11/variants/*/Kconfig.name"
Is there a need for this either? Now there will be a lot of very short files :/ […]
Well, I could live with putting all board names here but I *strongly* vote for using the Kconfig sourcing for the variant-specific stuff
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 174:
I'd suggest using tabs for this
Good idea, I'll change this
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
(5 comments)
Patch Set 2:
Patch Set 2:
Patch Set 2:
Please use lenovo/t530 as reference.
What _exactly_ do you mean?
If you mean the baseboard scheme: that would not be correct as there is no such. x11ssh and x11ssm and others are very similiar but are different boards. I used the Gigabyte boards' scheme.
Which gigabyte boards? The GA-H61M-S2PV? The scheme here looks a bit different, though.
Also naming the basefolder x11 seems to make no sense as there are 28 boards with that naming and at least one isn't compatible to x11ssh.
Then suggest a better naming, please. Naming it "x11ss" wouldn't fit, same problem. Naming it "x11ssh" would be wrong, too.
The Gigabyte boards have the name of the first board that was added. If I were to rename them, I thought of "ga-h61m-series" because they all have the H61 PCH.
For these boards, I think the PCH differs, but the socket is constant. So I'd probably use "x11-lga1150-series" or something like that.
Or if you can't find a name that everybody likes, just leave the current name as-is and cut out the bikeshedding :-)
Well, I am not sure what Patrick meant... if he meant Kconfig style I based this on the scheme ga-b75m Gigabyte boards used which do not have a baseboard, too. Further IMHO my Kconfig style here is way more readable as it does not use "if" in every second line but pulls the settings from the variants folder.
What about x11-c236-series?
Meh. x11-c236 is a bad.... I checked the other boards again; supermicro's naming is not really clear. I guess x11-lga1151-series is the best choice here..
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2: Code-Review-1
I don't see the benefit here. Why do we group the boards by socket or southbridge? And not keep the old style x11ssh as baseboard with it's variants t, TF etc.?
Do we do this style of grouping somewhere else? I really don't like this type of grouping because it makes it more unclear. So when I have a x11sch-f , I first need to check socket or sb and then I can find it in the tree?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 45: default 0xb00000 if VBOOT
Did this change on purpose?
That's not a change but an addition, but I just realized we can drop "if VBOOT" because for vboot the size is defined in fmap. I'm not sure why they have 0x9aa000 in their Kconfig. At least x11ssh and x11ssm have a bios region of 0xb00000 but as I don't want to change the behaviour/effective config in this CR I left it as is but moved this to the variant's Kconfig.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
I don't see the benefit here. Why do we group the boards by socket or southbridge? And not keep the old style x11ssh as baseboard with it's variants t, TF etc.?
Do we do this style of grouping somewhere else? I really don't like this type of grouping because it makes it more unclear. So when I have a x11sch-f , I first need to check socket or sb and then I can find it in the tree?
It does not make any sense to have a separate mainboard tree for all these variants because they only differ very little. x11ssh and x11ssm are more or less the same board with just a difference in available PCIe ports. The -TF -F etc. describes the external interfaces (-T for 10GbE, -F for IPMS)
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
I first need to check socket or sb and then I can find it in the tree?
What about `find src/mainboard | grep sch-f`?
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
I get why you want this but in my opinion it violates the naming convention and makes the tree less readable/logical.
Patch Set 2:
I first need to check socket or sb and then I can find it in the tree?
What about `find src/mainboard | grep sch-f`?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 2:
Patch Set 2:
I get why you want this but in my opinion it violates the naming convention and makes the tree less readable/logical.
Patch Set 2:
I first need to check socket or sb and then I can find it in the tree?
What about `find src/mainboard | grep sch-f`?
Well, the problem here is that supermicro has a bad naming scheme. I am open to discussion and IMHO it's very important to have conventions and stick to them but in this case supermicro's bad naming scheme requires some unconventional tree. We really should not waste our time discussing this _too_ much :-) Isn't it more important to get more boards supported than any naming scheme? ;-)
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#3).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout R src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt 23 files changed, 163 insertions(+), 148 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/3
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#4).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout R src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt 23 files changed, 163 insertions(+), 148 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/4
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#5).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout R src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt 23 files changed, 163 insertions(+), 148 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/5
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#6).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout R src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt 23 files changed, 163 insertions(+), 148 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/6
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#7).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/7
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#8).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/8
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#9).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/9
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#10).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/10
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#11).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/11
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#12).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/12
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#13).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/13
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#14).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/14
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#15).
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to variants-capable tree structure
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/15
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 16:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 45: default 0xb00000 if VBOOT
That's not a change but an addition, but I just realized we can drop "if VBOOT" because for vboot th […]
Done
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 75: source "src/mainboard/supermicro/x11/variants/*/Kconfig"
This makes the Kconfig style way more readable by omitting "if" in every second line and moving vari […]
Done
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 1: source "src/mainboard/supermicro/x11/variants/*/Kconfig.name"
Well, I could live with putting all board names here but I *strongly* vote for using the Kconfig sou […]
Done
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 174:
Good idea, I'll change this
Done
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1... PS2, Line 177:
Otherwise, misalignments happen like this one
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35426/16/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35426/16/Documentation/mainboard/su... PS16, Line 72: [flashing tutorial]: ../../flash_tutorial/ext_power.md fix all paths
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 1: if BOARD_SUPERMICRO_X11SSH_TF _BASEBOARD_ missing
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 23: devicetree overridetree.cb
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 1: if BOARD_SUPERMICRO_X11SSH_TF
_BASEBOARD_ missing
No, there is no "baseboard" for these boards. x11ssh and x11ssm for example (see 35427) are different (but very similiar) boards. See Gigabyte ga-945gcm-s2l for example. This suggestion came from @hellsenberg in 32734
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 16:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 1: if BOARD_SUPERMICRO_X11SSH_TF
_BASEBOARD_ missing
The used variant mechanism does not have a "baseboard" (it doesn't make sense when one doesn't know which board would be the "baseboard").
Think of it as if it was a board group: similar boards, which share a lot of common code, are grouped together to reuse said common code.
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 23: devicetree
overridetree. […]
Either overridetree.cb here, and make the relevant files proper overridetrees, or instead use: config DEVICETREE
The former would be preferred.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 16:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 1: if BOARD_SUPERMICRO_X11SSH_TF
You got a devicetree.cb and overridetree.cb. The devicetree. […]
@Patrick yep, I will change the devicetree stuff... but hey, it's just filenames, isn't it? :P
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#17).
Change subject: mb/supermicro: convert x11ssh to a variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to a variants-capable tree structure
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
As there is no official "baseboard" the BASEBOARD scheme is not used here. Instead this is more like a mainboard "group".
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig R src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 358 insertions(+), 324 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/17
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to a variants-capable tree structure ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 1: if BOARD_SUPERMICRO_X11SSH_TF
@Patrick yep, I will change the devicetree stuff... […]
Done
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 23: devicetree
Either overridetree.cb here, and make the relevant files proper overridetrees, or instead use: […]
Done
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to a variants-capable tree structure ......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35426/16/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11/ssh-tf/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35426/16/Documentation/mainboard/su... PS16, Line 72: [flashing tutorial]: ../../flash_tutorial/ext_power.md
fix all paths
Done
Hello Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#18).
Change subject: mb/supermicro: convert x11ssh to a variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to a variants-capable tree structure
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
As there is no official "baseboard" the BASEBOARD scheme is not used here. Instead this is more like a mainboard "group".
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig R src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 358 insertions(+), 324 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/18
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to a variants-capable tree structure ......................................................................
Patch Set 18: Code-Review+1
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#19).
Change subject: mb/supermicro: convert x11ssh to a variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to a variants-capable tree structure
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 26 files changed, 362 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/19
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#20).
Change subject: mb/supermicro: convert x11ssh to a variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to a variants-capable tree structure
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 26 files changed, 363 insertions(+), 329 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/20
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#21).
Change subject: mb/supermicro: convert x11ssh to a variants-capable tree structure ......................................................................
mb/supermicro: convert x11ssh to a variants-capable tree structure
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/Kconfig R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 26 files changed, 363 insertions(+), 329 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/21
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#22).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/22
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#23).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 353 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/23
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#24).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/24
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#25).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/25
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#26).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/26
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 26:
I admit I did not read through all the commit messages for argumentation why you want the directory renamed.
Use of variants/ is welcome for sure for similar board ports. While the base directory name can be somewhat arbitrary, including the socket type 'lga1151-series' there is kind of introducing a completely new naming scheme; I am not so convinced that we want that. Sometimes we have just kept the name of the first ported board as the base directory name, IMHO that would have been just fine here.
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#27).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences. To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/27
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 27:
Patch Set 26:
I admit I did not read through all the commit messages for argumentation why you want the directory renamed.
That's the problem here ;-) The discussion is going on since weeks.
Use of variants/ is welcome for sure for similar board ports. While the base directory name can be somewhat arbitrary, including the socket type 'lga1151-series' there is kind of introducing a completely new naming scheme; I am not so convinced that we want that. Sometimes we have just kept the name of the first ported board as the base directory name, IMHO that would have been just fine here.
I really do NOT want to discuss this another time. We already discussed this a) 4 times on gerrit and b) multiple times in IRC. We agreed on 'lga1151-series'.
Sometimes we have just kept the name of the first ported board
This would be very bad because there are about 20 boards we can support in this series.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 27:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@11 PS27, Line 11: see CR 35427 Need needed. If it is, please use the Change-Id and the commit message summary.
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@9 PS27, Line 9: Most of the X11 boards with socket LGA1151 are basically the same : boards with just some minor differences. : To be able to add more x11 boards easily like x11ssm (see CR 35427) : this restructures the x11ssh tree. Please do not break the line after a sentence. If these are supposed to be paragraphs please add a blank line between them.
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@13 PS27, Line 13: Please elaborate a little bit. You rename the directory. What else?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 27:
Patch Set 27:
Patch Set 26:
I admit I did not read through all the commit messages for argumentation why you want the directory renamed.
That's the problem here ;-) The discussion is going on since weeks.
Use of variants/ is welcome for sure for similar board ports. While the base directory name can be somewhat arbitrary, including the socket type 'lga1151-series' there is kind of introducing a completely new naming scheme; I am not so convinced that we want that. Sometimes we have just kept the name of the first ported board as the base directory name, IMHO that would have been just fine here.
I really do NOT want to discuss this another time. We already discussed this a) 4 times on gerrit and b) multiple times in IRC. We agreed on 'lga1151-series'.
Sometimes we have just kept the name of the first ported board
This would be very bad because there are about 20 boards we can support in this series.
Please summarize the discussion in the commit message.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 27:
(2 comments)
Patch Set 27:
Patch Set 27:
Patch Set 26:
I admit I did not read through all the commit messages for argumentation why you want the directory renamed.
That's the problem here ;-) The discussion is going on since weeks.
Use of variants/ is welcome for sure for similar board ports. While the base directory name can be somewhat arbitrary, including the socket type 'lga1151-series' there is kind of introducing a completely new naming scheme; I am not so convinced that we want that. Sometimes we have just kept the name of the first ported board as the base directory name, IMHO that would have been just fine here.
I really do NOT want to discuss this another time. We already discussed this a) 4 times on gerrit and b) multiple times in IRC. We agreed on 'lga1151-series'.
Sometimes we have just kept the name of the first ported board
This would be very bad because there are about 20 boards we can support in this series.
Please summarize the discussion in the commit message.
Will do
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@11 PS27, Line 11: see CR 35427
Need needed. If it is, please use the Change-Id and the commit message summary.
What is needed?
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@9 PS27, Line 9: Most of the X11 boards with socket LGA1151 are basically the same : boards with just some minor differences. : To be able to add more x11 boards easily like x11ssm (see CR 35427) : this restructures the x11ssh tree.
Please do not break the line after a sentence. […]
huh? This is one sentence, newline because of line limit
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#28).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences like differentc NICs (1 GbE, 10 GbE), number of NICs / PCIe ports etc. There are about 20 boards that can be added, if there is a community for testing.
To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree to represent a "X11 LGA1151 series". There were multiple suggestions for the structure like grouping by series (x10, x11, x...), grouping by chipset or by cpu family. It turned out that there are some "X11 series" boards that are completely different. Grouping by chipset or cpu family suffers from the same problem. This is why finally we agreed on grouping by series and socket ("X11 LGA1151 series").
The structure uses the common baseboard scheme, while there is no "real" baseboard we know of. By checking images, comparing logs etc. we came to the conclusion that Supermicro does have some base layout which is only modified a bit for the different boards.
X11SSH-TF was moved to the variants/ folder with it's gpio.h. As we expect the other boards to have mostly the same device tree, there is a common devicetree that gets overridden by each variant's overridetree.
Besides that some very minor modifications happened (formatting, fixing comments).
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/28
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 28:
Patch Set 27:
(2 comments)
Patch Set 27:
Patch Set 27:
Patch Set 26:
I admit I did not read through all the commit messages for argumentation why you want the directory renamed.
That's the problem here ;-) The discussion is going on since weeks.
Use of variants/ is welcome for sure for similar board ports. While the base directory name can be somewhat arbitrary, including the socket type 'lga1151-series' there is kind of introducing a completely new naming scheme; I am not so convinced that we want that. Sometimes we have just kept the name of the first ported board as the base directory name, IMHO that would have been just fine here.
I really do NOT want to discuss this another time. We already discussed this a) 4 times on gerrit and b) multiple times in IRC. We agreed on 'lga1151-series'.
Sometimes we have just kept the name of the first ported board
This would be very bad because there are about 20 boards we can support in this series.
Please summarize the discussion in the commit message.
Will do
done
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 28:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@11 PS27, Line 11: see CR 35427
What is needed?
Done
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@9 PS27, Line 9: Most of the X11 boards with socket LGA1151 are basically the same : boards with just some minor differences. : To be able to add more x11 boards easily like x11ssm (see CR 35427) : this restructures the x11ssh tree.
huh? This is one sentence, newline because of line limit
Done
https://review.coreboot.org/c/coreboot/+/35426/27//COMMIT_MSG@13 PS27, Line 13:
Please elaborate a little bit. You rename the directory. […]
Done
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 28: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35426/28/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/28/src/mainboard/supermicro/x... PS28, Line 19: default "Supermicro_X11_LGA1151_SERIES" I'd say we should use vendor string here, but it is "To be filled by O.E.M."
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 28:
Patch Set 27:
Patch Set 26:
I admit I did not read through all the commit messages for argumentation why you want the directory renamed.
That's the problem here ;-) The discussion is going on since weeks.
Use of variants/ is welcome for sure for similar board ports. While the base directory name can be somewhat arbitrary, including the socket type 'lga1151-series' there is kind of introducing a completely new naming scheme; I am not so convinced that we want that. Sometimes we have just kept the name of the first ported board as the base directory name, IMHO that would have been just fine here.
I really do NOT want to discuss this another time. We already discussed this a) 4 times on gerrit and b) multiple times in IRC. We agreed on 'lga1151-series'.
Sometimes we have just kept the name of the first ported board
This would be very bad because there are about 20 boards we can support in this series.
So this is already decided? Still I dont think it is a good idea. But I wont block it if you want to let it slip into the tree thats fine with me.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 29:
(3 comments)
Thank you for the update.
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG@10 PS28, Line 10: differentc different
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG@13 PS28, Line 13: 35427 It’s not marked up by Gerrit. Please use the Change-Id.
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG@9 PS28, Line 9: Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor : differences like differentc NICs (1 GbE, 10 GbE), number of NICs / PCIe ports etc. : There are about 20 boards that can be added, if there is a community for testing. : : To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the : x11ssh tree to represent a "X11 LGA1151 series". There were multiple suggestions for the : structure like grouping by series (x10, x11, x...), grouping by chipset or by cpu family. : It turned out that there are some "X11 series" boards that are completely different. : Grouping by chipset or cpu family suffers from the same problem. This is why finally we : agreed on grouping by series and socket ("X11 LGA1151 series"). : : The structure uses the common baseboard scheme, while there is no "real" baseboard we : know of. By checking images, comparing logs etc. we came to the conclusion that Supermicro : does have some base layout which is only modified a bit for the different boards. : : X11SSH-TF was moved to the variants/ folder with it's gpio.h. As we expect the other : boards to have mostly the same device tree, there is a common devicetree that gets : overridden by each variant's overridetree. : : Besides that some very minor modifications happened (formatting, fixing comments). For commit messages the text width limit is 75 characters.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 29:
I admit I did not read through all the commit messages for argumentation why you want the directory renamed.
That's the problem here ;-) The discussion is going on since weeks.
Use of variants/ is welcome for sure for similar board ports. While the base directory name can be somewhat arbitrary, including the socket type 'lga1151-series' there is kind of introducing a completely new naming scheme; I am not so convinced that we want that. Sometimes we have just kept the name of the first ported board as the base directory name, IMHO that would have been just fine here.
I really do NOT want to discuss this another time. We already discussed this a) 4 times on gerrit and b) multiple times in IRC. We agreed on 'lga1151-series'.
Sometimes we have just kept the name of the first ported board
This would be very bad because there are about 20 boards we can support in this series.
So this is already decided? Still I dont think it is a good idea. But I wont block it if you want to let it slip into the tree thats fine with me.
In any case, there is no rule for these names yet and this is the wrong forum to discuss new rules. Yes, in some cases we kept the name of the first board. But sometimes the vendor picked a different name. And we already have cases of made up schemes, e.g. librem_skl. I don't think it matters that much (hey, I can type x11<tab> and have the correct path, isn't that enough?).
If somebody wants to enforce a scheme, please discuss that on the mailing list, and be prepared to write patches to make existing ports compliant.
Aaaand, would somebody break the commit message at 72 chars, please? It's unreadable in Gerrit when not viewed full-screen. Hence, I didn't read it.
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#30).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences like differentc NICs (1 GbE, 10 GbE), number of NICs / PCIe ports etc.
There are about 20 boards that can be added, if there is a community for testing.
To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the x11ssh tree to represent a "X11 LGA1151 series". There were multiple suggestions for the structure like grouping by series (x10, x11, x...), grouping by chipset or by cpu family.
It turned out that there are some "X11 series" boards that are completely different. Grouping by chipset or cpu family suffers from the same problem. This is why finally we agreed on grouping by series and socket ("X11 LGA1151 series").
The structure uses the common baseboard scheme, while there is no "real" baseboard we know of. By checking images, comparing logs etc. we came to the conclusion that Supermicro does have some base layout which is only modified a bit for the different boards.
X11SSH-TF was moved to the variants/ folder with it's gpio.h. As we expect the other boards to have mostly the same device tree, there is a common devicetree that gets overridden by each variant's overridetree.
Besides that some very minor modifications happened (formatting, fixing comments, ...) but not much.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/30
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#31).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences like different NICs (1 GbE, 10 GbE), number of NICs / PCIe ports etc.
There are about 20 boards that can be added, if there is a community for testing.
To be able to add more x11 boards easily like x11ssm (see CB:35427) this restructures the x11ssh tree to represent a "X11 LGA1151 series". There were multiple suggestions for the structure like grouping by series (x10, x11, x...), grouping by chipset or by cpu family.
It turned out that there are some "X11 series" boards that are completely different. Grouping by chipset or cpu family suffers from the same problem. This is why finally we agreed on grouping by series and socket ("X11 LGA1151 series").
The structure uses the common baseboard scheme, while there is no "real" baseboard we know of. By checking images, comparing logs etc. we came to the conclusion that Supermicro does have some base layout which is only modified a bit for the different boards.
X11SSH-TF was moved to the variants/ folder with it's gpio.h. As we expect the other boards to have mostly the same device tree, there is a common devicetree that gets overridden by each variant's overridetree.
Besides that some very minor modifications happened (formatting, fixing comments, ...) but not much.
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/31
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 31:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG@10 PS28, Line 10: differentc
different
Done
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG@13 PS28, Line 13: 35427
It’s not marked up by Gerrit. Please use the Change-Id.
Done
https://review.coreboot.org/c/coreboot/+/35426/28//COMMIT_MSG@9 PS28, Line 9: Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor : differences like differentc NICs (1 GbE, 10 GbE), number of NICs / PCIe ports etc. : There are about 20 boards that can be added, if there is a community for testing. : : To be able to add more x11 boards easily like x11ssm (see CR 35427) this restructures the : x11ssh tree to represent a "X11 LGA1151 series". There were multiple suggestions for the : structure like grouping by series (x10, x11, x...), grouping by chipset or by cpu family. : It turned out that there are some "X11 series" boards that are completely different. : Grouping by chipset or cpu family suffers from the same problem. This is why finally we : agreed on grouping by series and socket ("X11 LGA1151 series"). : : The structure uses the common baseboard scheme, while there is no "real" baseboard we : know of. By checking images, comparing logs etc. we came to the conclusion that Supermicro : does have some base layout which is only modified a bit for the different boards. : : X11SSH-TF was moved to the variants/ folder with it's gpio.h. As we expect the other : boards to have mostly the same device tree, there is a common devicetree that gets : overridden by each variant's overridetree. : : Besides that some very minor modifications happened (formatting, fixing comments).
For commit messages the text width limit is 75 characters.
Done
https://review.coreboot.org/c/coreboot/+/35426/28/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/28/src/mainboard/supermicro/x... PS28, Line 19: default "Supermicro_X11_LGA1151_SERIES"
I'd say we should use vendor string here, but it is […]
yup, that's why I looked what other boards do and found that this is the best solution here :)
Hello Patrick Rudolph, Angel Pons, Patrick Rudolph, Christian Walter, Philipp Deppenwiese, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35426
to look at the new patch set (#32).
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences like different NICs (1 GbE, 10 GbE), number of NICs / PCIe ports etc.
There are about 20 boards that can be added, if there is a community for testing.
To be able to add more x11 boards easily like x11ssm (see CB:35427) this restructures the x11ssh tree to represent a "X11 LGA1151 series". There were multiple suggestions for the structure like grouping by series (x10, x11, x...), grouping by chipset or by cpu family.
It turned out that there are some "X11 series" boards that are completely different. Grouping by chipset or cpu family suffers from the same problem. This is why finally we agreed on grouping by series and socket ("X11 LGA1151 series").
The structure uses the common baseboard scheme, while there is no "real" baseboard we know of. By checking images, comparing logs etc. we came to the conclusion that Supermicro does have some base layout which is only modified a bit for the different boards.
X11SSH-TF was moved to the variants/ folder with it's gpio.h. As we expect the other boards to have mostly the same device tree, there is a common devicetree that gets overridden by each variant's overridetree.
Besides that some very minor modifications happened (formatting, fixing comments, ...) but not much.
Documentation is reworked in CB:35547
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/35426/32
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 32: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
mb/supermicro: restructure x11ssh-tf to represent a x11 board series
Most of the X11 boards with socket LGA1151 are basically the same boards with just some minor differences like different NICs (1 GbE, 10 GbE), number of NICs / PCIe ports etc.
There are about 20 boards that can be added, if there is a community for testing.
To be able to add more x11 boards easily like x11ssm (see CB:35427) this restructures the x11ssh tree to represent a "X11 LGA1151 series". There were multiple suggestions for the structure like grouping by series (x10, x11, x...), grouping by chipset or by cpu family.
It turned out that there are some "X11 series" boards that are completely different. Grouping by chipset or cpu family suffers from the same problem. This is why finally we agreed on grouping by series and socket ("X11 LGA1151 series").
The structure uses the common baseboard scheme, while there is no "real" baseboard we know of. By checking images, comparing logs etc. we came to the conclusion that Supermicro does have some base layout which is only modified a bit for the different boards.
X11SSH-TF was moved to the variants/ folder with it's gpio.h. As we expect the other boards to have mostly the same device tree, there is a common devicetree that gets overridden by each variant's overridetree.
Besides that some very minor modifications happened (formatting, fixing comments, ...) but not much.
Documentation is reworked in CB:35547
Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29 Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/35426 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/mainboard/index.md A Documentation/mainboard/supermicro/x11-lga1151-series/index.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md R Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg R src/mainboard/supermicro/x11-lga1151-series/Kconfig A src/mainboard/supermicro/x11-lga1151-series/Kconfig.name R src/mainboard/supermicro/x11-lga1151-series/Makefile.inc R src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl R src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl R src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c A src/mainboard/supermicro/x11-lga1151-series/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/bootblock.c R src/mainboard/supermicro/x11-lga1151-series/cmos.layout A src/mainboard/supermicro/x11-lga1151-series/devicetree.cb R src/mainboard/supermicro/x11-lga1151-series/dsdt.asl R src/mainboard/supermicro/x11-lga1151-series/ramstage.c R src/mainboard/supermicro/x11-lga1151-series/romstage.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb R src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd D src/mainboard/supermicro/x11ssh/Kconfig.name D src/mainboard/supermicro/x11ssh/board_info.txt D src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb 25 files changed, 389 insertions(+), 328 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index 2745a71..ea476eb 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -108,7 +108,7 @@ ## Supermicro
- [X10SLM+-F](supermicro/x10slm-f.md) -- [X11SSH-TF](supermicro/x11ssh-tf.md) +- [X11 LGA1151 series](supermicro/x11-lga1151-series/index.md)
## UP
diff --git a/Documentation/mainboard/supermicro/x11-lga1151-series/index.md b/Documentation/mainboard/supermicro/x11-lga1151-series/index.md new file mode 100644 index 0000000..79d2571 --- /dev/null +++ b/Documentation/mainboard/supermicro/x11-lga1151-series/index.md @@ -0,0 +1,7 @@ +# X11 LGA1151 series + +The supermicros X11 series with socket LGA1151 are mostly the same boards with some minor +differences in internal and external interfaces like available PCIe slots, 1 GbE, 10 GbE, +IPMI etc. This is why those boards are grouped as "X11 LGA1151 series". + +- [X11SSH-TF](x11ssh-tf/x11ssh-tf.md) diff --git a/Documentation/mainboard/supermicro/x11ssh-tf.md b/Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md similarity index 94% rename from Documentation/mainboard/supermicro/x11ssh-tf.md rename to Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md index 16e70d4..79e7f3e 100644 --- a/Documentation/mainboard/supermicro/x11ssh-tf.md +++ b/Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf.md @@ -15,7 +15,7 @@ For more details have a look at the [flashing tutorial].
The flash IC can be found between the two PCIe slots near the southbridge: - +
## BMC (IPMI)
@@ -68,6 +68,6 @@ [flashrom]: https://flashrom.org/Flashrom [MX25L25635F]: https://media.digikey.com/pdf/Data%20Sheets/Macronix/MX25L25635F.pdf [N25Q128A]: https://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/S... -[flashing tutorial]: ../../flash_tutorial/ext_power.md -[Intel FSP2.0]: ../../soc/intel/fsp/index.md +[flashing tutorial]: ../../../../flash_tutorial/ext_power.md +[Intel FSP2.0]: ../../../../soc/intel/fsp/index.md [Supermicro X11SSH-TF]: https://www.supermicro.com/en/products/motherboard/X11SSH-TF diff --git a/Documentation/mainboard/supermicro/x11ssh_flash.jpg b/Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg similarity index 100% rename from Documentation/mainboard/supermicro/x11ssh_flash.jpg rename to Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-tf/x11ssh-tf_flash.jpg Binary files differ diff --git a/src/mainboard/supermicro/x11ssh/Kconfig b/src/mainboard/supermicro/x11-lga1151-series/Kconfig similarity index 70% rename from src/mainboard/supermicro/x11ssh/Kconfig rename to src/mainboard/supermicro/x11-lga1151-series/Kconfig index dcf6bb9..54be4e0 100644 --- a/src/mainboard/supermicro/x11ssh/Kconfig +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig @@ -1,4 +1,4 @@ -config BOARD_SUPERMICRO_BASEBOARD_X11SSH +config BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES def_bool n select BOARD_ROMSIZE_KB_16384 select HAVE_ACPI_RESUME @@ -12,7 +12,27 @@ select GENERATE_SMBIOS_TABLES select IPMI_KCS
-if BOARD_SUPERMICRO_BASEBOARD_X11SSH +if BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES + +config MAINBOARD_FAMILY + string + default "Supermicro_X11_LGA1151_SERIES" + +config MAINBOARD_PART_NUMBER + string + default "X11SSH-TF" if BOARD_SUPERMICRO_X11SSH_TF + +config MAINBOARD_DIR + string + default "supermicro/x11-lga1151-series" + +config VARIANT_DIR + string + default "x11ssh-tf" if BOARD_SUPERMICRO_X11SSH_TF + +config OVERRIDE_DEVICETREE + string + default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"
config VBOOT select VBOOT_NO_BOARD_SUPPORT @@ -40,22 +60,6 @@ int default 18
-config MAINBOARD_DIR - string - default "supermicro/x11ssh" - -config VARIANT_DIR - string - default "tf" if BOARD_SUPERMICRO_X11SSH_TF - -config DEVICETREE - string - default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" - -config MAINBOARD_PART_NUMBER - string - default "X11SSH-TF" if BOARD_SUPERMICRO_X11SSH_TF - config MAX_CPUS int default 8 @@ -76,4 +80,4 @@ int default 512
-endif # BOARD_SUPERMICRO_BASEBOARD_X11SSH +endif # BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES diff --git a/src/mainboard/supermicro/x11-lga1151-series/Kconfig.name b/src/mainboard/supermicro/x11-lga1151-series/Kconfig.name new file mode 100644 index 0000000..ec01b13 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/Kconfig.name @@ -0,0 +1,3 @@ +config BOARD_SUPERMICRO_X11SSH_TF + bool "X11SSH-TF" + select BOARD_SUPERMICRO_BASEBOARD_X11_LGA1151_SERIES diff --git a/src/mainboard/supermicro/x11ssh/Makefile.inc b/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc similarity index 100% rename from src/mainboard/supermicro/x11ssh/Makefile.inc rename to src/mainboard/supermicro/x11-lga1151-series/Makefile.inc diff --git a/src/mainboard/supermicro/x11ssh/acpi/ec.asl b/src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl similarity index 100% rename from src/mainboard/supermicro/x11ssh/acpi/ec.asl rename to src/mainboard/supermicro/x11-lga1151-series/acpi/ec.asl diff --git a/src/mainboard/supermicro/x11ssh/acpi/mainboard.asl b/src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl similarity index 100% rename from src/mainboard/supermicro/x11ssh/acpi/mainboard.asl rename to src/mainboard/supermicro/x11-lga1151-series/acpi/mainboard.asl diff --git a/src/mainboard/supermicro/x11ssh/acpi/superio.asl b/src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl similarity index 100% rename from src/mainboard/supermicro/x11ssh/acpi/superio.asl rename to src/mainboard/supermicro/x11-lga1151-series/acpi/superio.asl diff --git a/src/mainboard/supermicro/x11ssh/acpi_tables.c b/src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c similarity index 100% rename from src/mainboard/supermicro/x11ssh/acpi_tables.c rename to src/mainboard/supermicro/x11-lga1151-series/acpi_tables.c diff --git a/src/mainboard/supermicro/x11-lga1151-series/board_info.txt b/src/mainboard/supermicro/x11-lga1151-series/board_info.txt new file mode 100644 index 0000000..2fa11c9 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/board_info.txt @@ -0,0 +1,2 @@ +Category: server +Vendor name: Supermicro diff --git a/src/mainboard/supermicro/x11ssh/bootblock.c b/src/mainboard/supermicro/x11-lga1151-series/bootblock.c similarity index 97% rename from src/mainboard/supermicro/x11ssh/bootblock.c rename to src/mainboard/supermicro/x11-lga1151-series/bootblock.c index 8bc8ab0..27653f5 100644 --- a/src/mainboard/supermicro/x11ssh/bootblock.c +++ b/src/mainboard/supermicro/x11-lga1151-series/bootblock.c @@ -15,7 +15,7 @@
#include <bootblock_common.h> #include <soc/gpio.h> -#include "gpio.h" +#include <variant/gpio.h> #include <superio/aspeed/common/aspeed.h> #include <superio/aspeed/ast2400/ast2400.h> #include <delay.h> diff --git a/src/mainboard/supermicro/x11ssh/cmos.layout b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout similarity index 100% rename from src/mainboard/supermicro/x11ssh/cmos.layout rename to src/mainboard/supermicro/x11-lga1151-series/cmos.layout diff --git a/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb new file mode 100644 index 0000000..a5ff0c5 --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/devicetree.cb @@ -0,0 +1,240 @@ +chip soc/intel/skylake + + # Enable deep Sx states + register "deep_s5_enable_ac" = "0" + register "deep_s5_enable_dc" = "0" + register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN" + + # Enable "Intel Speed Shift Technology" + register "speed_shift_enable" = "1" + + # FSP Configuration + register "SmbusEnable" = "1" + register "ScsEmmcEnabled" = "0" + register "ScsEmmcHs400Enabled" = "0" + register "ScsSdCardEnabled" = "0" + register "SkipExtGfxScan" = "1" + register "Device4Enable" = "1" + register "SaGv" = "SaGv_Disabled" + + # Disable SGX + register "sgx_enable" = "0" # SGX is broken in coreboot + register "PrmrrSize" = "128 * MiB" + + register "pirqa_routing" = "PCH_IRQ11" + register "pirqb_routing" = "PCH_IRQ10" + register "pirqc_routing" = "PCH_IRQ11" + register "pirqd_routing" = "PCH_IRQ11" + register "pirqe_routing" = "PCH_IRQ11" + register "pirqf_routing" = "PCH_IRQ11" + register "pirqg_routing" = "PCH_IRQ11" + register "pirqh_routing" = "PCH_IRQ11" + + # SATA configuration + register "SataMode" = "KBLFSP_SATA_MODE_AHCI" + register "EnableSata" = "1" + register "SataSalpSupport" = "1" + register "SataPortsEnable" = "{ \ + [0] = 1, \ + [1] = 1, \ + [2] = 1, \ + [3] = 1, \ + [4] = 1, \ + [5] = 1, \ + [6] = 1, \ + [7] = 1, \ + }" + + register "SataPortsDevSlp" = "{\ + [0] = 0, \ + [1] = 0, \ + [2] = 0, \ + [3] = 0, \ + [4] = 0, \ + [5] = 0, \ + [6] = 0, \ + [7] = 0, \ + }" + + # superspeed_inter-chip_supplement (SSIC) disabled + register "SsicPortEnable" = "0" + + # USB configuration + # USB2/3 + register "usb2_ports[0]" = "USB2_PORT_MID(OC0)" + register "usb2_ports[1]" = "USB2_PORT_MID(OC0)" + + # ? + register "usb2_ports[14]" = "USB2_PORT_MID(OC0)" + register "usb2_ports[15]" = "USB2_PORT_MID(OC0)" + + # USB4/5 + register "usb2_ports[2]" = "USB2_PORT_MID(OC1)" + register "usb2_ports[3]" = "USB2_PORT_MID(OC1)" + + # USB0/1 + register "usb2_ports[4]" = "USB2_PORT_MID(OC2)" + register "usb2_ports[5]" = "USB2_PORT_MID(OC2)" + + # USB9/10 (USB3.0) + register "usb2_ports[8]" = "USB2_PORT_MID(OC3)" + register "usb2_ports[12]" = "USB2_PORT_MID(OC3)" + register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC3)" + register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC3)" + + # USB6/7 (USB3.0) + register "usb2_ports[10]" = "USB2_PORT_MID(OC4)" + register "usb2_ports[11]" = "USB2_PORT_MID(OC4)" + register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC4)" + register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC4)" + + # USB8 (USB3.0) + register "usb2_ports[9]" = "USB2_PORT_MID(OC5)" + register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC5)" + + # IPMI USB HUB + register "usb2_ports[13]" = "USB2_PORT_MID(OC_SKIP)" + + # LPC + register "serirq_mode" = "SERIRQ_CONTINUOUS" + + # Enabling SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch + register "PmConfigSlpS3MinAssert" = "SLP_S3_MIN_ASSERT_50MS" + register "PmConfigSlpS4MinAssert" = "SLP_S4_MIN_ASSERT_4S" + register "PmConfigSlpSusMinAssert" = "SLP_SUS_MIN_ASSERT_4S" + register "PmConfigSlpAMinAssert" = "SLP_A_MIN_ASSERT_2S" + + # VR Settings Configuration for 4 Domains + # ICC_MAX = 0 (Auto) + # Voltage limit 1.52V (not used on KBL-S and KBL-DT) + # Disable PS4 powerstate in S0ix, thus no package C10 support + # psi threshold is using FSP default values + register "domain_vr_config[VR_SYSTEM_AGENT]" = "{ + .vr_config_enable = 1, \ + .psi1threshold = VR_CFG_AMP(20), + .psi2threshold = VR_CFG_AMP(5), + .psi3threshold = VR_CFG_AMP(1), + .psi3enable = 1, \ + .psi4enable = 0, \ + .imon_slope = 0x0, \ + .imon_offset = 0x0, \ + .icc_max = 0, \ + .voltage_limit = 1520 \ + }" + + register "domain_vr_config[VR_IA_CORE]" = "{ + .vr_config_enable = 1, \ + .psi1threshold = VR_CFG_AMP(20), + .psi2threshold = VR_CFG_AMP(5), + .psi3threshold = VR_CFG_AMP(1), + .psi3enable = 1, \ + .psi4enable = 0, \ + .imon_slope = 0x0, \ + .imon_offset = 0x0, \ + .icc_max = 0, \ + .voltage_limit = 1520 \ + }" + + register "domain_vr_config[VR_GT_UNSLICED]" = "{ + .vr_config_enable = 1, \ + .psi1threshold = VR_CFG_AMP(20), + .psi2threshold = VR_CFG_AMP(5), + .psi3threshold = VR_CFG_AMP(1), + .psi3enable = 1, \ + .psi4enable = 0, \ + .imon_slope = 0x0, \ + .imon_offset = 0x0, \ + .icc_max = 0 ,\ + .voltage_limit = 1520 \ + }" + + register "domain_vr_config[VR_GT_SLICED]" = "{ + .vr_config_enable = 1, \ + .psi1threshold = VR_CFG_AMP(20), + .psi2threshold = VR_CFG_AMP(5), + .psi3threshold = VR_CFG_AMP(1), + .psi3enable = 1, \ + .psi4enable = 0, \ + .imon_slope = 0x0, \ + .imon_offset = 0x0, \ + .icc_max = 0, \ + .voltage_limit = 1520 \ + }" + + # No extra VR mailbox command + register "SendVrMbxCmd" = "0" + + # Lock Down + register "common_soc_config" = "{ + .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, + }" + + device cpu_cluster 0 on + device lapic 0 on end + end + device domain 0 on + device pci 00.0 on end # Host Bridge + device pci 01.0 off end # CPU PCIe Port 10 (x16) + device pci 01.1 off end # CPU PCIe Port 11 (x8) + device pci 01.2 off end # CPU PCIe Port 12 (x4) + device pci 02.0 off end # Integrated Graphics Device (IGD) + device pci 04.0 on end # SA thermal subsystem + device pci 05.0 off end # Imaging Unit + device pci 08.0 off end # Gaussion Mixture Model (GMM) + device pci 13.0 off end # Integrated Sensor Hub + device pci 14.0 on end # USB xHCI + device pci 14.1 off end # USB xDCI (OTG) + device pci 14.2 on end # Thermal Subsystem + device pci 15.0 off end # I2C #0 + device pci 15.1 off end # I2C #1 + device pci 15.2 off end # I2C #2 + device pci 15.3 off end # I2C #3 + device pci 16.0 on end # Management Engine Interface 1 + device pci 16.1 off end # Management Engine Interface 2 + device pci 16.2 off end # Management Engine IDE-R + device pci 16.3 off end # Management Engine KT Redirection + device pci 16.4 off end # Management Engine Interface 3 + device pci 17.0 on end # SATA + device pci 19.0 off end # UART #2 + device pci 19.1 off end # I2C #5 + device pci 19.2 off end # I2C #4 + device pci 1b.0 off end # PCH PCIe Port 17 + device pci 1b.1 off end # PCH PCIe Port 18 + device pci 1b.2 off end # PCH PCIe Port 19 + device pci 1b.3 off end # PCH PCIe Port 20 + device pci 1c.0 off end # PCH PCIe Port 1 + device pci 1c.1 off end # PCH PCIe Port 2 + device pci 1c.2 off end # PCH PCIe Port 3 + device pci 1c.3 off end # PCH PCIe Port 4 + device pci 1c.4 off end # PCH PCIe Port 5 + device pci 1c.5 off end # PCH PCIe Port 6 + device pci 1c.6 off end # PCH PCIe Port 7 + device pci 1c.7 off end # PCH PCIe Port 8 + device pci 1d.0 off end # PCH PCIe Port 9 + device pci 1d.1 off end # PCH PCIe Port 10 + device pci 1d.2 off end # PCH PCIe Port 11 + device pci 1d.3 off end # PCH PCIe Port 12 + device pci 1d.4 off end # PCH PCIe Port 13 + device pci 1d.5 off end # PCH PCIe Port 14 + device pci 1d.6 off end # PCH PCIe Port 15 + device pci 1d.7 off end # PCH PCIe Port 16 + device pci 1e.0 off end # UART #0 + device pci 1e.1 off end # UART #1 + device pci 1e.2 off end # SPI #0 + device pci 1f.0 on # LPC Interface + chip superio/common + device pnp 2e.0 on end + end + chip drivers/pc80/tpm # TPM + device pnp 0c31.0 on end + end + end + device pci 1f.1 on end # P2SB + device pci 1f.2 on end # Power Management Controller + device pci 1f.3 off end # Intel HDA + device pci 1f.4 on end # SMBus + device pci 1f.5 on end # SPI Controller + device pci 1f.6 off end # GbE + device pci 1f.7 off end # Intel Trace Hub + end +end diff --git a/src/mainboard/supermicro/x11ssh/dsdt.asl b/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl similarity index 100% rename from src/mainboard/supermicro/x11ssh/dsdt.asl rename to src/mainboard/supermicro/x11-lga1151-series/dsdt.asl diff --git a/src/mainboard/supermicro/x11ssh/ramstage.c b/src/mainboard/supermicro/x11-lga1151-series/ramstage.c similarity index 96% rename from src/mainboard/supermicro/x11ssh/ramstage.c rename to src/mainboard/supermicro/x11-lga1151-series/ramstage.c index a37d2d2..694165a 100644 --- a/src/mainboard/supermicro/x11ssh/ramstage.c +++ b/src/mainboard/supermicro/x11-lga1151-series/ramstage.c @@ -13,7 +13,7 @@
#include <bootstate.h> #include <soc/ramstage.h> -#include "gpio.h" +#include <variant/gpio.h>
void mainboard_silicon_init_params(FSP_SIL_UPD *params) { diff --git a/src/mainboard/supermicro/x11ssh/romstage.c b/src/mainboard/supermicro/x11-lga1151-series/romstage.c similarity index 100% rename from src/mainboard/supermicro/x11ssh/romstage.c rename to src/mainboard/supermicro/x11-lga1151-series/romstage.c diff --git a/src/mainboard/supermicro/x11ssh/variants/tf/board_info.txt b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt similarity index 61% rename from src/mainboard/supermicro/x11ssh/variants/tf/board_info.txt rename to src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt index f3eb3ef..893ccf4 100644 --- a/src/mainboard/supermicro/x11ssh/variants/tf/board_info.txt +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/board_info.txt @@ -1,6 +1,7 @@ +Category: server Vendor name: Supermicro Board name: X11SSH-TF -Category: server +Board URL: https://www.supermicro.com/en/products/motherboard/X11SSH-TF ROM protocol: SPI ROM socketed: n Flashrom support: y diff --git a/src/mainboard/supermicro/x11ssh/gpio.h b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h similarity index 98% rename from src/mainboard/supermicro/x11ssh/gpio.h rename to src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h index 02fe90c..a5eed6b 100644 --- a/src/mainboard/supermicro/x11ssh/gpio.h +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h @@ -13,8 +13,8 @@ * GNU General Public License for more details. */
-#ifndef _GPIOX11SSHTF_H -#define _GPIOX11SSHTF_H +#ifndef _GPIO_X11SSH_TF_H +#define _GPIO_X11SSH_TF_H
#include <soc/gpe.h> #include <soc/gpio.h> @@ -245,4 +245,4 @@ };
#endif /* __ACPI__ */ -#endif /* _GPIOX11SSHTF_H */ +#endif /* _GPIO_X11SSH_TF_H */ diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb new file mode 100644 index 0000000..1039f7a --- /dev/null +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb @@ -0,0 +1,103 @@ +chip soc/intel/skylake + + # GPE configuration + # Note that GPE events called out in ASL code rely on this + # route. i.e. If this route changes then the affected GPE + # offset bits also need to be changed. + register "gpe0_dw0" = "GPP_B" + register "gpe0_dw1" = "GPP_D" + register "gpe0_dw2" = "GPP_E" + + register "gen1_dec" = "0x007c0a01" # Super IO SWC + register "gen2_dec" = "0x000c0ca1" # IPMI KCS + register "gen3_dec" = "0x000c03e1" # UART3 + register "gen4_dec" = "0x000c02e1" # UART4 + + # PCIe configuration + # Enable JPCIE1 + register "PcieRpEnable[0]" = "1" + register "PcieRpClkReqSupport[0]" = "0" + + # Enable ASpeed PCI bridge + register "PcieRpEnable[2]" = "1" + register "PcieRpClkReqSupport[2]" = "0" + + # Enable X550T (10GbE) + register "PcieRpEnable[4]" = "1" + register "PcieRpClkReqSupport[4]" = "0" + + # Enable M.2 + register "PcieRpEnable[8]" = "1" + register "PcieRpClkReqSupport[8]" = "0" + + device domain 0 on + device pci 01.0 on end # unused + device pci 01.1 on # PCIE Slot (JPCIE1) + smbios_slot_desc "SlotTypePciExpressGen3X8" "SlotLengthShort" "CPU SLOT6 PCI-E 3.0 X8" "SlotDataBusWidth4X" + end + device pci 1c.0 on # PCI Express Port 1 (Slot JPCIE1) + smbios_slot_desc "SlotTypePciExpressGen3X4" "SlotLengthLong" "PCH SLOT4 PCI-E 3.0 X2(IN X4)" "SlotDataBusWidth2X" + end + device pci 1c.2 on # PCI Express Port 3 + device pci 00.0 on # Aspeed PCI Bridge + device pci 00.0 on end # Aspeed 2400 VGA + end + end + device pci 1c.4 on # PCI Express Port 5 + device pci 00.0 on end # 10GbE + device pci 00.1 on end # 10GbE + end + device pci 1d.0 on # PCI Express Port 9 + smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2 2280" "SlotDataBusWidth4X" + end + device pci 1f.0 on # LPC Interface + chip drivers/ipmi + # On cold boot it takes a while for the BMC to start the IPMI service + register "wait_for_bmc" = "1" + register "bmc_boot_timeout" = "60" + device pnp ca2.0 on end # IPMI KCS + end + chip superio/common + device pnp 2e.0 on + chip superio/aspeed/ast2400 + device pnp 2e.2 on # SUART1 + io 0x60 = 0x3f8 + irq 0x70 = 4 + end + device pnp 2e.3 on # SUART2 + io 0x60 = 0x2f8 + irq 0x70 = 3 + end + device pnp 2e.4 on # SWC + io 0x60 = 0xa00 + io 0x62 = 0xa10 + io 0x64 = 0xa20 + io 0x66 = 0xa30 + irq 0x70 = 0xb + end + device pnp 2e.5 on # Keyboard + io 0x60 = 0x60 + io 0x62 = 0x64 + irq 0x70 = 1 + irq 0x72 = 0xc + end + device pnp 2e.7 on end # GPIO + device pnp 2e.b on # SUART3 + io 0x60 = 0x3e8 + irq 0x70 = 4 + end + device pnp 2e.c on # SUART4 + io 0x60 = 0x2e8 + irq 0x70 = 3 + end + device pnp 2e.d on end # iLPC2AHB + device pnp 2e.e on # Mailbox + io 0x60 = 0xa40 + irq 0x70 = 0x00 + end + end + end + end + end + end +end diff --git a/src/mainboard/supermicro/x11ssh/vboot-ro-rwab.fmd b/src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd similarity index 100% rename from src/mainboard/supermicro/x11ssh/vboot-ro-rwab.fmd rename to src/mainboard/supermicro/x11-lga1151-series/vboot-ro-rwab.fmd diff --git a/src/mainboard/supermicro/x11ssh/Kconfig.name b/src/mainboard/supermicro/x11ssh/Kconfig.name deleted file mode 100644 index 43d0517..0000000 --- a/src/mainboard/supermicro/x11ssh/Kconfig.name +++ /dev/null @@ -1,3 +0,0 @@ -config BOARD_SUPERMICRO_X11SSH_TF - bool "X11SSH-TF" - select BOARD_SUPERMICRO_BASEBOARD_X11SSH diff --git a/src/mainboard/supermicro/x11ssh/board_info.txt b/src/mainboard/supermicro/x11ssh/board_info.txt deleted file mode 100644 index 029d2a9..0000000 --- a/src/mainboard/supermicro/x11ssh/board_info.txt +++ /dev/null @@ -1,6 +0,0 @@ -Vendor name: Supermicro -Board name: X11SSH Baseboard -Category: server -ROM protocol: SPI -ROM socketed: n -Flashrom support: y diff --git a/src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb b/src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb deleted file mode 100644 index ce6bfa5..0000000 --- a/src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb +++ /dev/null @@ -1,290 +0,0 @@ -chip soc/intel/skylake - - # Enable deep Sx states - register "deep_s5_enable_ac" = "0" - register "deep_s5_enable_dc" = "0" - register "deep_sx_config" = "DSX_EN_LAN_WAKE_PIN" - - # GPE configuration - # Note that GPE events called out in ASL code rely on this - # route. i.e. If this route changes then the affected GPE - # offset bits also need to be changed. - register "gpe0_dw0" = "GPP_B" - register "gpe0_dw1" = "GPP_D" - register "gpe0_dw2" = "GPP_E" - - register "gen1_dec" = "0x007c0a01" # Super IO SWC - register "gen2_dec" = "0x000c0ca1" # IPMI KCS - register "gen3_dec" = "0x000c03e1" # UART3 - register "gen4_dec" = "0x000c02e1" # UART4 - - # Enable "Intel Speed Shift Technology" - register "speed_shift_enable" = "1" - - # FSP Configuration - register "SmbusEnable" = "1" - register "ScsEmmcEnabled" = "0" - register "ScsEmmcHs400Enabled" = "0" - register "ScsSdCardEnabled" = "0" - register "SkipExtGfxScan" = "1" - register "Device4Enable" = "1" - register "SaGv" = "SaGv_Disabled" - - # Disable SGX - register "sgx_enable" = "0" # SGX is broken in coreboot - register "PrmrrSize" = "128 * MiB" - - register "pirqa_routing" = "PCH_IRQ11" - register "pirqb_routing" = "PCH_IRQ10" - register "pirqc_routing" = "PCH_IRQ11" - register "pirqd_routing" = "PCH_IRQ11" - register "pirqe_routing" = "PCH_IRQ11" - register "pirqf_routing" = "PCH_IRQ11" - register "pirqg_routing" = "PCH_IRQ11" - register "pirqh_routing" = "PCH_IRQ11" - - # SATA configuration - register "SataMode" = "0" # AHCI - register "EnableSata" = "1" - register "SataSalpSupport" = "1" - register "SataPortsEnable" = "{ \ - [0] = 1, \ - [1] = 1, \ - [2] = 1, \ - [3] = 1, \ - [4] = 1, \ - [5] = 1, \ - [6] = 1, \ - [7] = 1, \ - }" - - register "SataPortsDevSlp" = "{\ - [0] = 0, \ - [1] = 0, \ - [2] = 0, \ - [3] = 0, \ - [4] = 0, \ - [5] = 0, \ - [6] = 0, \ - [7] = 0, \ - }" - - # superspeed_inter-chip_supplement (SSIC) disabled - register "SsicPortEnable" = "0" - - # USB configuration - register "usb2_ports[0]" = "USB2_PORT_MID(OC0)" # USB2/3 - register "usb2_ports[1]" = "USB2_PORT_MID(OC0)" # USB2/3 - register "usb2_ports[14]" = "USB2_PORT_MID(OC0)" # ? - register "usb2_ports[15]" = "USB2_PORT_MID(OC0)" # ? - - register "usb2_ports[2]" = "USB2_PORT_MID(OC1)" # USB4/5 - register "usb2_ports[3]" = "USB2_PORT_MID(OC1)" # USB4/5 - - register "usb2_ports[4]" = "USB2_PORT_MID(OC2)" # USB0/1 - register "usb2_ports[5]" = "USB2_PORT_MID(OC2)" # USB0/1 - - register "usb2_ports[8]" = "USB2_PORT_MID(OC3)" # USB9/10 (USB3.0) - register "usb2_ports[12]" = "USB2_PORT_MID(OC3)" # USB9/10 (USB3.0) - register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC3)" - register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC3)" - - register "usb2_ports[10]" = "USB2_PORT_MID(OC4)" # USB6/7 (USB3.0) - register "usb2_ports[11]" = "USB2_PORT_MID(OC4)" # USB6/7 (USB3.0) - register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC4)" - register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC4)" - - register "usb2_ports[9]" = "USB2_PORT_MID(OC5)" # USB8 (USB3.0) - register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC5)" - - register "usb2_ports[13]" = "USB2_PORT_MID(OC_SKIP)" # IPMI USB HUB - - # LPC - register "serirq_mode" = "SERIRQ_CONTINUOUS" - - # PCIe configuration - # Enable JPCIE1 - register "PcieRpEnable[0]" = "1" - register "PcieRpClkReqSupport[0]" = "0" - - # Enable ASpeed PCI bridge - register "PcieRpEnable[2]" = "1" - register "PcieRpClkReqSupport[2]" = "0" - - # Enable X550T (10GbE) - register "PcieRpEnable[4]" = "1" - register "PcieRpClkReqSupport[4]" = "0" - - # Enable M.2 - register "PcieRpEnable[8]" = "1" - register "PcieRpClkReqSupport[8]" = "0" - - # Enabling SLP_S3#, SLP_S4#, SLP_SUS and SLP_A Stretch - # SLP_S3 Minimum Assertion Width. Values 0: 60us, 1: 1ms, 2: 50ms, 3: 2s - register "PmConfigSlpS3MinAssert" = "0x02" - - # SLP_S4 Minimum Assertion Width. Values 0: default, 1: 1s, 2: 2s, 3: 3s, 4: 4s - register "PmConfigSlpS4MinAssert" = "0x04" - - # SLP_SUS Minimum Assertion Width. Values 0: 0ms, 1: 500ms, 2: 1s, 3: 4s - register "PmConfigSlpSusMinAssert" = "0x03" - - # SLP_A Minimum Assertion Width. Values 0: 0ms, 1: 4s, 2: 98ms, 3: 2s - register "PmConfigSlpAMinAssert" = "0x03" - - # VR Settings Configuration for 4 Domains - # ICC_MAX = 0 (Auto) - # Voltage limit 1.52V (not used on KBL-S and KBL-DT) - # Disable PS4 powerstate in S0ix, thus no package C10 support - # psi threshold is using FSP default values - register "domain_vr_config[VR_SYSTEM_AGENT]" = "{ - .vr_config_enable = 1, \ - .psi1threshold = VR_CFG_AMP(20), - .psi2threshold = VR_CFG_AMP(5), - .psi3threshold = VR_CFG_AMP(1), - .psi3enable = 1, \ - .psi4enable = 0, \ - .imon_slope = 0x0, \ - .imon_offset = 0x0, \ - .icc_max = 0, \ - .voltage_limit = 1520 \ - }" - - register "domain_vr_config[VR_IA_CORE]" = "{ - .vr_config_enable = 1, \ - .psi1threshold = VR_CFG_AMP(20), - .psi2threshold = VR_CFG_AMP(5), - .psi3threshold = VR_CFG_AMP(1), - .psi3enable = 1, \ - .psi4enable = 0, \ - .imon_slope = 0x0, \ - .imon_offset = 0x0, \ - .icc_max = 0, \ - .voltage_limit = 1520 \ - }" - - register "domain_vr_config[VR_GT_UNSLICED]" = "{ - .vr_config_enable = 1, \ - .psi1threshold = VR_CFG_AMP(20), - .psi2threshold = VR_CFG_AMP(5), - .psi3threshold = VR_CFG_AMP(1), - .psi3enable = 1, \ - .psi4enable = 0, \ - .imon_slope = 0x0, \ - .imon_offset = 0x0, \ - .icc_max = 0 ,\ - .voltage_limit = 1520 \ - }" - - register "domain_vr_config[VR_GT_SLICED]" = "{ - .vr_config_enable = 1, \ - .psi1threshold = VR_CFG_AMP(20), - .psi2threshold = VR_CFG_AMP(5), - .psi3threshold = VR_CFG_AMP(1), - .psi3enable = 1, \ - .psi4enable = 0, \ - .imon_slope = 0x0, \ - .imon_offset = 0x0, \ - .icc_max = 0, \ - .voltage_limit = 1520 \ - }" - - # No extra VR mailbox command - register "SendVrMbxCmd" = "0" - - # Lock Down - register "common_soc_config" = "{ - .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, - }" - - device cpu_cluster 0 on - device lapic 0 on end - end - device domain 0 on - device pci 00.0 on end # Host Bridge - device pci 01.0 on end # unused - device pci 01.1 on - smbios_slot_desc "SlotTypePciExpressGen3X8" "SlotLengthShort" "CPU SLOT6 PCI-E 3.0 X8" "SlotDataBusWidth4X" - end # PCIE Slot (JPCIE1) - device pci 04.0 on end # SA thermal subsystem - device pci 14.0 on end # USB xHCI - device pci 14.1 off end # USB xDCI (OTG) - device pci 14.2 on end # Thermal Subsystem - device pci 16.0 on end # Management Engine Interface 1 - device pci 16.1 on end # Management Engine Interface 2 - device pci 17.0 on end # SATA - device pci 1c.0 on - smbios_slot_desc "SlotTypePciExpressGen3X4" "SlotLengthLong" "PCH SLOT4 PCI-E 3.0 X2(IN X4)" "SlotDataBusWidth2X" - end # PCI Express Port 1 (Slot JPCIE1) - device pci 1c.2 on - device pci 00.0 on - device pci 00.0 on end # Aspeed 2400 VGA - end - end # PCI Express Port 3 - device pci 1c.4 on - device pci 00.0 on end # 10GbE - device pci 00.1 on end # 10GbE - end # PCI Express Port 5 - device pci 1d.0 on - smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" "M.2 2280" "SlotDataBusWidth4X" - end # PCI Express Port 9 - device pci 1f.0 on - chip drivers/ipmi - # On cold boot it takes a while for the BMC to start the IPMI service - register "wait_for_bmc" = "1" - register "bmc_boot_timeout" = "60" - device pnp ca2.0 on end # IPMI KCS - end - chip superio/common - device pnp 2e.0 on - chip superio/aspeed/ast2400 - device pnp 2e.2 on # SUART1 - io 0x60 = 0x3f8 - irq 0x70 = 4 - end - device pnp 2e.3 on # SUART2 - io 0x60 = 0x2f8 - irq 0x70 = 3 - end - device pnp 2e.4 on # SWC - io 0x60 = 0xa00 - io 0x62 = 0xa10 - io 0x64 = 0xa20 - io 0x66 = 0xa30 - irq 0x70 = 0xb - end - device pnp 2e.5 on # Keyboard - io 0x60 = 0x60 - io 0x62 = 0x64 - irq 0x70 = 1 - irq 0x72 = 0xc - end - device pnp 2e.7 on # GPIO - end - device pnp 2e.b on # SUART3 - io 0x60 = 0x3e8 - irq 0x70 = 4 - end - device pnp 2e.c on # SUART4 - io 0x60 = 0x2e8 - irq 0x70 = 3 - end - device pnp 2e.d on # iLPC2AHB - end - device pnp 2e.e on # Mailbox - io 0x60 = 0xa40 - irq 0x70 = 0x00 - end - end - end - end - chip drivers/pc80/tpm - device pnp 0c31.0 on end - end - end # LPC Interface - device pci 1f.1 on end # P2SB - device pci 1f.2 on end # Power Management Controller - device pci 1f.4 on end # SMBus - device pci 1f.5 on end # SPI Controller - end -end
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: restructure x11ssh-tf to represent a x11 board series ......................................................................
Patch Set 33: Code-Review+1
(1 comment)
Let’s get this in.
https://review.coreboot.org/c/coreboot/+/35426/32//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35426/32//COMMIT_MSG@31 PS32, Line 31: it's its
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
Kyösti Mälkki (Code Review)
-
Michael Niewöhner (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)