Change in coreboot[master]: amdblocks/biosram: Do small reformatting

[Marshall Dawson (Code Review)]

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

amdblocks/biosram: Do small reformatting

Remove two blank lines.  Reorder functions by read/write sizes.

Change-Id: I7bd6ed44546d49b65135a98e424a5669d90f2867
Signed-off-by: Marshall Dawson 
---
M src/soc/amd/common/block/acpimmio/biosram.c
1 file changed, 6 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/38146/1

diff --git a/src/soc/amd/common/block/acpimmio/biosram.c b/src/soc/amd/common/block/acpimmio/biosram.c
index 814fdf3..1b1fcad 100644
--- a/src/soc/amd/common/block/acpimmio/biosram.c
+++ b/src/soc/amd/common/block/acpimmio/biosram.c
@@ -38,12 +38,6 @@
    return (biosram_read8(reg + sizeof(uint8_t)) << 8 | biosram_read8(reg));
 }

-static uint32_t biosram_read32(uint8_t reg)
-{
-	uint32_t value = biosram_read16(reg + sizeof(uint16_t)) << 16;
-	return value | biosram_read16(reg);
-}
-
 static void biosram_write16(uint8_t reg, uint16_t value)
 {
    biosram_write8(reg, value & 0xff);
@@ -51,6 +45,12 @@
    biosram_write8(reg + sizeof(uint8_t), value & 0xff);
 }

+static uint32_t biosram_read32(uint8_t reg)
+{
+	uint32_t value = biosram_read16(reg + sizeof(uint16_t)) << 16;
+	return value | biosram_read16(reg);
+}
+
 static void biosram_write32(uint8_t reg, uint32_t value)
 {
    biosram_write16(reg, value & 0xffff);
@@ -58,7 +58,6 @@
    biosram_write16(reg + sizeof(uint16_t), value & 0xffff);
 }

-
 /* Access to BIOSRAM is only allowed through the abstractions below. */

void *get_ap_entry_ptr(void)
@@ -71,7 +70,6 @@
    biosram_write32(BIOSRAM_AP_ENTRY, (uintptr_t)entry);
 }

-
 void backup_top_of_low_cacheable(uintptr_t ramtop)
 {
    biosram_write32(BIOSRAM_CBMEM_TOP, ramtop);

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

Patch Set 1: Code-Review+2

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

Patch Set 1: Code-Review+2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38146/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38146/1//COMMIT_MSG@9 
PS1, Line 9: Remove two blank lines.  Reorder functions by read/write sizes.
Remove double SPACE before Reorder or place 'Reorder ..' at new line

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded a new patch set (#2) to the change originally created by Marshall Dawson. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

amdblocks/biosram: Do small reformatting

Remove two blank lines.
Reorder functions by read/write sizes.

Change-Id: I7bd6ed44546d49b65135a98e424a5669d90f2867
Signed-off-by: Marshall Dawson 
---
M src/soc/amd/common/block/acpimmio/biosram.c
1 file changed, 6 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/38146/2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38146/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38146/1//COMMIT_MSG@9 
PS1, Line 9: Remove two blank lines.  Reorder functions by read/write sizes.
> Remove double SPACE before Reorder or place 'Reorder .. […]

Done

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38146/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38146/2//COMMIT_MSG@8 
PS2, Line 8: 
           : Remove two blank lines.
           : Reorder functions by read/write sizes.
Make it a list or enumeration.

[Michał Żygowski (Code Review)]

Michał Żygowski has uploaded a new patch set (#3) to the change originally created by Marshall Dawson. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

amdblocks/biosram: Do small reformatting

Remove two blank lines and reorder functions by read/write sizes.

Change-Id: I7bd6ed44546d49b65135a98e424a5669d90f2867
Signed-off-by: Marshall Dawson 
---
M src/soc/amd/common/block/acpimmio/biosram.c
1 file changed, 6 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/38146/3

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38146/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38146/2//COMMIT_MSG@8 
PS2, Line 8: 
           : Remove two blank lines.
           : Reorder functions by read/write sizes.
> Make it a list or enumeration.

Done

[Michał Żygowski (Code Review)]

Michał Żygowski has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

amdblocks/biosram: Do small reformatting

Remove two blank lines and reorder functions by read/write sizes.

Change-Id: I7bd6ed44546d49b65135a98e424a5669d90f2867
Signed-off-by: Marshall Dawson 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38146
Reviewed-by: Paul Menzel 
Reviewed-by: Kyösti Mälkki 
Reviewed-by: Michał Żygowski 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/common/block/acpimmio/biosram.c
1 file changed, 6 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Michał Żygowski: Looks good to me, approved

diff --git a/src/soc/amd/common/block/acpimmio/biosram.c b/src/soc/amd/common/block/acpimmio/biosram.c
index 814fdf3..1b1fcad 100644
--- a/src/soc/amd/common/block/acpimmio/biosram.c
+++ b/src/soc/amd/common/block/acpimmio/biosram.c
@@ -38,12 +38,6 @@
    return (biosram_read8(reg + sizeof(uint8_t)) << 8 | biosram_read8(reg));
 }

-static uint32_t biosram_read32(uint8_t reg)
-{
-	uint32_t value = biosram_read16(reg + sizeof(uint16_t)) << 16;
-	return value | biosram_read16(reg);
-}
-
 static void biosram_write16(uint8_t reg, uint16_t value)
 {
    biosram_write8(reg, value & 0xff);
@@ -51,6 +45,12 @@
    biosram_write8(reg + sizeof(uint8_t), value & 0xff);
 }

+static uint32_t biosram_read32(uint8_t reg)
+{
+	uint32_t value = biosram_read16(reg + sizeof(uint16_t)) << 16;
+	return value | biosram_read16(reg);
+}
+
 static void biosram_write32(uint8_t reg, uint32_t value)
 {
    biosram_write16(reg, value & 0xffff);
@@ -58,7 +58,6 @@
    biosram_write16(reg + sizeof(uint16_t), value & 0xffff);
 }

-
 /* Access to BIOSRAM is only allowed through the abstractions below. */

void *get_ap_entry_ptr(void)
@@ -71,7 +70,6 @@
    biosram_write32(BIOSRAM_AP_ENTRY, (uintptr_t)entry);
 }

-
 void backup_top_of_low_cacheable(uintptr_t ramtop)
 {
    biosram_write32(BIOSRAM_CBMEM_TOP, ramtop);

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/331
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/330
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/329

Please note: This test is under development and might not be accurate at all!

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38146 )

Change subject: amdblocks/biosram: Do small reformatting
......................................................................

Patch Set 4: Code-Review+2