Marty E. Plummer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33486
Change subject: arm64: make comment match code ......................................................................
arm64: make comment match code
Change-Id: I37b8d5715cb6a32d4853e77098094cd5cffb9a4c Signed-off-by: Marty E. Plummer hanetzer@startmail.com --- M src/arch/arm64/armv8/bootblock.S 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/33486/1
diff --git a/src/arch/arm64/armv8/bootblock.S b/src/arch/arm64/armv8/bootblock.S index e5758bc..3950f55 100644 --- a/src/arch/arm64/armv8/bootblock.S +++ b/src/arch/arm64/armv8/bootblock.S @@ -19,7 +19,7 @@ /* NOTE: When making changes to general ARM64 initialization, keep in mind that * there are other CPU entry points, using BOOTBLOCK_CUSTOM or entering the CPU * in a later stage (like Tegra). Changes should generally be put into - * arm64_cpu_init so they can be shared between those instances. */ + * arm64_init_cpu so they can be shared between those instances. */
ENTRY(_start) /* Initialize PSTATE, SCTLR and caches to clean state, set up stack. */
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33486 )
Change subject: arm64: make comment match code ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33486 )
Change subject: arm64: make comment match code ......................................................................
Patch Set 1: Code-Review+2
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33486 )
Change subject: arm64: make comment match code ......................................................................
Patch Set 1: Code-Review+2
Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33486 )
Change subject: arm64: make comment match code ......................................................................
arm64: make comment match code
Change-Id: I37b8d5715cb6a32d4853e77098094cd5cffb9a4c Signed-off-by: Marty E. Plummer hanetzer@startmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33486 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Julius Werner jwerner@chromium.org --- M src/arch/arm64/armv8/bootblock.S 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Julius Werner: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/arch/arm64/armv8/bootblock.S b/src/arch/arm64/armv8/bootblock.S index e5758bc..3950f55 100644 --- a/src/arch/arm64/armv8/bootblock.S +++ b/src/arch/arm64/armv8/bootblock.S @@ -19,7 +19,7 @@ /* NOTE: When making changes to general ARM64 initialization, keep in mind that * there are other CPU entry points, using BOOTBLOCK_CUSTOM or entering the CPU * in a later stage (like Tegra). Changes should generally be put into - * arm64_cpu_init so they can be shared between those instances. */ + * arm64_init_cpu so they can be shared between those instances. */
ENTRY(_start) /* Initialize PSTATE, SCTLR and caches to clean state, set up stack. */
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Julius Werner (Code Review)
-
Marty E. Plummer (Code Review)