[S] Change in coreboot[master]: mb/google/geralt: Pass reset gpio parameter to BL31 - coreboot-gerrit

6 Sep 2022


      Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67357 )
Change subject: mb/google/geralt: Pass reset gpio parameter to BL31
......................................................................
Patch Set 5: -Code-Review
(1 comment)
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/67357/comment/635d2f93_9c91a438 
PS4, Line 3: #include <boot/coreboot_tables.h>
...
yes, it's for ACTIVE_HIGH.
Since this is unrelated to coreboot tables, we should avoid using ACTIVE_HIGH. See the other comment of mine.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/67357
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdfbd6bd82f64b084f6349cb617443053c89a3f1
Gerrit-Change-Number: 67357
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 07:39:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Rex-BC Chen rex-bc.chen@mediatek.com
Comment-In-Reply-To: Yidi Lin yidilin@google.com
Gerrit-MessageType: comment