Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79052?usp=email )
Change subject: mb/intel/mtlrvp: Create mtlrvp4es_p_ext_ec variant ......................................................................
mb/intel/mtlrvp: Create mtlrvp4es_p_ext_ec variant
This patch creates a new variant mtlrvp4es_p_ext_ec. The new variant will support ESx samples. The existing mtlrvp_p_ext_ec variant will support the QS samples.
BUG=b:310775573 TEST= Build and boot mtlrvp4es_p_ext_ec.
Signed-off-by: Usha P usha.p@intel.com Change-Id: Iad72c0f6343af149d16d8b1f8639ba496f6aab0c Reviewed-on: https://review.coreboot.org/c/coreboot/+/79052 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Kapil Porwal kapilporwal@google.com --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/Kconfig.name 2 files changed, 10 insertions(+), 4 deletions(-)
Approvals: Kapil Porwal: Looks good to me, approved Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index f225aa5..26faf91 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -26,6 +26,9 @@
config BOARD_INTEL_MTLRVP_P_EXT_EC select BOARD_EXT_EC_SPECIFIC_OPTIONS + +config BOARD_INTEL_MTLRVP4ES_P_EXT_EC + select BOARD_EXT_EC_SPECIFIC_OPTIONS select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON
config BOARD_INTEL_MTLRVP_P_MCHP @@ -61,7 +64,7 @@
config BASEBOARD_DIR string - default "mtlrvp_p" if BOARD_INTEL_MTLRVP_P || BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP + default "mtlrvp_p" if BOARD_INTEL_MTLRVP_P || BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP || BOARD_INTEL_MTLRVP4ES_P_EXT_EC
config GBB_HWID string @@ -83,7 +86,7 @@ config VARIANT_DIR string default "mtlrvp_p" if BOARD_INTEL_MTLRVP_P - default "mtlrvp_p_ext_ec" if BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP + default "mtlrvp_p_ext_ec" if BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP || BOARD_INTEL_MTLRVP4ES_P_EXT_EC
config DEVICETREE string @@ -99,7 +102,7 @@ choice prompt "ON BOARD EC" default MTL_INTEL_EC if BOARD_INTEL_MTLRVP_P - default MTL_CHROME_EC if BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP + default MTL_CHROME_EC if BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP || BOARD_INTEL_MTLRVP4ES_P_EXT_EC help This option allows you to select the on board EC to use. Select whether the board has Intel EC or/and Chrome EC diff --git a/src/mainboard/intel/mtlrvp/Kconfig.name b/src/mainboard/intel/mtlrvp/Kconfig.name index 9f61aff..696e6e6 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig.name +++ b/src/mainboard/intel/mtlrvp/Kconfig.name @@ -2,7 +2,10 @@ bool "Meteorlake-P RVP"
config BOARD_INTEL_MTLRVP_P_EXT_EC - bool "Meteorlake-P RVP with Chrome EC" + bool "Meteorlake-P RVP with Chrome EC for Prod Silicon" + +config BOARD_INTEL_MTLRVP4ES_P_EXT_EC + bool "Meteorlake-P RVP with Chrome EC for non-Prod Silicon"
config BOARD_INTEL_MTLRVP_P_MCHP bool "Meteorlake-P RVP with Microchip EC"
-
Subrata Banik (Code Review)