Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Nick Vaccaro, Andrey Petrov, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60441 )
Change subject: soc/intel/alderlake: Add option to make MRC log silent
......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60441/comment/18b5f0ed_9aba746d
PS3, Line 9: is default set to
defaults to
Ack
https://review.coreboot.org/c/coreboot/+/60441/comment/ba95595c_5fc704a3
PS3, Line 10: Messages
messages
Ack
https://review.coreboot.org/c/coreboot/+/60441/comment/0fe539f5_6e3363e2
PS3, Line 14: implemented `fsp_map_console_log_level()` that maps coreboot console
implement
Ack
https://review.coreboot.org/c/coreboot/+/60441/comment/998d63e5_63630567
PS3, Line 16: HAVE_DEBUG_RAM_SETUP
Actually, this commit should select HAVE_DEBUG_RAM_SETUP and then […]
Yes, I will fix it and submit a CL that default selects HAVE_DEBUG_RAM_SETUP (similar I saw on MTK project) and if SoC want to select debug binary then they do select DEBUG_RAM_SETUP.
WDYT about that?
Patchset:
PS2:
Yes, very nice, thank you. And good call to move the mapping function to common […]
👍 Thanks for the suggestion at the first place.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60441
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea3b32feca0893a83fdf700798b0883d26ccc718
Gerrit-Change-Number: 60441
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 30 Dec 2021 17:25:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment