Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Shuo Liu, Tim Chu.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81099?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/xeon_sp: Create CXL domains
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/xeon_sp/chip_common.c:
https://review.coreboot.org/c/coreboot/+/81099/comment/50140f13_6501a83f :
PS4, Line 274: BusBase
Done
This is still not clear to me. Please be specific and use "host bridge" and "PCI bridge" instead of just bridge.
From what I understand the PCI host bridge only has RCiEP, thus there are no PCI bridges on that host bridge and thus only 1 bus.
From what I understand all CXL 1.0/1.1 devices are also RCiEP. In that case there would be also 1 bus on the CXL domain.
By using BusLimit on the CXL domain you could have more buses. Is that for CXL2.0 devices, which could appear as PCI bridges?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81099?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I643bcfbae7b6e8cfe11c147cc89374bc6b4d5a80
Gerrit-Change-Number: 81099
Gerrit-PatchSet: 8
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 08 Mar 2024 09:20:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment