Change in coreboot[master]: mb/google/brya: Add firmware configuration probing for audio - coreboot-gerrit

1 Jun 2021


      Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Paul Menzel, Sathya Prakash M R, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54716 )
Change subject: mb/google/brya: Add firmware configuration probing for audio
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/brya/variants/brya0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/54716/comment/2fc188c6_92b54f85 
PS7, Line 82: BS_PRE_DEVICE
Is there a reason you moved this to PRE_DEVICE ? Volteer used BS_DEV_ENABLE, and I don't see why that needs to change?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/54716
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f159442516830f9d304d78c83f070e4fcff4a37
Gerrit-Change-Number: 54716
Gerrit-PatchSet: 7
Gerrit-Owner: Sugnan Prabhu S sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Sathya Prakash M R sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Sugnan Prabhu S sugnan.prabhu.s@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Sathya Prakash M R sathya.prakash.m.r@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 01 Jun 2021 15:31:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment