Hello Maccraft123,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40319
to review the following change.
Change subject: mb/qemu-i440fx,q35: Fix option table ......................................................................
mb/qemu-i440fx,q35: Fix option table
Reserve bytes 50 and 55 as they are handled as century bytes by QEMU.
Change-Id: I9271253bce560d4ec8a51a24c45473acec469187 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/mainboard/emulation/qemu-i440fx/cmos.layout M src/mainboard/emulation/qemu-q35/cmos.layout 2 files changed, 16 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/40319/1
diff --git a/src/mainboard/emulation/qemu-i440fx/cmos.layout b/src/mainboard/emulation/qemu-i440fx/cmos.layout index 247a6a0..9019afb 100644 --- a/src/mainboard/emulation/qemu-i440fx/cmos.layout +++ b/src/mainboard/emulation/qemu-i440fx/cmos.layout @@ -1,11 +1,15 @@ entries
0 384 r 0 reserved_memory + 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#392 3 r 0 unused -400 1 e 1 power_on_after_fail -412 4 e 6 debug_level + +400 8 r 0 reserved_century +440 8 r 0 reserved_ibm_ps2_century + +448 1 e 1 power_on_after_fail +452 4 e 6 debug_level 456 1 e 1 ECC_memory
# VBOOT @@ -29,4 +33,4 @@
checksums
-checksum 392 463 1008 +checksum 448 463 1008 diff --git a/src/mainboard/emulation/qemu-q35/cmos.layout b/src/mainboard/emulation/qemu-q35/cmos.layout index 247a6a0..9019afb 100644 --- a/src/mainboard/emulation/qemu-q35/cmos.layout +++ b/src/mainboard/emulation/qemu-q35/cmos.layout @@ -1,11 +1,15 @@ entries
0 384 r 0 reserved_memory + 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#392 3 r 0 unused -400 1 e 1 power_on_after_fail -412 4 e 6 debug_level + +400 8 r 0 reserved_century +440 8 r 0 reserved_ibm_ps2_century + +448 1 e 1 power_on_after_fail +452 4 e 6 debug_level 456 1 e 1 ECC_memory
# VBOOT @@ -29,4 +33,4 @@
checksums
-checksum 392 463 1008 +checksum 448 463 1008
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40319 )
Change subject: mb/qemu-i440fx,q35: Fix option table ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40319 )
Change subject: mb/qemu-i440fx,q35: Fix option table ......................................................................
mb/qemu-i440fx,q35: Fix option table
Reserve bytes 50 and 55 as they are handled as century bytes by QEMU.
Change-Id: I9271253bce560d4ec8a51a24c45473acec469187 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/40319 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/emulation/qemu-i440fx/cmos.layout M src/mainboard/emulation/qemu-q35/cmos.layout 2 files changed, 16 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/emulation/qemu-i440fx/cmos.layout b/src/mainboard/emulation/qemu-i440fx/cmos.layout index 247a6a0..9019afb 100644 --- a/src/mainboard/emulation/qemu-i440fx/cmos.layout +++ b/src/mainboard/emulation/qemu-i440fx/cmos.layout @@ -1,11 +1,15 @@ entries
0 384 r 0 reserved_memory + 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#392 3 r 0 unused -400 1 e 1 power_on_after_fail -412 4 e 6 debug_level + +400 8 r 0 reserved_century +440 8 r 0 reserved_ibm_ps2_century + +448 1 e 1 power_on_after_fail +452 4 e 6 debug_level 456 1 e 1 ECC_memory
# VBOOT @@ -29,4 +33,4 @@
checksums
-checksum 392 463 1008 +checksum 448 463 1008 diff --git a/src/mainboard/emulation/qemu-q35/cmos.layout b/src/mainboard/emulation/qemu-q35/cmos.layout index 247a6a0..9019afb 100644 --- a/src/mainboard/emulation/qemu-q35/cmos.layout +++ b/src/mainboard/emulation/qemu-q35/cmos.layout @@ -1,11 +1,15 @@ entries
0 384 r 0 reserved_memory + 384 1 e 4 boot_option 388 4 h 0 reboot_counter -#392 3 r 0 unused -400 1 e 1 power_on_after_fail -412 4 e 6 debug_level + +400 8 r 0 reserved_century +440 8 r 0 reserved_ibm_ps2_century + +448 1 e 1 power_on_after_fail +452 4 e 6 debug_level 456 1 e 1 ECC_memory
# VBOOT @@ -29,4 +33,4 @@
checksums
-checksum 392 463 1008 +checksum 448 463 1008
-
Angel Pons (Code Review) -
Nico Huber (Code Review)