Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73833 )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/dedede/var/magolor: Add FW_CONFIG probe for EXT_VR ......................................................................
mb/google/dedede/var/magolor: Add FW_CONFIG probe for EXT_VR
Add FW_CONFIG probe for absent ANPEC APW8738BQBI IC on magolor.
BUG=b:223687184 TEST=emerge-dedede coreboot chromeos-bootimage and pass suspend_test and firmware_ConsecutiveBoot test Change-Id: I47ad313c4a14edb687913698986df9ece6cd721d Signed-off-by: Morris Hsu morris-hsu@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/73833 Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/magolor/Makefile.inc A src/mainboard/google/dedede/variants/magolor/ramstage.c 2 files changed, 33 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/magolor/Makefile.inc b/src/mainboard/google/dedede/variants/magolor/Makefile.inc index f2cbf8d..3151ca3 100644 --- a/src/mainboard/google/dedede/variants/magolor/Makefile.inc +++ b/src/mainboard/google/dedede/variants/magolor/Makefile.inc @@ -2,5 +2,6 @@
ramstage-$(CONFIG_FW_CONFIG) += variant.c ramstage-y += gpio.c +ramstage-y += ramstage.c
$(call add_vbt_to_cbfs, vbt_magister.bin, magister-data.vbt) diff --git a/src/mainboard/google/dedede/variants/magolor/ramstage.c b/src/mainboard/google/dedede/variants/magolor/ramstage.c new file mode 100644 index 0000000..5a671b9 --- /dev/null +++ b/src/mainboard/google/dedede/variants/magolor/ramstage.c @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#include <baseboard/variants.h> +#include <fw_config.h> +#include <soc/soc_chip.h> +static void ext_vr_update(void) +{ + struct soc_intel_jasperlake_config *cfg = config_of_soc(); + if (fw_config_probe(FW_CONFIG(EXT_VR, EXT_VR_ABSENT))) + cfg->disable_external_bypass_vr = 1; +} +void variant_devtree_update(void) +{ + ext_vr_update(); +}