Change in coreboot[master]: Revert "crossgcc: Upgrade GCC to 9.2.0"

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Patrick Rudolph (Code Review)

15 Mar 2020 15 Mar '20

7:14 a.m.

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39571 )

Change subject: Revert "crossgcc: Upgrade GCC to 9.2.0" ......................................................................

Revert "crossgcc: Upgrade GCC to 9.2.0"

Revert the upgrade as it breaks at least the devicetree parser on aarch64, tested on qemu aarch64 target.

This reverts commit dfd3f211740be4cf0d234bf4621ac384758a24ce.

Change-Id: I65607817188db21533014caa6d15be9a2004d498 Signed-off-by: Patrick Rudolph siro@das-labor.org --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch A util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch R util/crossgcc/patches/gcc-8.3.0_gnat.patch R util/crossgcc/patches/gcc-8.3.0_libgcc.patch A util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch A util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum D util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 9 files changed, 21,174 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/39571/1

Attachments:

attachment.htm (text/html — 2.2 KB)

Show replies by date

Patrick Rudolph (Code Review)

15 Mar 15 Mar

9:03 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39571 )

Change subject: Revert "crossgcc: Upgrade GCC to 9.2.0" ......................................................................

Patch Set 3:

I've no idea why this fails, please fix ASAP.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65607817188db21533014caa6d15be9a2004d498 Gerrit-Change-Number: 39571 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 15 Mar 2020 09:03:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Iru Cai (vimacs) (Code Review)

10:48 a.m.

Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39571 )

Change subject: Revert "crossgcc: Upgrade GCC to 9.2.0" ......................................................................

Patch Set 3:

Have you tried GCC 9.3?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65607817188db21533014caa6d15be9a2004d498 Gerrit-Change-Number: 39571 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-Comment-Date: Sun, 15 Mar 2020 10:48:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

11:08 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39571 )

Change subject: Revert "crossgcc: Upgrade GCC to 9.2.0" ......................................................................

Patch Set 3:

...

Patch Set 3:

Have you tried GCC 9.3?

No, haven't tried it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65607817188db21533014caa6d15be9a2004d498 Gerrit-Change-Number: 39571 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-Comment-Date: Sun, 15 Mar 2020 11:08:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin Roth (Code Review)

3:33 p.m.

Martin Roth has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/39571 )

Change subject: Revert "crossgcc: Upgrade GCC to 9.2.0" ......................................................................

Removed Verified-1 by build bot (Jenkins) no-reply@coreboot.org

-- To view, visit https://review.coreboot.org/c/coreboot/+/39571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65607817188db21533014caa6d15be9a2004d498 Gerrit-Change-Number: 39571 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-MessageType: deleteVote

Patrick Georgi (Code Review)

16 Mar 16 Mar

2:45 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39571 )

Change subject: Revert "crossgcc: Upgrade GCC to 9.2.0" ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65607817188db21533014caa6d15be9a2004d498 Gerrit-Change-Number: 39571 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-Comment-Date: Mon, 16 Mar 2020 14:45:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2:45 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39571 )

Change subject: Revert "crossgcc: Upgrade GCC to 9.2.0" ......................................................................

Revert "crossgcc: Upgrade GCC to 9.2.0"

Revert the upgrade as it breaks at least the devicetree parser on aarch64, tested on qemu aarch64 target.

This reverts commit dfd3f211740be4cf0d234bf4621ac384758a24ce.

Change-Id: I65607817188db21533014caa6d15be9a2004d498 Signed-off-by: Patrick Rudolph siro@das-labor.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/39571 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch A util/crossgcc/patches/gcc-8.3.0_gnat-bad_constant.patch R util/crossgcc/patches/gcc-8.3.0_gnat.patch R util/crossgcc/patches/gcc-8.3.0_libgcc.patch A util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch A util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum D util/crossgcc/sum/gcc-9.2.0.tar.xz.cksum M util/xcompile/xcompile 9 files changed, 21,174 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/39571 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65607817188db21533014caa6d15be9a2004d498 Gerrit-Change-Number: 39571 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Jett Rink jettrink@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Iru Cai (vimacs) mytbk920423@gmail.com Gerrit-MessageType: merged

1717

days inactive

1718

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Iru Cai (vimacs) (Code Review)
Martin Roth (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)