Change in coreboot[master]: util/release: Don't try to remove a file named like a long string

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37020 )

Change subject: util/release: Don't try to remove a file named like a long string
......................................................................

util/release: Don't try to remove a file named like a long string

Change-Id: I81fcb58720fb20ac4f57e31e9f991f5009aba568
Signed-off-by: Patrick Georgi 
---
M util/release/genrelnotes
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/37020/1

diff --git a/util/release/genrelnotes b/util/release/genrelnotes
index 25c2993..718c6f8 100755
--- a/util/release/genrelnotes
+++ b/util/release/genrelnotes
@@ -192,7 +192,6 @@
    	-exec rename 's/gnumakefile/Makefile.inc/' {} ;
    git checkout origin/master > /dev/null 2>&1
    git submodule update --init --checkout  > /dev/null 2>&1
-	rm -f "$mainboard_list_old" "$mainboard_list_new"
    rm "$LOGFILE"
    exit 1;
 }

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37020 )

Change subject: util/release: Don't try to remove a file named like a long string
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/37020/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37020/1//COMMIT_MSG@7 
PS1, Line 7: Don't try to rem
What does that mean?

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37020 )

Change subject: util/release: Don't try to remove a file named like a long string
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37020/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37020/1//COMMIT_MSG@7 
PS1, Line 7: Don't try to rem
> What does that mean?

$mainboard_list_{old,new} are strings of the form GOOGLE_VEYRON_MINNIE GETAC_P470 VIA_VT8454C ... I'm not sure what the original intent was here, but there's no file of that shape (and if there is, it's not ours to delete).

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37020 )

Change subject: util/release: Don't try to remove a file named like a long string
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37020 )

Change subject: util/release: Don't try to remove a file named like a long string
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37020/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37020/1//COMMIT_MSG@7 
PS1, Line 7: Don't try to rem
> $mainboard_list_{old,new} are strings of the form GOOGLE_VEYRON_MINNIE GETAC_P470 VIA_VT8454C ... […]

Ack

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37020 )

Change subject: util/release: Don't try to remove a file named like a long string
......................................................................

util/release: Don't try to remove a file named like a long string

Change-Id: I81fcb58720fb20ac4f57e31e9f991f5009aba568
Signed-off-by: Patrick Georgi 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37020
Tested-by: build bot (Jenkins) 
Reviewed-by: Stefan Reinauer 
---
M util/release/genrelnotes
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Stefan Reinauer: Looks good to me, approved

diff --git a/util/release/genrelnotes b/util/release/genrelnotes
index c19aaa7..d0f1a7a 100755
--- a/util/release/genrelnotes
+++ b/util/release/genrelnotes
@@ -192,7 +192,6 @@
    	-exec rename 's/gnumakefile/Makefile.inc/' {} ;
    git checkout origin/master > /dev/null 2>&1
    git submodule update --init --checkout  > /dev/null 2>&1
-	rm -f "$mainboard_list_old" "$mainboard_list_new"
    rm "$LOGFILE"
    exit 1;
 }