Attention is currently required from: Patrick Rudolph, Christian Walter, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52207 )
Change subject: mb/prodrive/hermes: Fix eeprom reading
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/prodrive/hermes/eeprom.c:
https://review.coreboot.org/c/coreboot/+/52207/comment/fd3a2053_80740e5c
PS2, Line 125: memcpy(writePointer, tmp, bytes_to_copy);
Shouldn't this be:
uint8_t writePointer = (uint8_t *)blob + write_offset + i;
writePointer[0] = tmp[0];
if (size - i > 1)
writePointer[1] = tmp[1];
Otherwise, we will write one byte too many when size is odd and greater than 1 (e.g. 3).
I was writing the above for Patchset 1, but you pushed Patchset 2 in the meantime. Still, I'd rather not use memcpy here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52207
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic08cf01d800babd4a9176dfb2337411b789040f3
Gerrit-Change-Number: 52207
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 09 Apr 2021 09:28:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment