Attention is currently required from: Angel Pons, Alexander Couzens, Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49253 )
Change subject: [RFC] pc80/rtc/option: Move register backup for SMI
......................................................................
Patch Set 7:
(2 comments)
File src/drivers/pc80/rtc/option.c:
https://review.coreboot.org/c/coreboot/+/49253/comment/8955332f_8148e208
PS7, Line 122: cmos_backup_idx();
"Datasheet says this register is write-only." Comment from lynxpoint about the CMOS index register pair 0x70/0x72.
File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/49253/comment/41704a8b_ff85b09a
PS6, Line 85: tmp70 = inb(0x70);
Datasheet says this register is write-only.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49253
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I025e9952a949834755f5cbc3dfe7b26ab9aaa032
Gerrit-Change-Number: 49253
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 05 Jun 2021 06:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment