Change in coreboot[master]: acpigen_ps2_keybd: Add keymap for Power key

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: Poor...

Rajat Jain (Code Review)

13 May 2020 13 May '20

3:44 p.m.

Rajat Jain has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41382 )

Change subject: acpigen_ps2_keybd: Add keymap for Power key ......................................................................

acpigen_ps2_keybd: Add keymap for Power key

Power key is a special non-matrixed key. Chrome /powerd only listens to the keyboard device for this key, so add its keymap.

Signed-off-by: Rajat Jain rajatja@google.com

BUG=b:155941390 TEST=TEst that power key generates KEY_POWER in linux evtest

Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f --- M src/arch/x86/acpigen_ps2_keybd.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/41382/1

diff --git a/src/arch/x86/acpigen_ps2_keybd.c b/src/arch/x86/acpigen_ps2_keybd.c index 7943f9a..835c457 100644 --- a/src/arch/x86/acpigen_ps2_keybd.c +++ b/src/arch/x86/acpigen_ps2_keybd.c @@ -169,6 +169,8 @@ KEYMAP(0xd0, KEY_DOWN), KEYMAP(0xcd, KEY_RIGHT), KEYMAP(0xc8, KEY_UP), + /* Power Key */ + KEYMAP(0xde, KEY_POWER), };

static void ssdt_generate_physmap(struct acpi_dp *dp, uint8_t num_top_row_keys,

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Rajat Jain (Code Review)

13 May 13 May

3:45 p.m.

Rajat Jain has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/41382 )

Change subject: acpigen_ps2_keybd: Add keymap for Power key ......................................................................

acpigen_ps2_keybd: Add keymap for Power key

Power key is a special non-matrixed key. Chrome /powerd only listens to the keyboard device for this key, so add its keymap.

Signed-off-by: Rajat Jain rajatja@google.com

BUG=b:155941390 TEST=TEst that power key generates KEY_POWER in linux evtest

Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f --- M src/acpi/acpigen_ps2_keybd.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/41382/2

Furquan Shaikh (Code Review)

14 May 14 May

1:13 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41382 )

Change subject: acpigen_ps2_keybd: Add keymap for Power key ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f Gerrit-Change-Number: 41382 Gerrit-PatchSet: 2 Gerrit-Owner: Rajat Jain rajatja@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 14 May 2020 19:13:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

1:14 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41382 )

Change subject: acpigen_ps2_keybd: Add keymap for Power key ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41382/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41382/2//COMMIT_MSG@16 PS2, Line 16: TEst Test

-- To view, visit https://review.coreboot.org/c/coreboot/+/41382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f Gerrit-Change-Number: 41382 Gerrit-PatchSet: 2 Gerrit-Owner: Rajat Jain rajatja@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 14 May 2020 19:14:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

2:23 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41382 )

Change subject: acpigen_ps2_keybd: Add keymap for Power key ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41382/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41382/2//COMMIT_MSG@13 PS2, Line 13: Signed-off-by: Rajat Jain rajatja@google.com Please move this directly below the Change-Id line.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f Gerrit-Change-Number: 41382 Gerrit-PatchSet: 2 Gerrit-Owner: Rajat Jain rajatja@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 14 May 2020 20:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rajat Jain (Code Review)

2:43 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Jett Rink, Edward Hill,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41382

to look at the new patch set (#3).

Change subject: acpigen_ps2_keybd: Add keymap for Power key ......................................................................

acpigen_ps2_keybd: Add keymap for Power key

Power key is a special non-matrixed key. Chrome /powerd only listens to the keyboard device for this key, so add its keymap.

BUG=b:155941390 TEST=Test that power key generates KEY_POWER in linux evtest

Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f Signed-off-by: Rajat Jain rajatja@google.com --- M src/acpi/acpigen_ps2_keybd.c 1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/41382/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/41382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f Gerrit-Change-Number: 41382 Gerrit-PatchSet: 3 Gerrit-Owner: Rajat Jain rajatja@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Rajat Jain (Code Review)

2:43 p.m.

Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41382 )

Change subject: acpigen_ps2_keybd: Add keymap for Power key ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41382/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41382/2//COMMIT_MSG@13 PS2, Line 13: Signed-off-by: Rajat Jain rajatja@google.com

...

Please move this directly below the Change-Id line.

Done

https://review.coreboot.org/c/coreboot/+/41382/2//COMMIT_MSG@16 PS2, Line 16: TEst

...

Test

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f Gerrit-Change-Number: 41382 Gerrit-PatchSet: 3 Gerrit-Owner: Rajat Jain rajatja@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 14 May 2020 20:43:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:52 p.m.

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41382 )

Change subject: acpigen_ps2_keybd: Add keymap for Power key ......................................................................

acpigen_ps2_keybd: Add keymap for Power key

Power key is a special non-matrixed key. Chrome /powerd only listens to the keyboard device for this key, so add its keymap.

BUG=b:155941390 TEST=Test that power key generates KEY_POWER in linux evtest

Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f Signed-off-by: Rajat Jain rajatja@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41382 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/acpi/acpigen_ps2_keybd.c 1 file changed, 2 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index 78eb55e..1379a89 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -168,6 +168,8 @@ KEYMAP(0xd0, KEY_DOWN), KEYMAP(0xcd, KEY_RIGHT), KEYMAP(0xc8, KEY_UP), + /* Power Key */ + KEYMAP(0xde, KEY_POWER), };

static void ssdt_generate_physmap(struct acpi_dp *dp, uint8_t num_top_row_keys,

-- To view, visit https://review.coreboot.org/c/coreboot/+/41382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f Gerrit-Change-Number: 41382 Gerrit-PatchSet: 4 Gerrit-Owner: Rajat Jain rajatja@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

10:10 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41382 )

Change subject: acpigen_ps2_keybd: Add keymap for Power key ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 2/2/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : FAIL : https://lava.9esec.io/r/3455 "QEMU x86 q35/ich9" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/3454 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3453 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3452

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I570602d9febcb5c17e58761f2004ee88be16c27f Gerrit-Change-Number: 41382 Gerrit-PatchSet: 4 Gerrit-Owner: Rajat Jain rajatja@google.com Gerrit-Reviewer: Edward Hill ecgh@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jett Rink jettrink@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 15 May 2020 04:10:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1825

days inactive

1827

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Furquan Shaikh (Code Review)
Paul Menzel (Code Review)
Rajat Jain (Code Review)
Tim Wawrzynczak (Code Review)