Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85453?usp=email )
Change subject: superio/ite/common: Add missing pnp_set_logical_device in ite_kill_watchdog ......................................................................
superio/ite/common: Add missing pnp_set_logical_device in ite_kill_watchdog
The watchdog registers are available in the GPIO LDN. Global LDN may not be sufficient to access the watchdog registers. Switch to GPIO LDN before disabling watchdog.
Change-Id: Id88472d474e947987dd6a63873057551cdcc2e31 Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/superio/ite/common/early_serial.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/85453/1
diff --git a/src/superio/ite/common/early_serial.c b/src/superio/ite/common/early_serial.c index ec218a6..66c4de9 100644 --- a/src/superio/ite/common/early_serial.c +++ b/src/superio/ite/common/early_serial.c @@ -137,6 +137,7 @@ void ite_kill_watchdog(pnp_devfn_t dev) { pnp_enter_conf_state(dev); + pnp_set_logical_device(dev); ite_sio_write(dev, ITE_CONFIG_REG_WATCHDOG, 0x00); ite_sio_write(dev, ITE_CONFIG_REG_WDT_TIMEOUT_LSB, 0x00); ite_sio_write(dev, ITE_CONFIG_REG_WDT_TIMEOUT_MSB, 0x00);