Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33169
Change subject: cpu/intel: Remove unused CPU_ADDR_BITS Kconfig option ......................................................................
cpu/intel: Remove unused CPU_ADDR_BITS Kconfig option
Change-Id: Ib5529ceeec9481e05c56f20af0d201f3d20ea3f9 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/intel/model_106cx/Kconfig M src/lib/cbfs.c M src/mainboard/lenovo/x201/Kconfig M src/mainboard/packardbell/ms2290/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/skylake/Kconfig 6 files changed, 0 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/33169/1
diff --git a/src/cpu/intel/model_106cx/Kconfig b/src/cpu/intel/model_106cx/Kconfig index f365cf1..91b5189 100644 --- a/src/cpu/intel/model_106cx/Kconfig +++ b/src/cpu/intel/model_106cx/Kconfig @@ -14,10 +14,4 @@ select SERIALIZED_SMM_INITIALIZATION select CPU_INTEL_COMMON
-if CPU_INTEL_MODEL_106CX - -config CPU_ADDR_BITS - int - default 32 - endif diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index 91368fb..d4433df 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -273,7 +273,6 @@ memset(&load[fsize], 0, stage.memlen - fsize);
prog_segment_loaded((uintptr_t)load, stage.memlen, SEG_FINAL); - out: prog_set_area(pstage, load, stage.memlen); prog_set_entry(pstage, entry, NULL); diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index 69e2038..ad22cc4 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -47,10 +47,6 @@ int default 4
-config CPU_ADDR_BITS - int - default 36 - # Without the Intel ME's EFFS partition some PCIe devices (like the USB and SATA # controllers) don't work as expected config ME_CLEANER_ARGS diff --git a/src/mainboard/packardbell/ms2290/Kconfig b/src/mainboard/packardbell/ms2290/Kconfig index c6a1e12..20b520d 100644 --- a/src/mainboard/packardbell/ms2290/Kconfig +++ b/src/mainboard/packardbell/ms2290/Kconfig @@ -49,8 +49,4 @@ int default 4
-config CPU_ADDR_BITS - int - default 36 - endif diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index 217d1ea..91476c1 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -158,10 +158,6 @@ The amount of anticipated stack usage in CAR by bootblock and other stages.
-config CPU_ADDR_BITS - int - default 39 - config SOC_INTEL_COMMON_BLOCK_GSPI_CLOCK_MHZ int default 100 diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index fcfe2b6..b67ddd7 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -116,10 +116,6 @@ hex default 0x200000
-config CPU_ADDR_BITS - int - default 36 - config DCACHE_RAM_BASE hex default 0xfef00000
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33169
to look at the new patch set (#2).
Change subject: cpu/intel: Remove unused CPU_ADDR_BITS Kconfig option ......................................................................
cpu/intel: Remove unused CPU_ADDR_BITS Kconfig option
Change-Id: Ib5529ceeec9481e05c56f20af0d201f3d20ea3f9 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/cpu/intel/model_106cx/Kconfig M src/lib/cbfs.c M src/mainboard/lenovo/x201/Kconfig M src/mainboard/packardbell/ms2290/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/skylake/Kconfig 6 files changed, 0 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/33169/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33169 )
Change subject: cpu/intel: Remove unused CPU_ADDR_BITS Kconfig option ......................................................................
Patch Set 2:
How did you validate which chips don't need it? It's not clear from a first glimpse for APL, for instance.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33169 )
Change subject: cpu/intel: Remove unused CPU_ADDR_BITS Kconfig option ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33169/2/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/#/c/33169/2/src/lib/cbfs.c@a276 PS2, Line 276: related ?
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33169 )
Change subject: cpu/intel: Remove unused CPU_ADDR_BITS Kconfig option ......................................................................
Patch Set 2:
There is reference in set_var_mtrr() to this Kconfig. Do you plan to consolidate all the copies of that function and use cpu_phys_address_size() there instead?
Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33169 )
Change subject: cpu/intel: Remove unused CPU_ADDR_BITS Kconfig option ......................................................................
Abandoned
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)