Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59491 )
Change subject: libpayload: Add CBMEM_IMD_ENTRY support to coreboot tables parser ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2: Thanks! We can also start removing these from src/lib/coreboot_table.c:add_cbmem_pointers() now, so they actually stop getting generated (probably best to do that in a separate CL so it's easier to revert if needed). I believe ACPI_GNVS, ACPI_CNVS, WIFI_CALIBRATION, FMAP and TYPE_C_INFO were only ever put there for libpayload, so those should be fine to remove. The others are also used by the Linux kernel (CONSOLE, VPD) or util/cbmem (TIMESTAMP, CONSOLE, TCPA_LOG), so we'll probably need to keep those for backwards-compatibility for a while (although we should also update the cbmem utility to use lb_cbmem_entry instead, so that we can deprecate those eventually).