Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43322 )
Change subject: util/inteltool: dump registers found on ICH10DO ......................................................................
util/inteltool: dump registers found on ICH10DO
Signed-off-by: Idwer Vollering vidwer@gmail.com Change-Id: I583c4211d87126f47527717c175c76cb3b68fd3a --- M util/inteltool/gpio.c M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 4 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/43322/1
diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c index 911ec3c..b4f3eda 100644 --- a/util/inteltool/gpio.c +++ b/util/inteltool/gpio.c @@ -943,6 +943,7 @@ defaults_size = ARRAY_SIZE(pp_pch_mobile_defaults); break; case PCI_DEVICE_ID_INTEL_ICH10: + case PCI_DEVICE_ID_INTEL_ICH10DO: case PCI_DEVICE_ID_INTEL_ICH10R: gpiobase = pci_read_word(sb, 0x48) & 0xfffc; gpio_registers = ich10_gpio_registers; diff --git a/util/inteltool/powermgt.c b/util/inteltool/powermgt.c index a21d002..f4ebc5a 100644 --- a/util/inteltool/powermgt.c +++ b/util/inteltool/powermgt.c @@ -780,6 +780,7 @@ pm_registers_size = ARRAY_SIZE(lynxpoint_lp_pm_registers); break; case PCI_DEVICE_ID_INTEL_ICH10: + case PCI_DEVICE_ID_INTEL_ICH10DO: case PCI_DEVICE_ID_INTEL_ICH10R: pmbase = pci_read_word(sb, 0x40) & 0xff80; pm_registers = ich10_pm_registers; diff --git a/util/inteltool/rootcmplx.c b/util/inteltool/rootcmplx.c index 490897f..b1e4939 100644 --- a/util/inteltool/rootcmplx.c +++ b/util/inteltool/rootcmplx.c @@ -29,6 +29,7 @@ case PCI_DEVICE_ID_INTEL_ICH9M: case PCI_DEVICE_ID_INTEL_ICH9ME: case PCI_DEVICE_ID_INTEL_ICH10: + case PCI_DEVICE_ID_INTEL_ICH10DO: case PCI_DEVICE_ID_INTEL_ICH10R: case PCI_DEVICE_ID_INTEL_NM10: case PCI_DEVICE_ID_INTEL_I63XX: diff --git a/util/inteltool/spi.c b/util/inteltool/spi.c index 3d94c1f..bed5886 100644 --- a/util/inteltool/spi.c +++ b/util/inteltool/spi.c @@ -107,6 +107,7 @@ case PCI_DEVICE_ID_INTEL_ICH9M: case PCI_DEVICE_ID_INTEL_ICH9ME: case PCI_DEVICE_ID_INTEL_ICH10: + case PCI_DEVICE_ID_INTEL_ICH10DO: case PCI_DEVICE_ID_INTEL_ICH10R: case PCI_DEVICE_ID_INTEL_NM10: bios_cntl = pci_read_byte(sb, 0xdc);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43322 )
Change subject: util/inteltool: dump registers found on ICH10DO ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43322/1/util/inteltool/gpio.c File util/inteltool/gpio.c:
https://review.coreboot.org/c/coreboot/+/43322/1/util/inteltool/gpio.c@946 PS1, Line 946: PCI_DEVICE_ID_INTEL_ICH10DO This doesn't appear on inteltool files. Maybe look for `PCI_DEVICE_ID_INTEL_ICH10R` and add ICH10DO everywhere?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43322 )
Change subject: util/inteltool: dump registers found on ICH10DO ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43322/1/util/inteltool/gpio.c File util/inteltool/gpio.c:
https://review.coreboot.org/c/coreboot/+/43322/1/util/inteltool/gpio.c@946 PS1, Line 946: PCI_DEVICE_ID_INTEL_ICH10DO
This doesn't appear on inteltool files. […]
Oh wait, it's in the parent commit. Can we squash this one, please?
Hello build bot (Jenkins), Stefan Reinauer, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43322
to look at the new patch set (#2).
Change subject: util/inteltool: add PCI ID for ICH10DO ......................................................................
util/inteltool: add PCI ID for ICH10DO
Change-Id: I3561679ef50f4c094d2503539074c957f759ecef Signed-off-by: Idwer Vollering vidwer@gmail.com
util/inteltool: dump registers found on ICH10DO
Signed-off-by: Idwer Vollering vidwer@gmail.com Change-Id: I583c4211d87126f47527717c175c76cb3b68fd3a --- M util/inteltool/gpio.c M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/powermgt.c M util/inteltool/rootcmplx.c M util/inteltool/spi.c 6 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/43322/2
Idwer Vollering has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43322 )
Change subject: util/inteltool: add PCI ID for ICH10DO ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Idwer Vollering (Code Review)