Change in ...coreboot[master]: vendorcode/amd: Move 'static' is at beginning of declaration

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33674

Change subject: vendorcode/amd: Move 'static' is at beginning of declaration
......................................................................

vendorcode/amd: Move 'static' is at beginning of declaration

Change-Id: Ib9934f103262c57af076bd27d97c3166d8f2318b
Signed-off-by: Elyes HAOUAS 
---
M src/vendorcode/amd/cimx/sb800/AZALIA.c
M src/vendorcode/amd/cimx/sb800/ECfanc.c
M src/vendorcode/amd/cimx/sb800/SATA.c
M src/vendorcode/amd/cimx/sb800/SBCMN.c
M src/vendorcode/amd/cimx/sb800/SBPort.c
5 files changed, 20 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/33674/1

diff --git a/src/vendorcode/amd/cimx/sb800/AZALIA.c b/src/vendorcode/amd/cimx/sb800/AZALIA.c
index ccb4f90..1d7d0f9 100644
--- a/src/vendorcode/amd/cimx/sb800/AZALIA.c
+++ b/src/vendorcode/amd/cimx/sb800/AZALIA.c
@@ -61,7 +61,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc882Table[] =
+static const CODECENTRY AzaliaCodecAlc882Table[] =
 {
   {0x14, 0x01014010},
   {0x15, 0x01011012},
@@ -84,7 +84,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc262Table[] =
+static const CODECENTRY AzaliaCodecAlc262Table[] =
 {
   {0x14, 0x01014010},
   {0x15, 0x411111F0},
@@ -106,7 +106,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc269Table[] =
+static const CODECENTRY AzaliaCodecAlc269Table[] =
 {
   {0x12, 0x99A30960},
   {0x14, 0x99130110},
@@ -129,7 +129,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc861Table[] =
+static const CODECENTRY AzaliaCodecAlc861Table[] =
 {
   {0x01, 0x8086C601},
   {0x0B, 0x01014110},
@@ -152,7 +152,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc889Table[] =
+static const CODECENTRY AzaliaCodecAlc889Table[] =
 {
   {0x11, 0x411111F0},
   {0x14, 0x01014010},
@@ -176,7 +176,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAd1984Table[] =
+static const CODECENTRY AzaliaCodecAd1984Table[] =
 {
   {0x11, 0x0221401F},
   {0x12, 0x90170110},
@@ -198,7 +198,7 @@
  *
  *
  */
-const static CODECENTRY FrontPanelAzaliaCodecTableList[] =
+static const CODECENTRY FrontPanelAzaliaCodecTableList[] =
 {
   {0x19, 0x02A19040},
   {0x1b, 0x02214020},
@@ -211,7 +211,7 @@
  *
  *
  */
-const static CODECTBLLIST azaliaCodecTableList[] =
+static const CODECTBLLIST azaliaCodecTableList[] =
 {
   {0x010ec0880, (CODECENTRY*)&AzaliaCodecAlc882Table[0]},
   {0x010ec0882, (CODECENTRY*)&AzaliaCodecAlc882Table[0]},
diff --git a/src/vendorcode/amd/cimx/sb800/ECfanc.c b/src/vendorcode/amd/cimx/sb800/ECfanc.c
index 7e679c9..151d882 100644
--- a/src/vendorcode/amd/cimx/sb800/ECfanc.c
+++ b/src/vendorcode/amd/cimx/sb800/ECfanc.c
@@ -40,7 +40,7 @@
  *
  *
  */
-const static UINT8 FunctionNumber[] =
+static const UINT8 FunctionNumber[] =
 {
   Fun_81,
   Fun_83,
@@ -55,7 +55,7 @@
  *
  *
  */
-const static UINT8 MaxZone[] =
+static const UINT8 MaxZone[] =
 {
   4,
   4,
@@ -70,7 +70,7 @@
  *
  *
  */
-const static UINT8 MaxRegister[] =
+static const UINT8 MaxRegister[] =
 {
   MSG_REG9,
   MSG_REGB,
diff --git a/src/vendorcode/amd/cimx/sb800/SATA.c b/src/vendorcode/amd/cimx/sb800/SATA.c
index c2f2162..f9823d8 100644
--- a/src/vendorcode/amd/cimx/sb800/SATA.c
+++ b/src/vendorcode/amd/cimx/sb800/SATA.c
@@ -176,7 +176,7 @@
  *
  *
  */
-const static UINT32 sataIfCodeTable[] =
+static const UINT32 sataIfCodeTable[] =
 {
   0x01018F40, //sata class ID of IDE
   0x01040040, //sata class ID of RAID
@@ -192,7 +192,7 @@
  *
  *
  */
-const static UINT16 sataDeviceIDTable[] =
+static const UINT16 sataDeviceIDTable[] =
 {
   0x4390,  //sata device ID of IDE
   0x4392,  //sata device ID of RAID
@@ -208,7 +208,7 @@
  *
  *
  */
-const static SATAPHYSETTING sataPhyTable[] =
+static const SATAPHYSETTING sataPhyTable[] =
 {
   {0x3006, 0x0056A607},
   {0x2006, 0x00061400},
diff --git a/src/vendorcode/amd/cimx/sb800/SBCMN.c b/src/vendorcode/amd/cimx/sb800/SBCMN.c
index 8e9f0e2..ab203a1 100644
--- a/src/vendorcode/amd/cimx/sb800/SBCMN.c
+++ b/src/vendorcode/amd/cimx/sb800/SBCMN.c
@@ -83,7 +83,7 @@
  * sbEarlyPostByteInitTable - PCI device registers initial during early POST.
  *
  */
-const static REG8MASK sbEarlyPostByteInitTable[] =
+static const REG8MASK sbEarlyPostByteInitTable[] =
 {
   // SMBUS Device (Bus 0, Dev 20, Func 0)
   {0x00, SMBUS_BUS_DEV_FUN, 0},
@@ -134,7 +134,7 @@
  * sbPmioEPostInitTable - Southbridge ACPI MMIO initial during POST.
  *
  */
-const static AcpiRegWrite sbPmioEPostInitTable[] =
+static const AcpiRegWrite sbPmioEPostInitTable[] =
 {
   // HPET workaround
   {PMIO_BASE >> 8,  SB_PMIOA_REG54 + 3, 0xFC, BIT0 + BIT1},
@@ -251,7 +251,7 @@
  * abTblEntry800 - AB-Link Configuration Table for SB800
  *
  */
-const static ABTBLENTRY abTblEntry800[] =
+static const ABTBLENTRY abTblEntry800[] =
 {
   // RPR Enable downstream posted transactions to pass non-posted transactions.
   {ABCFG, SB_ABCFG_REG10090, BIT8 + BIT16, BIT8 + BIT16},
@@ -297,7 +297,7 @@
  * SbPcieOrderRule - AB-Link Configuration Table for ablink Post Pass Np Downstream/Upstream Feature
  *
  */
-const static ABTBLENTRY SbPcieOrderRule[] =
+static const ABTBLENTRY SbPcieOrderRule[] =
 {
 // abPostPassNpDownStreamTbl
   {ABCFG, SB_ABCFG_REG10060, BIT31, BIT31},
diff --git a/src/vendorcode/amd/cimx/sb800/SBPort.c b/src/vendorcode/amd/cimx/sb800/SBPort.c
index 048850d..ba6c8f0 100644
--- a/src/vendorcode/amd/cimx/sb800/SBPort.c
+++ b/src/vendorcode/amd/cimx/sb800/SBPort.c
@@ -49,7 +49,7 @@
 /**
  * sbPorInitPciTable - PCI device registers initial during the power on stage.
  */
-const static REG8MASK sbPorInitPciTable[] =
+static const REG8MASK sbPorInitPciTable[] =
 {
   // SATA device
   {0x00, SATA_BUS_DEV_FUN, 0},
@@ -82,7 +82,7 @@
 /**
  * sbPmioPorInitTable - Southbridge ACPI MMIO initial during the power on stage.
  */
-const static AcpiRegWrite sbPmioPorInitTable[] =
+static const AcpiRegWrite sbPmioPorInitTable[] =
 {
   {PMIO_BASE >> 8,  SB_PMIOA_REG5D, 0x00, BIT0},
   {PMIO_BASE >> 8,  SB_PMIOA_REGD2, 0xCF, BIT4 + BIT5},

Change in ...coreboot[master]: vendorcode/amd: Move 'static' at beginning of declaration

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33674

to look at the new patch set (#2).

Change subject: vendorcode/amd: Move 'static' at beginning of declaration
......................................................................

vendorcode/amd: Move 'static' at beginning of declaration

Change-Id: Ib9934f103262c57af076bd27d97c3166d8f2318b
Signed-off-by: Elyes HAOUAS 
---
M src/vendorcode/amd/cimx/sb800/AZALIA.c
M src/vendorcode/amd/cimx/sb800/ECfanc.c
M src/vendorcode/amd/cimx/sb800/SATA.c
M src/vendorcode/amd/cimx/sb800/SBCMN.c
M src/vendorcode/amd/cimx/sb800/SBPort.c
5 files changed, 20 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/33674/2

Change in ...coreboot[master]: vendorcode/amd: Move 'static' to the beginning of declaration

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33674

to look at the new patch set (#3).

Change subject: vendorcode/amd: Move 'static' to the beginning of declaration
......................................................................

vendorcode/amd: Move 'static' to the beginning of declaration

Change-Id: Ib9934f103262c57af076bd27d97c3166d8f2318b
Signed-off-by: Elyes HAOUAS 
---
M src/vendorcode/amd/cimx/sb800/AZALIA.c
M src/vendorcode/amd/cimx/sb800/ECfanc.c
M src/vendorcode/amd/cimx/sb800/SATA.c
M src/vendorcode/amd/cimx/sb800/SBCMN.c
M src/vendorcode/amd/cimx/sb800/SBPort.c
5 files changed, 20 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/33674/3

Change in ...coreboot[master]: vendorcode/amd: Move 'static' to the beginning of declaration

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33674 )

Change subject: vendorcode/amd: Move 'static' to the beginning of declaration
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: vendorcode/amd: Move 'static' to the beginning of declaration

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33674 )

Change subject: vendorcode/amd: Move 'static' to the beginning of declaration
......................................................................

vendorcode/amd: Move 'static' to the beginning of declaration

Change-Id: Ib9934f103262c57af076bd27d97c3166d8f2318b
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33674
Tested-by: build bot (Jenkins) 
Reviewed-by: Martin Roth 
---
M src/vendorcode/amd/cimx/sb800/AZALIA.c
M src/vendorcode/amd/cimx/sb800/ECfanc.c
M src/vendorcode/amd/cimx/sb800/SATA.c
M src/vendorcode/amd/cimx/sb800/SBCMN.c
M src/vendorcode/amd/cimx/sb800/SBPort.c
5 files changed, 20 insertions(+), 20 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

diff --git a/src/vendorcode/amd/cimx/sb800/AZALIA.c b/src/vendorcode/amd/cimx/sb800/AZALIA.c
index ccb4f90..1d7d0f9 100644
--- a/src/vendorcode/amd/cimx/sb800/AZALIA.c
+++ b/src/vendorcode/amd/cimx/sb800/AZALIA.c
@@ -61,7 +61,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc882Table[] =
+static const CODECENTRY AzaliaCodecAlc882Table[] =
 {
   {0x14, 0x01014010},
   {0x15, 0x01011012},
@@ -84,7 +84,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc262Table[] =
+static const CODECENTRY AzaliaCodecAlc262Table[] =
 {
   {0x14, 0x01014010},
   {0x15, 0x411111F0},
@@ -106,7 +106,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc269Table[] =
+static const CODECENTRY AzaliaCodecAlc269Table[] =
 {
   {0x12, 0x99A30960},
   {0x14, 0x99130110},
@@ -129,7 +129,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc861Table[] =
+static const CODECENTRY AzaliaCodecAlc861Table[] =
 {
   {0x01, 0x8086C601},
   {0x0B, 0x01014110},
@@ -152,7 +152,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAlc889Table[] =
+static const CODECENTRY AzaliaCodecAlc889Table[] =
 {
   {0x11, 0x411111F0},
   {0x14, 0x01014010},
@@ -176,7 +176,7 @@
  *
  *
  */
-const static CODECENTRY AzaliaCodecAd1984Table[] =
+static const CODECENTRY AzaliaCodecAd1984Table[] =
 {
   {0x11, 0x0221401F},
   {0x12, 0x90170110},
@@ -198,7 +198,7 @@
  *
  *
  */
-const static CODECENTRY FrontPanelAzaliaCodecTableList[] =
+static const CODECENTRY FrontPanelAzaliaCodecTableList[] =
 {
   {0x19, 0x02A19040},
   {0x1b, 0x02214020},
@@ -211,7 +211,7 @@
  *
  *
  */
-const static CODECTBLLIST azaliaCodecTableList[] =
+static const CODECTBLLIST azaliaCodecTableList[] =
 {
   {0x010ec0880, (CODECENTRY*)&AzaliaCodecAlc882Table[0]},
   {0x010ec0882, (CODECENTRY*)&AzaliaCodecAlc882Table[0]},
diff --git a/src/vendorcode/amd/cimx/sb800/ECfanc.c b/src/vendorcode/amd/cimx/sb800/ECfanc.c
index 7e679c9..151d882 100644
--- a/src/vendorcode/amd/cimx/sb800/ECfanc.c
+++ b/src/vendorcode/amd/cimx/sb800/ECfanc.c
@@ -40,7 +40,7 @@
  *
  *
  */
-const static UINT8 FunctionNumber[] =
+static const UINT8 FunctionNumber[] =
 {
   Fun_81,
   Fun_83,
@@ -55,7 +55,7 @@
  *
  *
  */
-const static UINT8 MaxZone[] =
+static const UINT8 MaxZone[] =
 {
   4,
   4,
@@ -70,7 +70,7 @@
  *
  *
  */
-const static UINT8 MaxRegister[] =
+static const UINT8 MaxRegister[] =
 {
   MSG_REG9,
   MSG_REGB,
diff --git a/src/vendorcode/amd/cimx/sb800/SATA.c b/src/vendorcode/amd/cimx/sb800/SATA.c
index c2f2162..f9823d8 100644
--- a/src/vendorcode/amd/cimx/sb800/SATA.c
+++ b/src/vendorcode/amd/cimx/sb800/SATA.c
@@ -176,7 +176,7 @@
  *
  *
  */
-const static UINT32 sataIfCodeTable[] =
+static const UINT32 sataIfCodeTable[] =
 {
   0x01018F40, //sata class ID of IDE
   0x01040040, //sata class ID of RAID
@@ -192,7 +192,7 @@
  *
  *
  */
-const static UINT16 sataDeviceIDTable[] =
+static const UINT16 sataDeviceIDTable[] =
 {
   0x4390,  //sata device ID of IDE
   0x4392,  //sata device ID of RAID
@@ -208,7 +208,7 @@
  *
  *
  */
-const static SATAPHYSETTING sataPhyTable[] =
+static const SATAPHYSETTING sataPhyTable[] =
 {
   {0x3006, 0x0056A607},
   {0x2006, 0x00061400},
diff --git a/src/vendorcode/amd/cimx/sb800/SBCMN.c b/src/vendorcode/amd/cimx/sb800/SBCMN.c
index 8e9f0e2..ab203a1 100644
--- a/src/vendorcode/amd/cimx/sb800/SBCMN.c
+++ b/src/vendorcode/amd/cimx/sb800/SBCMN.c
@@ -83,7 +83,7 @@
  * sbEarlyPostByteInitTable - PCI device registers initial during early POST.
  *
  */
-const static REG8MASK sbEarlyPostByteInitTable[] =
+static const REG8MASK sbEarlyPostByteInitTable[] =
 {
   // SMBUS Device (Bus 0, Dev 20, Func 0)
   {0x00, SMBUS_BUS_DEV_FUN, 0},
@@ -134,7 +134,7 @@
  * sbPmioEPostInitTable - Southbridge ACPI MMIO initial during POST.
  *
  */
-const static AcpiRegWrite sbPmioEPostInitTable[] =
+static const AcpiRegWrite sbPmioEPostInitTable[] =
 {
   // HPET workaround
   {PMIO_BASE >> 8,  SB_PMIOA_REG54 + 3, 0xFC, BIT0 + BIT1},
@@ -251,7 +251,7 @@
  * abTblEntry800 - AB-Link Configuration Table for SB800
  *
  */
-const static ABTBLENTRY abTblEntry800[] =
+static const ABTBLENTRY abTblEntry800[] =
 {
   // RPR Enable downstream posted transactions to pass non-posted transactions.
   {ABCFG, SB_ABCFG_REG10090, BIT8 + BIT16, BIT8 + BIT16},
@@ -297,7 +297,7 @@
  * SbPcieOrderRule - AB-Link Configuration Table for ablink Post Pass Np Downstream/Upstream Feature
  *
  */
-const static ABTBLENTRY SbPcieOrderRule[] =
+static const ABTBLENTRY SbPcieOrderRule[] =
 {
 // abPostPassNpDownStreamTbl
   {ABCFG, SB_ABCFG_REG10060, BIT31, BIT31},
diff --git a/src/vendorcode/amd/cimx/sb800/SBPort.c b/src/vendorcode/amd/cimx/sb800/SBPort.c
index 048850d..ba6c8f0 100644
--- a/src/vendorcode/amd/cimx/sb800/SBPort.c
+++ b/src/vendorcode/amd/cimx/sb800/SBPort.c
@@ -49,7 +49,7 @@
 /**
  * sbPorInitPciTable - PCI device registers initial during the power on stage.
  */
-const static REG8MASK sbPorInitPciTable[] =
+static const REG8MASK sbPorInitPciTable[] =
 {
   // SATA device
   {0x00, SATA_BUS_DEV_FUN, 0},
@@ -82,7 +82,7 @@
 /**
  * sbPmioPorInitTable - Southbridge ACPI MMIO initial during the power on stage.
  */
-const static AcpiRegWrite sbPmioPorInitTable[] =
+static const AcpiRegWrite sbPmioPorInitTable[] =
 {
   {PMIO_BASE >> 8,  SB_PMIOA_REG5D, 0x00, BIT0},
   {PMIO_BASE >> 8,  SB_PMIOA_REGD2, 0xCF, BIT4 + BIT5},