Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37605 )
Change subject: mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz ......................................................................
mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz
Tuning i2c frequency for dratini: I2C0: 396 KHz I2C1: 398 KHz I2C3: not use I2C4: 394 KHz
BUG=b:145891557 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I1431554fbce5f3ce113ef1a934e39448e7ba321c Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/37605/1
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 28b18b8..564a14d 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -35,15 +35,18 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 50, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST, - }, - .i2c[3] = { - .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 25, }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 60, }, }"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37605 )
Change subject: mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37605/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37605/1//COMMIT_MSG@12 PS1, Line 12: not use unused
https://review.coreboot.org/c/coreboot/+/37605/1//COMMIT_MSG@14 PS1, Line 14: What problem does this fix?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37605
to look at the new patch set (#2).
Change subject: mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz ......................................................................
mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz
Tuning i2c frequency for dratini: I2C0: 396 KHz I2C1: 398 KHz I2C3: unused I2C4: 394 KHz
BUG=b:145891557 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I1431554fbce5f3ce113ef1a934e39448e7ba321c Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/37605/2
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37605 )
Change subject: mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37605/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37605/1//COMMIT_MSG@12 PS1, Line 12: not use
unused
Done
https://review.coreboot.org/c/coreboot/+/37605/1//COMMIT_MSG@14 PS1, Line 14:
What problem does this fix?
To meet i2c spec, the fast mode's max frequency is 400kHz
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37605 )
Change subject: mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz ......................................................................
Patch Set 2: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37605 )
Change subject: mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz ......................................................................
Patch Set 2: Code-Review+2
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37605 )
Change subject: mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37605/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37605/1//COMMIT_MSG@14 PS1, Line 14:
To meet i2c spec, the fast mode's max frequency is 400kHz
Ack
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37605 )
Change subject: mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz ......................................................................
mb/goog/hatch/var/dratini: Tune i2c frequency to 400 KHz
Tuning i2c frequency for dratini: I2C0: 396 KHz I2C1: 398 KHz I2C3: unused I2C4: 394 KHz
BUG=b:145891557 BRANCH=hatch TEST=emerge-hatch coreboot chromeos-bootimage
Change-Id: I1431554fbce5f3ce113ef1a934e39448e7ba321c Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37605 Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb 1 file changed, 6 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 28b18b8..564a14d 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -35,15 +35,18 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 50, + .fall_time_ns = 15, }, .i2c[1] = { .speed = I2C_SPEED_FAST, - }, - .i2c[3] = { - .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 25, }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 60, }, }"
-
Chen Wisley (Code Review) -
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)
-
Wisley Chen (Code Review)