Attention is currently required from: Julius Werner, Jan Dabros, Yu-Ping Wu. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60080 )
Change subject: libpayload: Enable vboot integration ......................................................................
Patch Set 7:
(3 comments)
File payloads/libpayload/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/60080/comment/b519ffd0_ac85149e PS5, Line 5: menu "Verified boot (vboot)"
You don't have a menu for CBFS so I don't think you should have one here either. […]
I will leave it without menu for now.
Maybe Kconfig options should be grouped into menus in the future.
https://review.coreboot.org/c/coreboot/+/60080/comment/e648ad3d_31f59877 PS5, Line 22: config VBOOT_TEST_PRINT
Now you took VBOOT_DEBUG out but added this? We shouldn't need any of this. […]
Oh, yes. This is unnecessary. Sorry. Payload/tests can simply override vb2ex_printf(), so VBOOT_DEBUG can stay enabled.
File payloads/libpayload/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/60080/comment/ef1aaea7_c45ff9e7 PS5, Line 47: $(VBOOT_BUILD_DIR)/vboot_fw.a
Why not just use the `fwlib` target here?
If you look at vboot Makefile around line 881, you will see, that fwlib has effect only if FIRMWARE_ARCH is filled, so for all architectures except ARCH_MOCK. ARCH_MOCK, like depthcharge unit-tests sets FIRMWARE_ARCH value to <empty>, so this target will have no effect, and vboot_fw.a will not compile. It works for depthcharge, so there should be no problem here any time soon (that is if vboot_fw.a build path will stay the same).
-
Jakub Czapiga (Code Review)