Attention is currently required from: Angel Pons, Matt DeVillier, Sean Rhodes.
Filip Brozovic has posted comments on this change by Filip Brozovic. ( https://review.coreboot.org/c/coreboot/+/86039?usp=email )
Change subject: CFR: Add min/max/step values and hex display flag for number options
......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/include/commonlib/cfr.h:
https://review.coreboot.org/c/coreboot/+/86039/comment/b3700201_7d65c496?usp... :
PS2, Line 139: uint32_t min;
: uint32_t max;
: uint32_t step;
Yes, the CFR header is where a version number would be. […]
Should we add a fixed version number to the header in coreboot, change `lb_cfr_numeric_option` to add `min`, `max` and `step` as has been done here, and let whoever is parsing the data decide how large the struct is based on the version?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86039?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e70f1430fb1911f1ad974832f8abfe76f928ac3
Gerrit-Change-Number: 86039
Gerrit-PatchSet: 2
Gerrit-Owner: Filip Brozovic
fbrozovic@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 21 Jan 2025 06:36:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Filip Brozovic
fbrozovic@gmail.com