build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27619 )
Change subject: soc/amd/common/block/psp/psp.c: Remove use of PspBaseLib ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/include/am... File src/soc/amd/common/block/include/amdblocks/psp.h:
https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/include/am... PS10, Line 35: #define MAGIC_ENABLE_BITS 0x34 /* Extra PCI HDR Ctl Enables */ trailing whitespace
https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/psp/psp.c File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/psp/psp.c@... PS10, Line 49: if (value32 == 0xFFFFFFFF) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/27619/10/src/soc/amd/common/block/psp/psp.c@... PS10, Line 56: if (pci_read_config32(SOC_PSP_DEV, PCI_BASE_ADDRESS_4) & ~0x0F) { braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)