Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47426 )
Change subject: mb/hp/folio_9480m: Drop `sata_ahci` from devtree ......................................................................
mb/hp/folio_9480m: Drop `sata_ahci` from devtree
Commit 8084b38568 (sb/intel/lynxpoint/sata: Always use AHCI mode) dropped the devtree option, but missed this recently-added mainboard.
Change-Id: I6ab3a763c0bcd7431193c48e473639589b1a1e1a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/hp/folio_9480m/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/47426/1
diff --git a/src/mainboard/hp/folio_9480m/devicetree.cb b/src/mainboard/hp/folio_9480m/devicetree.cb index bd81d38..140aa84 100644 --- a/src/mainboard/hp/folio_9480m/devicetree.cb +++ b/src/mainboard/hp/folio_9480m/devicetree.cb @@ -36,7 +36,6 @@ register "gen2_dec" = "0x000c0101" register "gen4_dec" = "0x000402e9" register "xhci_default" = "1" - register "sata_ahci" = "1" register "sata_port1_gen3_dtle" = "0x6" # SATA(1), M.2(3) register "sata_port_map" = "0xa"
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47426 )
Change subject: mb/hp/folio_9480m: Drop `sata_ahci` from devtree ......................................................................
Patch Set 1: Code-Review+2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47426 )
Change subject: mb/hp/folio_9480m: Drop `sata_ahci` from devtree ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47426 )
Change subject: mb/hp/folio_9480m: Drop `sata_ahci` from devtree ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47426 )
Change subject: mb/hp/folio_9480m: Drop `sata_ahci` from devtree ......................................................................
Patch Set 1:
I'm going to submit this right now to fix master.
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47426 )
Change subject: mb/hp/folio_9480m: Drop `sata_ahci` from devtree ......................................................................
mb/hp/folio_9480m: Drop `sata_ahci` from devtree
Commit 8084b38568 (sb/intel/lynxpoint/sata: Always use AHCI mode) dropped the devtree option, but missed this recently-added mainboard.
Change-Id: I6ab3a763c0bcd7431193c48e473639589b1a1e1a Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47426 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/hp/folio_9480m/devicetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, approved
diff --git a/src/mainboard/hp/folio_9480m/devicetree.cb b/src/mainboard/hp/folio_9480m/devicetree.cb index bd81d38..140aa84 100644 --- a/src/mainboard/hp/folio_9480m/devicetree.cb +++ b/src/mainboard/hp/folio_9480m/devicetree.cb @@ -36,7 +36,6 @@ register "gen2_dec" = "0x000c0101" register "gen4_dec" = "0x000402e9" register "xhci_default" = "1" - register "sata_ahci" = "1" register "sata_port1_gen3_dtle" = "0x6" # SATA(1), M.2(3) register "sata_port_map" = "0xa"
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)