Change in coreboot[master]: soc/amd/picasso: Drop _INI method for AZHD device

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40782 )

Change subject: soc/amd/picasso: Drop _INI method for AZHD device
......................................................................

soc/amd/picasso: Drop _INI method for AZHD device

_INI method for AZHD device for Picasso family was just copied from
Stoneyridge as part of initial change. There is no evidence that this
is required for Picasso. Also, removing the _INI method works
perfectly fine. Thus, this change drops the _INI method for AZHD
device on Picasso.

BUG=b:155132752
TEST=Verified that audio still works on Trembyle

Change-Id: If42abf91ee5cd47a881b0a3b4ca1916ea5169261
Signed-off-by: Furquan Shaikh 
---
M src/soc/amd/picasso/acpi/northbridge.asl
1 file changed, 0 insertions(+), 34 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/40782/1

diff --git a/src/soc/amd/picasso/acpi/northbridge.asl b/src/soc/amd/picasso/acpi/northbridge.asl
index 6b6bd7c..0a3a979 100644
--- a/src/soc/amd/picasso/acpi/northbridge.asl
+++ b/src/soc/amd/picasso/acpi/northbridge.asl
@@ -79,37 +79,3 @@

Device(AZHD) {	/* 0:9.2 - HD Audio */
    Name(_ADR, 0x00090002)
-	OperationRegion(AZPD, PCI_Config, 0x00, 0x100)
-		Field(AZPD, AnyAcc, NoLock, Preserve) {
-		offset (0x42),
-		NSDI, 1,
-		NSDO, 1,
-		NSEN, 1,
-		offset (0x44),
-		IPCR, 4,
-		offset (0x54),
-		PWST, 2,
-		, 6,
-		PMEB, 1,
-		, 6,
-		PMST, 1,
-		offset (0x62),
-		MMCR, 1,
-		offset (0x64),
-		MMLA, 32,
-		offset (0x68),
-		MMHA, 32,
-		offset (0x6c),
-		MMDT, 16,
-	}
-
-	Method (_INI, 0, NotSerialized)
-	{
-		If (LEqual (OSVR, 0x03))
-		{
-			Store (Zero, NSEN)
-			Store (One, NSDO)
-			Store (One, NSDI)
-		}
-	}
-} /* end AZHD */

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40782 )

Change subject: soc/amd/picasso: Drop _INI method for AZHD device
......................................................................

soc/amd/picasso: Drop _INI method for AZHD device

_INI method for AZHD device for Picasso family was just copied from
Stoneyridge as part of initial change. There is no evidence that this
is required for Picasso. Also, removing the _INI method works
perfectly fine. Thus, this change drops the _INI method for AZHD
device on Picasso.

BUG=b:155132752
TEST=Verified that audio still works on Trembyle

Change-Id: If42abf91ee5cd47a881b0a3b4ca1916ea5169261
Signed-off-by: Furquan Shaikh 
---
M src/soc/amd/picasso/acpi/northbridge.asl
1 file changed, 0 insertions(+), 33 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/40782/2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40782 )

Change subject: soc/amd/picasso: Drop _INI method for AZHD device
......................................................................

Patch Set 2: Code-Review+1

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40782 )

Change subject: soc/amd/picasso: Drop _INI method for AZHD device
......................................................................

Patch Set 2:

Does Microsoft Windows maybe need that?

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40782 )

Change subject: soc/amd/picasso: Drop _INI method for AZHD device
......................................................................

Patch Set 2:
> Patch Set 2:
>
> Does Microsoft Windows maybe need that?

IIUC, the check OSVR for 0x3 specifically means Linux.

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40782 )

Change subject: soc/amd/picasso: Drop _INI method for AZHD device
......................................................................

Patch Set 3: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40782 )

Change subject: soc/amd/picasso: Drop _INI method for AZHD device
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/40782/3/src/soc/amd/picasso/acpi/no... 
File src/soc/amd/picasso/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/40782/3/src/soc/amd/picasso/acpi/no... 
PS3, Line 82: 	OperationRegion(AZPD, PCI_Config, 0x00, 0x100)
Please mention that you're dropping the OperationRegion as well

Change in coreboot[master]: soc/amd/picasso: Drop _INI method and OperationRegion for AZHD device

[Furquan Shaikh (Code Review)]

Hello build bot (Jenkins), Paul Menzel, Angel Pons, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40782

to look at the new patch set (#5).

Change subject: soc/amd/picasso: Drop _INI method and OperationRegion for AZHD device
......................................................................

soc/amd/picasso: Drop _INI method and OperationRegion for AZHD device

_INI method for AZHD device for Picasso family was just copied from
Stoneyridge as part of initial change. There is no evidence that this
is required for Picasso. Also, removing the _INI method works
perfectly fine. Thus, this change drops the _INI method for AZHD
device on Picasso.

Since the _INI method was the only entity using the OperationRegion
fields, this change also drops the operation region.

BUG=b:155132752
TEST=Verified that audio still works on Trembyle

Change-Id: If42abf91ee5cd47a881b0a3b4ca1916ea5169261
Signed-off-by: Furquan Shaikh 
---
M src/soc/amd/picasso/acpi/northbridge.asl
1 file changed, 0 insertions(+), 33 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/40782/5

Change in coreboot[master]: soc/amd/picasso: Drop _INI method and OperationRegion for AZHD device

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40782 )

Change subject: soc/amd/picasso: Drop _INI method and OperationRegion for AZHD device
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40782/3/src/soc/amd/picasso/acpi/no... 
File src/soc/amd/picasso/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/40782/3/src/soc/amd/picasso/acpi/no... 
PS3, Line 82: 	OperationRegion(AZPD, PCI_Config, 0x00, 0x100)
> Please mention that you're dropping the OperationRegion as well

Done

Change in coreboot[master]: soc/amd/picasso: Drop _INI method and OperationRegion for AZHD device

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40782 )

Change subject: soc/amd/picasso: Drop _INI method and OperationRegion for AZHD device
......................................................................

soc/amd/picasso: Drop _INI method and OperationRegion for AZHD device

_INI method for AZHD device for Picasso family was just copied from
Stoneyridge as part of initial change. There is no evidence that this
is required for Picasso. Also, removing the _INI method works
perfectly fine. Thus, this change drops the _INI method for AZHD
device on Picasso.

Since the _INI method was the only entity using the OperationRegion
fields, this change also drops the operation region.

BUG=b:155132752
TEST=Verified that audio still works on Trembyle

Change-Id: If42abf91ee5cd47a881b0a3b4ca1916ea5169261
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40782
Reviewed-by: Aaron Durbin 
Reviewed-by: Angel Pons 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/picasso/acpi/northbridge.asl
1 file changed, 0 insertions(+), 33 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Aaron Durbin: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve

diff --git a/src/soc/amd/picasso/acpi/northbridge.asl b/src/soc/amd/picasso/acpi/northbridge.asl
index 6b6bd7c..386556c 100644
--- a/src/soc/amd/picasso/acpi/northbridge.asl
+++ b/src/soc/amd/picasso/acpi/northbridge.asl
@@ -79,37 +79,4 @@

Device(AZHD) {	/* 0:9.2 - HD Audio */
    Name(_ADR, 0x00090002)
-	OperationRegion(AZPD, PCI_Config, 0x00, 0x100)
-		Field(AZPD, AnyAcc, NoLock, Preserve) {
-		offset (0x42),
-		NSDI, 1,
-		NSDO, 1,
-		NSEN, 1,
-		offset (0x44),
-		IPCR, 4,
-		offset (0x54),
-		PWST, 2,
-		, 6,
-		PMEB, 1,
-		, 6,
-		PMST, 1,
-		offset (0x62),
-		MMCR, 1,
-		offset (0x64),
-		MMLA, 32,
-		offset (0x68),
-		MMHA, 32,
-		offset (0x6c),
-		MMDT, 16,
-	}
-
-	Method (_INI, 0, NotSerialized)
-	{
-		If (LEqual (OSVR, 0x03))
-		{
-			Store (Zero, NSEN)
-			Store (One, NSDO)
-			Store (One, NSDI)
-		}
-	}
 } /* end AZHD */