Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49101 )
Change subject: mb/google/lindar: Fix building with CONFIG_CHROMEOS unset ......................................................................
mb/google/lindar: Fix building with CONFIG_CHROMEOS unset
Make CHROMEOS_DSM_CALIB depend on CHROMEOS
Change-Id: I4c3fd04ec00e0787381c58810938dd48f414635c Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/49101/1
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 8777994..491669a 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -22,7 +22,7 @@ select BOARD_GOOGLE_BASEBOARD_VOLTEER select SOC_INTEL_CSE_LITE_SKU select INTEL_CAR_NEM - select CHROMEOS_DSM_CALIB + select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_RT1011
config BOARD_GOOGLE_MALEFOR
Matt DeVillier has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/49101 )
Change subject: mb/google/lindar: Fix building with CONFIG_CHROMEOS unset ......................................................................
mb/google/lindar: Fix building with CONFIG_CHROMEOS unset
Make CHROMEOS_DSM_CALIB depend on CHROMEOS, rather than force selecting it.
Change-Id: I4c3fd04ec00e0787381c58810938dd48f414635c Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/49101/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49101 )
Change subject: mb/google/lindar: Fix building with CONFIG_CHROMEOS unset ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49101 )
Change subject: mb/google/lindar: Fix building with CONFIG_CHROMEOS unset ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49101/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49101/2//COMMIT_MSG@9 PS2, Line 9: force : selecting force-select ?
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49101
to look at the new patch set (#3).
Change subject: mb/google/lindar: Fix building with CONFIG_CHROMEOS unset ......................................................................
mb/google/lindar: Fix building with CONFIG_CHROMEOS unset
Make CHROMEOS_DSM_CALIB depend on CHROMEOS, rather than force-select it.
Change-Id: I4c3fd04ec00e0787381c58810938dd48f414635c Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/49101/3
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49101 )
Change subject: mb/google/lindar: Fix building with CONFIG_CHROMEOS unset ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49101/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49101/2//COMMIT_MSG@9 PS2, Line 9: force : selecting
force-select ?
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49101 )
Change subject: mb/google/lindar: Fix building with CONFIG_CHROMEOS unset ......................................................................
mb/google/lindar: Fix building with CONFIG_CHROMEOS unset
Make CHROMEOS_DSM_CALIB depend on CHROMEOS, rather than force-select it.
Change-Id: I4c3fd04ec00e0787381c58810938dd48f414635c Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49101 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 8777994..491669a 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -22,7 +22,7 @@ select BOARD_GOOGLE_BASEBOARD_VOLTEER select SOC_INTEL_CSE_LITE_SKU select INTEL_CAR_NEM - select CHROMEOS_DSM_CALIB + select CHROMEOS_DSM_CALIB if CHROMEOS select DRIVERS_I2C_RT1011
config BOARD_GOOGLE_MALEFOR
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)