Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30247 )
Change subject: mb/google: Add GPU panel settings for SKL/KBL boards ......................................................................
Patch Set 1:
If the values are generated from vbt, would it be possible to generate them at runtime if a vbt.bin is present ? That way you just add the right VBT and it works out of the box.
Technically, that's doable. But you'd have to maintain VBTs with the correct settings. I just assumed here that these cros devices have the correct settings in their VBT because Linux' i915 would use these values (in theory). But is that generally true? and who is going to write the tool to configure VBT?
Also, our devicetrees are full of values that we could pre-configure in FSP binaries. We don't do that either.