Attention is currently required from: Sean Rhodes, Benjamin Doron, Christian Walter, Maximilian Brune, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74122 )
Change subject: [WIP] mb/prodrive/atlas: Put options in CFR cbtable ......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/prodrive/atlas/cfr.c:
https://review.coreboot.org/c/coreboot/+/74122/comment/64aca694_d4e27d00 PS2, Line 123: .ui_helptext = "Specify what to do when power is re-applied " : "after a power loss. This option has no effect " : "on systems without a RTC battery.", /* TODO: check */ :
The help text is correct, to my knowledge. […]
Will try
File src/mainboard/prodrive/atlas/cfr.c:
https://review.coreboot.org/c/coreboot/+/74122/comment/fea72a0d_e8b0309b PS3, Line 77: .opt_name = "DONOTSTOREME_sn", /* TODO: Make optional? */ Name still needed so that the value can be read.
https://review.coreboot.org/c/coreboot/+/74122/comment/ca703e39_8a112188 PS3, Line 79: .flags = CFR_OPTFLAG_READONLY, Add another flag to indicate an option is volatile.
https://review.coreboot.org/c/coreboot/+/74122/comment/13d4729c_43e8d98c PS3, Line 92: .ui_name = "", /* Empty UI name */ Define new tag for text fields (i.e. "comments"), these do not have an underlying variable but they should still have an option ID for dependencies
-
Angel Pons (Code Review)