[L] Change in coreboot[main]: arch/x86/mmu: Port armv8 MMU to x86_64

[Jérémy Compostella (Code Review)]

Attention is currently required from: Benjamin Doron.

Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79161?usp=email )

Change subject: arch/x86/mmu: Port armv8 MMU to x86_64
......................................................................

Patch Set 1:

(7 comments)

Patchset:

PS1: 
I did not get the chance to go all of it yet but I dropped a few comments.

File src/arch/x86/mmu-ramstage.c:

https://review.coreboot.org/c/coreboot/+/79161/comment/1c214851_cf09669a :
PS1, Line 13: #include <commonlib/region.h>
alphabetical order ?

File src/arch/x86/mmu.c:

https://review.coreboot.org/c/coreboot/+/79161/comment/80431122_54fb470d :
PS1, Line 13: #include <commonlib/region.h>
alphabetical order ?

https://review.coreboot.org/c/coreboot/+/79161/comment/22bb790d_f82cdcda :
PS1, Line 313: GRANULE_SIZE
I am not very familiar with arm but it looks this GRANULE word comes from the ARM work. Shouldn't we use PAGE_SIZE here ?

https://review.coreboot.org/c/coreboot/+/79161/comment/6b561125_219f6fb7 :
PS1, Line 350: 		pages += PDPTs; /* PDPT pointing to 1 GiB PLEs */
the beginning of both branches is identical, can't we take them out of the condition ?

https://review.coreboot.org/c/coreboot/+/79161/comment/a325b7f2_b2252b01 :
PS1, Line 357: 256
define a constant ?

https://review.coreboot.org/c/coreboot/+/79161/comment/e7b94caf_9f017acd :
PS1, Line 364: 4 * KiB
There are a lot of `4 * KiB` in this file, could we create a constant ?