build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28602 )
Change subject: soc/sifive/fu540: Switch clock to 1GHz in romstage ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c File src/soc/sifive/fu540/clock.c:
https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c@209 PS1, Line 209: void static update_peripheral_clock_dividers(void) storage class 'static' should be located before type 'void'
https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c@215 PS1, Line 215: for (size_t i = 0; i < FU540_UART_DEVICES; i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c@216 PS1, Line 216: write32((uint32_t *)(FU540_UART(i) + FU540_UART_REG_DIV), FU540_UART_DIV_VAL); line over 80 characters
https://review.coreboot.org/#/c/28602/1/src/soc/sifive/fu540/clock.c@224 PS1, Line 224: * values as we can't put them in reset before changing frequency. code indent should use tabs where possible
-
build bot (Jenkins) (Code Review)