Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34808 )
Change subject: cpu/intel: Refactor platform_enter_postcar() ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34808/2/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34808/2/src/cpu/intel/car/romstage.... PS2, Line 69: run_postcar_phase(&early_mtrrs);
Done
My point was that romstage being linked to use globals could no longer be used when reentering if the cache values are transient. It's not just about wbinvd. It's a very very subtle situation that I think won't play out correctly for all platforms/devices.
Yes, I agree the speedup is not really worth it unless things work 100% of the time for everyone. If it doesn't work 100% of the time then -the pursuit of adding to MTRR solution for ramstage loading can be dropped. postcar being small inherently allowed a load to uncacheable memory to not be that bad.
-
Aaron Durbin (Code Review)