Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80794?usp=email )
Change subject: soc/intel/xeon_sp: Add ACPI names
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/xeon_sp/acpi.c:
https://review.coreboot.org/c/coreboot/+/80794/comment/f750f375_b636f5d1 :
PS2, Line 144: char *name = xmalloc(ACPI_NAME_BUFFER_SIZE);
I could squash this with Ic4cc81d198fb88300394055682a3954bf22db570 and generate the proper ACPI name […]
From a reader point of view, handling among multiple names, a.k.a. device->name, and acpi_name ..., are somewhat confusing. Maybe we can add a new field 'tag' to struct device. This field could be defined for device specific usage (just like the resource->index).
For IIO domains devices, we can use the device->tag to hold the domain type. While for device->name, we can use it for acpi names. We can xmalloc at the 1st reference but read the values for subsequent references after the name is created.
What about this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80794?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4353db33e7ac98db41728bcf61ee01e21433dded
Gerrit-Change-Number: 80794
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Fri, 01 Mar 2024 09:28:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment