DaLao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: Signed-off-by: dalao dalao@tutanota.com ......................................................................
Signed-off-by: dalao dalao@tutanota.com
src/mainboard/lenovo: Use the original lenovo hardware id for touchpad
Currently the coreboot's touchpad hardware id is different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't automatically be matched and installed through Windows Update. On Linux, there also maybe some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware id for each model than the PNP-id. By searching for dmesg logs, I found the following hardware ids for these thinkpad models:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: ? T420: ? T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: ? T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... T430s: ? T530: ?
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Then I made several copies of the ps2_controller.asl changed the superio.asl to include their correct ones. Then reboot to Windows and the touchpad driver is automatically installed. Done. But I still have some querstions: 1, Is making copies of the ps2_controller.asl a good way? Are there any better methods for doing this? 2, Is there any website that collect dmesg logs so I can search the hardware ids? 3, The keyboard's hardware id maybe different like the touchpad as well. But they are working ok, so I haven't looked into it.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 --- A src/drivers/pc80/pc/ps2_controller_len0015.asl A src/drivers/pc80/pc/ps2_controller_len0020.asl A src/drivers/pc80/pc/ps2_controller_len0036.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 12 files changed, 145 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/1
diff --git a/src/drivers/pc80/pc/ps2_controller_len0015.asl b/src/drivers/pc80/pc/ps2_controller_len0015.asl new file mode 100644 index 0000000..750b24f --- /dev/null +++ b/src/drivers/pc80/pc/ps2_controller_len0015.asl @@ -0,0 +1,46 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + Device (PS2K) // Keyboard + { + Name(_HID, EISAID("PNP0303")) + Name(_CID, EISAID("PNP030B")) + + Name(_CRS, ResourceTemplate() + { + IO (Decode16, 0x60, 0x60, 0x01, 0x01) + IO (Decode16, 0x64, 0x64, 0x01, 0x01) + IRQ (Edge, ActiveHigh, Exclusive) { 0x01 } // IRQ 1 + }) + + Method (_STA, 0) + { + Return (0xf) + } + } + + Device (PS2M) // Mouse + { + Name(_HID, EISAID("LEN0015")) + Name(_CID, EISAID("PNP0F13")) + + Name(_CRS, ResourceTemplate() + { + IRQ (Edge, ActiveHigh, Exclusive) { 0x0c } // IRQ 12 + }) + + Method(_STA, 0) + { + Return (0xf) + } + } diff --git a/src/drivers/pc80/pc/ps2_controller_len0020.asl b/src/drivers/pc80/pc/ps2_controller_len0020.asl new file mode 100644 index 0000000..ba476a6 --- /dev/null +++ b/src/drivers/pc80/pc/ps2_controller_len0020.asl @@ -0,0 +1,45 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + Device (PS2K) // Keyboard + { + Name(_HID, EISAID("PNP0303")) + Name(_CID, EISAID("PNP030B")) + + Name(_CRS, ResourceTemplate() + { + IO (Decode16, 0x60, 0x60, 0x01, 0x01) + IO (Decode16, 0x64, 0x64, 0x01, 0x01) + IRQ (Edge, ActiveHigh, Exclusive) { 0x01 } // IRQ 1 + }) + + Method (_STA, 0) + { + Return (0xf) + } + } + + Device (PS2M) // Mouse + { + Name(_HID, EISAID("LEN0020")) + Name(_CID, EISAID("PNP0F13")) + Name(_CRS, ResourceTemplate() + { + IRQ (Edge, ActiveHigh, Exclusive) { 0x0c } // IRQ 12 + }) + + Method(_STA, 0) + { + Return (0xf) + } + } diff --git a/src/drivers/pc80/pc/ps2_controller_len0036.asl b/src/drivers/pc80/pc/ps2_controller_len0036.asl new file mode 100644 index 0000000..4b10381 --- /dev/null +++ b/src/drivers/pc80/pc/ps2_controller_len0036.asl @@ -0,0 +1,45 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + Device (PS2K) // Keyboard + { + Name(_HID, EISAID("PNP0303")) + Name(_CID, EISAID("PNP030B")) + + Name(_CRS, ResourceTemplate() + { + IO (Decode16, 0x60, 0x60, 0x01, 0x01) + IO (Decode16, 0x64, 0x64, 0x01, 0x01) + IRQ (Edge, ActiveHigh, Exclusive) { 0x01 } // IRQ 1 + }) + + Method (_STA, 0) + { + Return (0xf) + } + } + + Device (PS2M) // Mouse + { + Name(_HID, EISAID("LEN0036")) + Name(_CID, EISAID("PNP0F13")) + Name(_CRS, ResourceTemplate() + { + IRQ (Edge, ActiveHigh, Exclusive) { 0x0c } // IRQ 12 + }) + + Method(_STA, 0) + { + Return (0xf) + } + } diff --git a/src/mainboard/lenovo/t410/acpi/superio.asl b/src/mainboard/lenovo/t410/acpi/superio.asl index f2b35ba..24afccc 100644 --- a/src/mainboard/lenovo/t410/acpi/superio.asl +++ b/src/mainboard/lenovo/t410/acpi/superio.asl @@ -1 +1 @@ -#include <drivers/pc80/pc/ps2_controller.asl> +#include <drivers/pc80/pc/ps2_controller_len0015.asl> diff --git a/src/mainboard/lenovo/t420/acpi/superio.asl b/src/mainboard/lenovo/t420/acpi/superio.asl index f2b35ba..24afccc 100644 --- a/src/mainboard/lenovo/t420/acpi/superio.asl +++ b/src/mainboard/lenovo/t420/acpi/superio.asl @@ -1 +1 @@ -#include <drivers/pc80/pc/ps2_controller.asl> +#include <drivers/pc80/pc/ps2_controller_len0015.asl> diff --git a/src/mainboard/lenovo/t420s/acpi/superio.asl b/src/mainboard/lenovo/t420s/acpi/superio.asl index f2b35ba..24afccc 100644 --- a/src/mainboard/lenovo/t420s/acpi/superio.asl +++ b/src/mainboard/lenovo/t420s/acpi/superio.asl @@ -1 +1 @@ -#include <drivers/pc80/pc/ps2_controller.asl> +#include <drivers/pc80/pc/ps2_controller_len0015.asl> diff --git a/src/mainboard/lenovo/t430/acpi/superio.asl b/src/mainboard/lenovo/t430/acpi/superio.asl index 8964c36..4ba8af3 100644 --- a/src/mainboard/lenovo/t430/acpi/superio.asl +++ b/src/mainboard/lenovo/t430/acpi/superio.asl @@ -13,4 +13,4 @@ * GNU General Public License for more details. */
-#include <drivers/pc80/pc/ps2_controller.asl> +#include <drivers/pc80/pc/ps2_controller_len0015.asl> diff --git a/src/mainboard/lenovo/t430s/acpi/superio.asl b/src/mainboard/lenovo/t430s/acpi/superio.asl index f2b35ba..24afccc 100644 --- a/src/mainboard/lenovo/t430s/acpi/superio.asl +++ b/src/mainboard/lenovo/t430s/acpi/superio.asl @@ -1 +1 @@ -#include <drivers/pc80/pc/ps2_controller.asl> +#include <drivers/pc80/pc/ps2_controller_len0015.asl> diff --git a/src/mainboard/lenovo/t520/acpi/superio.asl b/src/mainboard/lenovo/t520/acpi/superio.asl index f2b35ba..24afccc 100644 --- a/src/mainboard/lenovo/t520/acpi/superio.asl +++ b/src/mainboard/lenovo/t520/acpi/superio.asl @@ -1 +1 @@ -#include <drivers/pc80/pc/ps2_controller.asl> +#include <drivers/pc80/pc/ps2_controller_len0015.asl> diff --git a/src/mainboard/lenovo/t530/acpi/superio.asl b/src/mainboard/lenovo/t530/acpi/superio.asl index f2b35ba..24afccc 100644 --- a/src/mainboard/lenovo/t530/acpi/superio.asl +++ b/src/mainboard/lenovo/t530/acpi/superio.asl @@ -1 +1 @@ -#include <drivers/pc80/pc/ps2_controller.asl> +#include <drivers/pc80/pc/ps2_controller_len0015.asl> diff --git a/src/mainboard/lenovo/x220/acpi/superio.asl b/src/mainboard/lenovo/x220/acpi/superio.asl index f2b35ba..069cdea 100644 --- a/src/mainboard/lenovo/x220/acpi/superio.asl +++ b/src/mainboard/lenovo/x220/acpi/superio.asl @@ -1 +1 @@ -#include <drivers/pc80/pc/ps2_controller.asl> +#include <drivers/pc80/pc/ps2_controller_len0020.asl> diff --git a/src/mainboard/lenovo/x230/acpi/superio.asl b/src/mainboard/lenovo/x230/acpi/superio.asl index f2b35ba..069cdea 100644 --- a/src/mainboard/lenovo/x230/acpi/superio.asl +++ b/src/mainboard/lenovo/x230/acpi/superio.asl @@ -1 +1 @@ -#include <drivers/pc80/pc/ps2_controller.asl> +#include <drivers/pc80/pc/ps2_controller_len0020.asl>
Hello Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#2).
Change subject: src/mainboard/lenovo: Use the original lenovo hardware id for touchpad ......................................................................
src/mainboard/lenovo: Use the original lenovo hardware id for touchpad
Currently the coreboot's touchpad hardware id is different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't automatically be matched and installed through Windows Update. On Linux, there also maybe some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware id for each model than the PNP-id. By searching for dmesg logs, I found the following hardware ids for these thinkpad models:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: ? T420: ? T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: ? T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... T430s: ? T530: ?
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Then I made several copies of the ps2_controller.asl changed the superio.asl to include their correct ones. Then reboot to Windows and the touchpad driver is automatically installed. Done. But I still have some querstions: 1, Is making copies of the ps2_controller.asl a good way? Are there any better methods for doing this? 2, Is there any website that collect dmesg logs so I can search the hardware ids? 3, The keyboard's hardware id maybe different like the touchpad as well. But they are working ok, so I haven't looked into it.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 --- A src/drivers/pc80/pc/ps2_controller_len0015.asl A src/drivers/pc80/pc/ps2_controller_len0020.asl A src/drivers/pc80/pc/ps2_controller_len0036.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 12 files changed, 145 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/2
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#3).
Change subject: src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad
Currently the coreboot's touchpad hardware ids are different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware ids for each model than the PNP-ids. By searching for dmesg logs, I found the following hardware ids for these thinkpad models:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: ? T420: ? T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: ? T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... T430s: ? T530: ?
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Then I made several copies of the ps2_controller.asl changed the superio.asl to include their correct ones. Then reboot to Windows and the touchpad driver is automatically installed. Done. But I still have some questions: 1, Is making copies of the ps2_controller.asl a good way? Are there any better methods for doing this? 2, Is there any website that collect dmesg logs so I can search the hardware ids? 3, The keyboard's hardware id maybe different like the touchpad as well. But they are working well, so I haven't looked into it. 4, What should we do for other brands like HP?
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 --- A src/drivers/pc80/pc/ps2_controller_len0015.asl A src/drivers/pc80/pc/ps2_controller_len0020.asl A src/drivers/pc80/pc/ps2_controller_len0036.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 12 files changed, 145 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/3
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#4).
Change subject: src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad
Currently the coreboot's touchpad hardware ids are different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware ids for each model than the PNP-ids. By searching for dmesg logs, I found the following hardware ids for these thinkpad models:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: ? T420: ? T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: ? T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... T430s: ? T530: ?
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Then I made several copies of the ps2_controller.asl changed the superio.asl to include their correct ones. Then reboot to Windows and the touchpad driver is automatically installed. Done. But I still have some questions: 1, Is making copies of the ps2_controller.asl a good way? Are there any better methods for doing this? 2, Is there any website that collect dmesg logs so I can search the hardware ids? 3, The keyboard's hardware id maybe different like the touchpad as well. But they are working well, so I haven't looked into it. 4, What should we do for other brands like HP?
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com --- A src/drivers/pc80/pc/ps2_controller_len0015.asl A src/drivers/pc80/pc/ps2_controller_len0020.asl A src/drivers/pc80/pc/ps2_controller_len0036.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 12 files changed, 145 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/4
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#5).
Change subject: src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad
Currently the coreboot's touchpad hardware ids are different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware ids for each model than the PNP-ids. By searching for dmesg logs, I found the following hardware ids for these thinkpad models:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: ? T420: ? T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: ? T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... T430s: ? T530: ?
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Then I made changes to the ps2_controller.asl and the superio.asl to include their correct ones. Then reboot to Windows and the touchpad driver is automatically installed. Done. But I still have some questions: 1, Is making copies of the ps2_controller.asl a good way? Are there any better methods for doing this? 2, Is there any website that collect dmesg logs so I can search the hardware ids? 3, The keyboard's hardware id maybe different like the touchpad as well. But they are working well, so I haven't looked into it. 4, What should we do for other brands like HP?
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com --- M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 10 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/5
Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#6).
Change subject: src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad
Currently the coreboot's touchpad hardware ids are different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware ids for each model than the PNP-ids. By searching for dmesg logs, I found the following hardware ids for these thinkpad models:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: https://forum.ubuntuusers.de/topic/kein-sound-109/ T420: https://bugzilla.kernel.org/show_bug.cgi?id=42593 T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: https://bbs.archlinux.org/viewtopic.php?id=195636 T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... T430s: ? T530: https://forums.fedoraforum.org/showthread.php?316640-Fedora-27-High-CPU
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0034: T540p: https://bugzilla.kernel.org/show_bug.cgi?id=91541
LEN0035: X240: https://bugzilla.kernel.org/show_bug.cgi?id=91541
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541 T440p: https://bugzilla.kernel.org/show_bug.cgi?id=91541 T440s: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Then I made changes to the ps2_controller.asl and the superio.asl to include their correct ones. Then reboot to Windows and the touchpad driver is automatically installed. Done. But I still have some questions: 1, Is making copies of the ps2_controller.asl a good way? Are there any better methods for doing this? 2, Is there any website that collect dmesg logs so I can search the hardware ids? 3, The keyboard's hardware id maybe different like the touchpad as well. But they are working well, so I haven't looked into it. 4, What should we do for other brands like HP?
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com --- M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 10 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/6
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
Patch Set 6: Code-Review+1
Iru Cai (vimacs) has uploaded a new patch set (#7) to the change originally created by DaLao. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad
Currently the coreboot's touchpad hardware ids are different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware ids for each model than the PNP-ids. By searching for dmesg logs, I found the following hardware ids for these thinkpad models:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: https://forum.ubuntuusers.de/topic/kein-sound-109/ T420: https://bugzilla.kernel.org/show_bug.cgi?id=42593 T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: https://bbs.archlinux.org/viewtopic.php?id=195636 T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... T430s: ? T530: https://forums.fedoraforum.org/showthread.php?316640-Fedora-27-High-CPU
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0034: T540p: https://bugzilla.kernel.org/show_bug.cgi?id=91541
LEN0035: X240: https://bugzilla.kernel.org/show_bug.cgi?id=91541
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541 T440p: https://bugzilla.kernel.org/show_bug.cgi?id=91541 T440s: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Then I made changes to the ps2_controller.asl and the superio.asl to include their correct ones. Then reboot to Windows and the touchpad driver is automatically installed. Done. But I still have some questions: 1, Is making copies of the ps2_controller.asl a good way? Are there any better methods for doing this? 2, Is there any website that collect dmesg logs so I can search the hardware ids? 3, The keyboard's hardware id maybe different like the touchpad as well. But they are working well, so I haven't looked into it. 4, What should we do for other brands like HP?
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com Signed-off-by: Iru Cai mytbk920423@gmail.com --- M Documentation/mainboard/lenovo/t440p.md M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t440p/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 12 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/7
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
Patch Set 7: Code-Review+1
Iru Cai (vimacs) has uploaded a new patch set (#8) to the change originally created by DaLao. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
mainboard/lenovo: Use the original lenovo hardware ids for touchpad
Currently the coreboot's touchpad hardware ids are different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware ids for each model than the PNP-ids.
The hardware ids for the following ThinkPad models can be found By searching for dmesg logs:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: https://forum.ubuntuusers.de/topic/kein-sound-109/ T420: https://bugzilla.kernel.org/show_bug.cgi?id=42593 T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: https://bbs.archlinux.org/viewtopic.php?id=195636 T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... T430s: ? T530: https://forums.fedoraforum.org/showthread.php?316640-Fedora-27-High-CPU
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0034: T540p: https://bugzilla.kernel.org/show_bug.cgi?id=91541
LEN0035: X240: https://bugzilla.kernel.org/show_bug.cgi?id=91541
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541 T440p: https://bugzilla.kernel.org/show_bug.cgi?id=91541 T440s: https://bugzilla.kernel.org/show_bug.cgi?id=91541
This can make Windows automatically install the Lenovo touchpad driver. It also fixes the T440p touchpad issue.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com Signed-off-by: Iru Cai mytbk920423@gmail.com --- M Documentation/mainboard/lenovo/t440p.md M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t440p/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 12 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/8
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36371/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36371/8//COMMIT_MSG@9 PS8, Line 9: Currently the coreboot's touchpad hardware ids are different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware ids for each model than the PNP-ids. : : The hardware ids for the following ThinkPad models can be found By searching for dmesg logs: Please re-flow for 72/75 characters.
https://review.coreboot.org/c/coreboot/+/36371/8//COMMIT_MSG@12 PS8, Line 12: What is the ID coreboot assigns?
Iru Cai (vimacs) has uploaded a new patch set (#9) to the change originally created by DaLao. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
mainboard/lenovo: Use the original lenovo hardware ids for touchpad
Currently coreboot is using the compatible ID PNP0F13 for all pointing devices, which causes some problems on Lenovo ThinkPads. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware IDs for each model.
The hardware IDs for the following ThinkPad models can be found By searching for dmesg logs:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: https://forum.ubuntuusers.de/topic/kein-sound-109/ T420: https://bugzilla.kernel.org/show_bug.cgi?id=42593 T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: https://bbs.archlinux.org/viewtopic.php?id=195636 T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/ 2347ds2/lenovo/g1et73ww-2.09/fwts/20160218_174223/dmesg.log T430s: ? T530: https://forums.fedoraforum.org/showthread.php? 316640-Fedora-27-High-CPU
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0034: T540p: https://bugzilla.kernel.org/show_bug.cgi?id=91541
LEN0035: X240: https://bugzilla.kernel.org/show_bug.cgi?id=91541
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541 T440p: https://bugzilla.kernel.org/show_bug.cgi?id=91541 T440s: https://bugzilla.kernel.org/show_bug.cgi?id=91541
This can make Windows automatically install the Lenovo touchpad driver. It also fixes the T440p touchpad issue.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com Signed-off-by: Iru Cai mytbk920423@gmail.com --- M Documentation/mainboard/lenovo/t440p.md M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t440p/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 12 files changed, 15 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/9
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36371/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36371/8//COMMIT_MSG@9 PS8, Line 9: Currently the coreboot's touchpad hardware ids are different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware ids for each model than the PNP-ids. : : The hardware ids for the following ThinkPad models can be found By searching for dmesg logs:
Please re-flow for 72/75 characters.
Done
https://review.coreboot.org/c/coreboot/+/36371/8//COMMIT_MSG@12 PS8, Line 12:
What is the ID coreboot assigns?
PNP0F13 for all PS/2 mouse and touchpad
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
Patch Set 9:
Would it be better to move these values into Kconfig or devicetree?
Prasun Gera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
Patch Set 9:
I used to have a w530, but I have since converted it to a T530 with a motherboard swap. However, I believe that w530 should also use the same ids. https://bugs.freedesktop.org/attachment.cgi?id=115557 suggests so.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph, Iru Cai, Iru Cai (vimacs),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#10).
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
mainboard/lenovo: Use the original hardware ids for keyboard/pointing
Currently coreboot is using the compatible ID PNP0303 for all keyboards and PNP0F13 for all pointing devices, which causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there are some strange issues. So it's better to use the original hardware IDs for each model. The hardware IDs for the following models can be found By searching for dmesg logs on vendor BIOS:
T60: https://mail.gnome.org/archives/networkmanager-list/2012-January/ msg00110.html Keyboard: PNP0303 Pointing: IBM0057
R60: https://openbenchmarking.org/system/1202279-AR-COMPRESS715/Lenovo%20R60/ dmesg Keyboard: PNP0303 Pointing: IBM0057
X60: https://github.com/pavelmachek/missy/blob/master/db/notebook/lenovo/ thinkpad/x60/pavel/2018.3648803539788/dmesg.out Keyboard: PNP0303 Pointing: IBM3780
X200: https://ubuntuforums.org/showthread.php?t=1833248&page=2 Keyboard: LEN0010 Pointing: IBM3780
T400: https://github.com/heradon/libreboot-fork/blob/master/docs/future/ dumps/logs-t400-bios2.02-ec1.01/dmesg.log Keyboard: LEN0010 Pointing: IBM3780
T510: https://bbs.archlinux.org/viewtopic.php?id=120287 Keyboard: PNP0303 Pointing: LEN0015
T410: https://forum.ubuntuusers.de/topic/kein-sound-109/ Keyboard: PNP0303 Pointing: LEN0015
T420: https://linux-hardware.org/index.php?probe=e6a094ade5&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 Keyboard: PNP0303 Pointing: LEN0015
T520: https://bbs.archlinux.org/viewtopic.php?id=195636 Keyboard: PNP0303 Pointing: LEN0015
W520: https://linux-hardware.org/index.php?probe=9306cac54c&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/ 2347ds2/lenovo/g1et73ww-2.09/fwts/20160218_174223/dmesg.log Keyboard: PNP0303 Pointing: LEN0015
T430s: https://linux-hardware.org/index.php?probe=01545dc8fb&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T530: https://forums.fedoraforum.org/showthread.php? 316640-Fedora-27-High-CPU Keyboard: LEN0071 Pointing: LEN0015
W530: https://bugs.freedesktop.org/attachment.cgi?id=115557 Keyboard: LEN0071 Pointing: LEN0015
L520: https://pastebin.com/U6MaBAY3 Keyboard: PNP0303 Pointing: LEN0017
X201: https://linux-hardware.org/index.php?probe=d7085ee4c8&log=dmesg.1 Keyboard: PNP0303 Pointing: LEN0018
X220: https://bbs.archlinux.org/viewtopic.php?id=237669 Keyboard: PNP0303 Pointing: LEN0020
X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460 Keyboard: PNP0303 Pointing: LEN0020
X131e: https://linux-hardware.org/index.php?probe=d765880811&log=dmesg Keyboard: MSF0001 Pointing: LEN0026
X1 Carbon Gen 1: https://bugzilla.kernel.org/show_bug.cgi?id=85851 Keyboard: LEN0071 Pointing: LEN0030
s230u: https://launchpadlibrarian.net/147231958/dmesg-reboot.txt Keyboard: PTL0001 Pointing: LEN0031
T540p: https://linux-hardware.org/index.php?probe=da766a30bc&log=dmesg Keyboard: LEN0071 Pointing: LEN0034
X240: https://linux-hardware.org/index.php?probe=fa7155b0e4&log=dmesg Keyboard: LEN0071 Pointing: LEN0035
T440p: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T440s: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN200e
Others: https://github.com/torvalds/linux/blob/master/drivers/input/mouse/ synaptics.c
Test result: This can make Windows automatically install the Lenovo touchpad driver. It also fixes the T440p touchpad issue.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com Signed-off-by: Iru Cai mytbk920423@gmail.com --- M Documentation/mainboard/lenovo/t440p.md M src/drivers/pc80/pc/Kconfig M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t400/Kconfig M src/mainboard/lenovo/t410/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x200/Kconfig M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x60/Kconfig 22 files changed, 182 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/10
DaLao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
Patch Set 10:
Patch Set 9:
Would it be better to move these values into Kconfig or devicetree?
Done, these values have been moved into Kconfig.
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
Patch Set 11: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
Patch Set 11:
(3 comments)
Looks like a good solution, thank you! Only some Kconfig nits...
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... File src/drivers/pc80/pc/Kconfig:
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... PS11, Line 24: "PS2 Keyboard ID" Why give it a prompt? If the default gives somebody trouble, IMO, the correct numbers should be added upstream, just like you do it here.
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... PS11, Line 33: dmesg logs on vendor BIOS. No idea, why you repeat the commit message here. Please describe the solution, not the (past) problem. A single line could be enough, e.g.
Mainboards can override the default to match vendor drivers and quirks.
https://review.coreboot.org/c/coreboot/+/36371/11/src/mainboard/lenovo/l520/... File src/mainboard/lenovo/l520/Kconfig:
https://review.coreboot.org/c/coreboot/+/36371/11/src/mainboard/lenovo/l520/... PS11, Line 50: string You don't have to mention the type everytime, mainboards should just override the default value.
Hello build bot (Jenkins), Peter Lemenkov, Alexander Couzens, Patrick Rudolph, Iru Cai, Iru Cai (vimacs),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#12).
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
mainboard/lenovo: Use the original hardware ids for keyboard/pointing
Currently coreboot is using the compatible ID PNP0303 for all keyboards and PNP0F13 for all pointing devices, which causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there are some strange issues. So it's better to use the original hardware IDs for each model. The hardware IDs for the following models can be found By searching for dmesg logs on vendor BIOS:
T60: https://mail.gnome.org/archives/networkmanager-list/2012-January/ msg00110.html Keyboard: PNP0303 Pointing: IBM0057
R60: https://openbenchmarking.org/system/1202279-AR-COMPRESS715/Lenovo%20R60/ dmesg Keyboard: PNP0303 Pointing: IBM0057
X60: https://github.com/pavelmachek/missy/blob/master/db/notebook/ lenovo/thinkpad/x60/pavel/2018.3648803539788/dmesg.out Keyboard: PNP0303 Pointing: IBM3780
X200: https://ubuntuforums.org/showthread.php?t=1833248&page=2 Keyboard: LEN0010 Pointing: IBM3780
T400: https://github.com/heradon/libreboot-fork/blob/master/docs/future/ dumps/logs-t400-bios2.02-ec1.01/dmesg.log Keyboard: LEN0010 Pointing: IBM3780
T510: https://bbs.archlinux.org/viewtopic.php?id=120287 Keyboard: PNP0303 Pointing: LEN0015
T410: https://forum.ubuntuusers.de/topic/kein-sound-109/ Keyboard: PNP0303 Pointing: LEN0015
T420: https://linux-hardware.org/index.php?probe=e6a094ade5&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 Keyboard: PNP0303 Pointing: LEN0015
T520: https://bbs.archlinux.org/viewtopic.php?id=195636 Keyboard: PNP0303 Pointing: LEN0015
W520: https://linux-hardware.org/index.php?probe=9306cac54c&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/ 2347ds2/lenovo/g1et73ww-2.09/fwts/20160218_174223/dmesg.log Keyboard: PNP0303 Pointing: LEN0015
T430s: https://linux-hardware.org/index.php?probe=01545dc8fb&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T530: https://forums.fedoraforum.org/showthread.php? 316640-Fedora-27-High-CPU Keyboard: LEN0071 Pointing: LEN0015
W530: https://bugs.freedesktop.org/attachment.cgi?id=115557 Keyboard: LEN0071 Pointing: LEN0015
L520: https://pastebin.com/U6MaBAY3 Keyboard: PNP0303 Pointing: LEN0017
X201: https://linux-hardware.org/index.php?probe=d7085ee4c8&log=dmesg.1 Keyboard: PNP0303 Pointing: LEN0018
X220: https://bbs.archlinux.org/viewtopic.php?id=237669 Keyboard: PNP0303 Pointing: LEN0020
X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460 Keyboard: PNP0303 Pointing: LEN0020
X131e: https://linux-hardware.org/index.php?probe=d765880811&log=dmesg Keyboard: MSF0001 Pointing: LEN0026
X1 Carbon Gen 1: https://bugzilla.kernel.org/show_bug.cgi?id=85851 Keyboard: LEN0071 Pointing: LEN0030
s230u: https://launchpadlibrarian.net/147231958/dmesg-reboot.txt Keyboard: PTL0001 Pointing: LEN0031
T540p: https://linux-hardware.org/index.php?probe=da766a30bc&log=dmesg Keyboard: LEN0071 Pointing: LEN0034
X240: https://linux-hardware.org/index.php?probe=fa7155b0e4&log=dmesg Keyboard: LEN0071 Pointing: LEN0035
T440p: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T440s: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN200e
Others: https://github.com/torvalds/linux/blob/master/drivers/input/mouse/ synaptics.c
Test result: This can make Windows automatically install the Lenovo touchpad driver. It also fixes the T440p touchpad issue.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com Signed-off-by: Iru Cai mytbk920423@gmail.com --- M Documentation/mainboard/lenovo/t440p.md M src/drivers/pc80/pc/Kconfig M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t400/Kconfig M src/mainboard/lenovo/t410/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x200/Kconfig M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x60/Kconfig 22 files changed, 132 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/12
Hello build bot (Jenkins), Peter Lemenkov, Alexander Couzens, Patrick Rudolph, Iru Cai, Iru Cai (vimacs),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#13).
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
mainboard/lenovo: Use the original hardware ids for keyboard/pointing
Currently coreboot is using the compatible ID PNP0303 for all keyboards and PNP0F13 for all pointing devices, which causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there are some strange issues. So it's better to use the original hardware IDs for each model. The hardware IDs for the following models can be found By searching for dmesg logs on vendor BIOS:
T60: https://mail.gnome.org/archives/networkmanager-list/2012-January/ msg00110.html Keyboard: PNP0303 Pointing: IBM0057
R60: https://openbenchmarking.org/system/1202279-AR-COMPRESS715/Lenovo%20R60/ dmesg Keyboard: PNP0303 Pointing: IBM0057
X60: https://github.com/pavelmachek/missy/blob/master/db/notebook/ lenovo/thinkpad/x60/pavel/2018.3648803539788/dmesg.out Keyboard: PNP0303 Pointing: IBM3780
X200: https://ubuntuforums.org/showthread.php?t=1833248&page=2 Keyboard: LEN0010 Pointing: IBM3780
T400: https://github.com/heradon/libreboot-fork/blob/master/docs/future/ dumps/logs-t400-bios2.02-ec1.01/dmesg.log Keyboard: LEN0010 Pointing: IBM3780
T510: https://bbs.archlinux.org/viewtopic.php?id=120287 Keyboard: PNP0303 Pointing: LEN0015
T410: https://forum.ubuntuusers.de/topic/kein-sound-109/ Keyboard: PNP0303 Pointing: LEN0015
T420: https://linux-hardware.org/index.php?probe=e6a094ade5&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 Keyboard: PNP0303 Pointing: LEN0015
T520: https://bbs.archlinux.org/viewtopic.php?id=195636 Keyboard: PNP0303 Pointing: LEN0015
W520: https://linux-hardware.org/index.php?probe=9306cac54c&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/ 2347ds2/lenovo/g1et73ww-2.09/fwts/20160218_174223/dmesg.log Keyboard: PNP0303 Pointing: LEN0015
T430s: https://linux-hardware.org/index.php?probe=01545dc8fb&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T530: https://forums.fedoraforum.org/showthread.php? 316640-Fedora-27-High-CPU Keyboard: LEN0071 Pointing: LEN0015
W530: https://bugs.freedesktop.org/attachment.cgi?id=115557 Keyboard: LEN0071 Pointing: LEN0015
L520: https://pastebin.com/U6MaBAY3 Keyboard: PNP0303 Pointing: LEN0017
X201: https://linux-hardware.org/index.php?probe=d7085ee4c8&log=dmesg.1 Keyboard: PNP0303 Pointing: LEN0018
X220: https://bbs.archlinux.org/viewtopic.php?id=237669 Keyboard: PNP0303 Pointing: LEN0020
X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460 Keyboard: PNP0303 Pointing: LEN0020
X131e: https://linux-hardware.org/index.php?probe=d765880811&log=dmesg Keyboard: MSF0001 Pointing: LEN0026
X1 Carbon Gen 1: https://bugzilla.kernel.org/show_bug.cgi?id=85851 Keyboard: LEN0071 Pointing: LEN0030
s230u: https://launchpadlibrarian.net/147231958/dmesg-reboot.txt Keyboard: PTL0001 Pointing: LEN0031
T540p: https://linux-hardware.org/index.php?probe=da766a30bc&log=dmesg Keyboard: LEN0071 Pointing: LEN0034
X240: https://linux-hardware.org/index.php?probe=fa7155b0e4&log=dmesg Keyboard: LEN0071 Pointing: LEN0035
T440p: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T440s: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T450: https://gist.github.com/kzar/1c38630eb22e4bf5b976 Keyboard: LEN0071 Pointing: LEN200e
Others: https://github.com/torvalds/linux/blob/master/drivers/input/mouse/ synaptics.c
Test result: This can make Windows automatically install the Lenovo touchpad driver. It also fixes the T440p touchpad issue.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com Signed-off-by: Iru Cai mytbk920423@gmail.com --- M Documentation/mainboard/lenovo/t440p.md M src/drivers/pc80/pc/Kconfig M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t400/Kconfig M src/mainboard/lenovo/t410/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x200/Kconfig M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x60/Kconfig 22 files changed, 132 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/13
DaLao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
Patch Set 13:
(3 comments)
Patch Set 11:
(3 comments)
Looks like a good solution, thank you! Only some Kconfig nits...
Thank you, the nits have been fixed.
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... File src/drivers/pc80/pc/Kconfig:
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... PS11, Line 24: "PS2 Keyboard ID"
Why give it a prompt? If the default gives somebody trouble, IMO, the […]
Done
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... PS11, Line 33: dmesg logs on vendor BIOS.
No idea, why you repeat the commit message here. Please describe the […]
Done
https://review.coreboot.org/c/coreboot/+/36371/11/src/mainboard/lenovo/l520/... File src/mainboard/lenovo/l520/Kconfig:
https://review.coreboot.org/c/coreboot/+/36371/11/src/mainboard/lenovo/l520/... PS11, Line 50: string
You don't have to mention the type everytime, mainboards should just override […]
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
Patch Set 13: Code-Review+2
(3 comments)
Only just noticed: Please don't break URLs in the commit message.
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... File src/drivers/pc80/pc/Kconfig:
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... PS11, Line 24: "PS2 Keyboard ID"
Why give it a prompt? If the default gives somebody trouble, IMO, the […]
Done
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... PS11, Line 33: dmesg logs on vendor BIOS.
No idea, why you repeat the commit message here. Please describe the […]
Done
https://review.coreboot.org/c/coreboot/+/36371/11/src/mainboard/lenovo/l520/... File src/mainboard/lenovo/l520/Kconfig:
https://review.coreboot.org/c/coreboot/+/36371/11/src/mainboard/lenovo/l520/... PS11, Line 50: string
You don't have to mention the type everytime, mainboards should just override […]
Done
Hello build bot (Jenkins), Nico Huber, Peter Lemenkov, Alexander Couzens, Patrick Rudolph, Iru Cai, Iru Cai (vimacs),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#14).
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
mainboard/lenovo: Use the original hardware ids for keyboard/pointing
Currently coreboot is using the compatible ID PNP0303 for all keyboards and PNP0F13 for all pointing devices, which causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there are some strange issues. So it's better to use the original hardware IDs for each model. The hardware IDs for the following models can be found By searching for dmesg logs on vendor BIOS:
T60: https://mail.gnome.org/archives/networkmanager-list/2012-January/msg00110.ht... Keyboard: PNP0303 Pointing: IBM0057
R60: https://openbenchmarking.org/system/1202279-AR-COMPRESS715/Lenovo%20R60/dmes... Keyboard: PNP0303 Pointing: IBM0057
X60: https://github.com/pavelmachek/missy/blob/master/db/notebook/lenovo/thinkpad... Keyboard: PNP0303 Pointing: IBM3780
X200: https://ubuntuforums.org/showthread.php?t=1833248&page=2 Keyboard: LEN0010 Pointing: IBM3780
T400: https://github.com/heradon/libreboot-fork/blob/master/docs/future/dumps/logs... Keyboard: LEN0010 Pointing: IBM3780
T510: https://bbs.archlinux.org/viewtopic.php?id=120287 Keyboard: PNP0303 Pointing: LEN0015
T410: https://forum.ubuntuusers.de/topic/kein-sound-109/ Keyboard: PNP0303 Pointing: LEN0015
T420: https://linux-hardware.org/index.php?probe=e6a094ade5&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 Keyboard: PNP0303 Pointing: LEN0015
T520: https://bbs.archlinux.org/viewtopic.php?id=195636 Keyboard: PNP0303 Pointing: LEN0015
W520: https://linux-hardware.org/index.php?probe=9306cac54c&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... Keyboard: PNP0303 Pointing: LEN0015
T430s: https://linux-hardware.org/index.php?probe=01545dc8fb&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T530: https://forums.fedoraforum.org/showthread.php?316640-Fedora-27-High-CPU Keyboard: LEN0071 Pointing: LEN0015
W530: https://bugs.freedesktop.org/attachment.cgi?id=115557 Keyboard: LEN0071 Pointing: LEN0015
L520: https://pastebin.com/U6MaBAY3 Keyboard: PNP0303 Pointing: LEN0017
X201: https://linux-hardware.org/index.php?probe=d7085ee4c8&log=dmesg.1 Keyboard: PNP0303 Pointing: LEN0018
X220: https://bbs.archlinux.org/viewtopic.php?id=237669 Keyboard: PNP0303 Pointing: LEN0020
X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460 Keyboard: PNP0303 Pointing: LEN0020
X131e: https://linux-hardware.org/index.php?probe=d765880811&log=dmesg Keyboard: MSF0001 Pointing: LEN0026
X1 Carbon Gen 1: https://bugzilla.kernel.org/show_bug.cgi?id=85851 Keyboard: LEN0071 Pointing: LEN0030
s230u: https://launchpadlibrarian.net/147231958/dmesg-reboot.txt Keyboard: PTL0001 Pointing: LEN0031
T540p: https://linux-hardware.org/index.php?probe=da766a30bc&log=dmesg Keyboard: LEN0071 Pointing: LEN0034
X240: https://linux-hardware.org/index.php?probe=fa7155b0e4&log=dmesg Keyboard: LEN0071 Pointing: LEN0035
T440p: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T440s: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T450: https://gist.github.com/kzar/1c38630eb22e4bf5b976 Keyboard: LEN0071 Pointing: LEN200e
Others: https://github.com/torvalds/linux/blob/master/drivers/input/mouse/synaptics....
Test result: This can make Windows automatically install the Lenovo touchpad driver. It also fixes the T440p touchpad issue.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com Signed-off-by: Iru Cai mytbk920423@gmail.com --- M Documentation/mainboard/lenovo/t440p.md M src/drivers/pc80/pc/Kconfig M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t400/Kconfig M src/mainboard/lenovo/t410/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x200/Kconfig M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x60/Kconfig 22 files changed, 132 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/14
DaLao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
Patch Set 14:
Patch Set 13: Code-Review+2
(3 comments)
Only just noticed: Please don't break URLs in the commit message.
Done, URLs have been formatted in one line.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
mainboard/lenovo: Use the original hardware ids for keyboard/pointing
Currently coreboot is using the compatible ID PNP0303 for all keyboards and PNP0F13 for all pointing devices, which causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there are some strange issues. So it's better to use the original hardware IDs for each model. The hardware IDs for the following models can be found By searching for dmesg logs on vendor BIOS:
T60: https://mail.gnome.org/archives/networkmanager-list/2012-January/msg00110.ht... Keyboard: PNP0303 Pointing: IBM0057
R60: https://openbenchmarking.org/system/1202279-AR-COMPRESS715/Lenovo%20R60/dmes... Keyboard: PNP0303 Pointing: IBM0057
X60: https://github.com/pavelmachek/missy/blob/master/db/notebook/lenovo/thinkpad... Keyboard: PNP0303 Pointing: IBM3780
X200: https://ubuntuforums.org/showthread.php?t=1833248&page=2 Keyboard: LEN0010 Pointing: IBM3780
T400: https://github.com/heradon/libreboot-fork/blob/master/docs/future/dumps/logs... Keyboard: LEN0010 Pointing: IBM3780
T510: https://bbs.archlinux.org/viewtopic.php?id=120287 Keyboard: PNP0303 Pointing: LEN0015
T410: https://forum.ubuntuusers.de/topic/kein-sound-109/ Keyboard: PNP0303 Pointing: LEN0015
T420: https://linux-hardware.org/index.php?probe=e6a094ade5&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 Keyboard: PNP0303 Pointing: LEN0015
T520: https://bbs.archlinux.org/viewtopic.php?id=195636 Keyboard: PNP0303 Pointing: LEN0015
W520: https://linux-hardware.org/index.php?probe=9306cac54c&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... Keyboard: PNP0303 Pointing: LEN0015
T430s: https://linux-hardware.org/index.php?probe=01545dc8fb&log=dmesg Keyboard: PNP0303 Pointing: LEN0015
T530: https://forums.fedoraforum.org/showthread.php?316640-Fedora-27-High-CPU Keyboard: LEN0071 Pointing: LEN0015
W530: https://bugs.freedesktop.org/attachment.cgi?id=115557 Keyboard: LEN0071 Pointing: LEN0015
L520: https://pastebin.com/U6MaBAY3 Keyboard: PNP0303 Pointing: LEN0017
X201: https://linux-hardware.org/index.php?probe=d7085ee4c8&log=dmesg.1 Keyboard: PNP0303 Pointing: LEN0018
X220: https://bbs.archlinux.org/viewtopic.php?id=237669 Keyboard: PNP0303 Pointing: LEN0020
X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460 Keyboard: PNP0303 Pointing: LEN0020
X131e: https://linux-hardware.org/index.php?probe=d765880811&log=dmesg Keyboard: MSF0001 Pointing: LEN0026
X1 Carbon Gen 1: https://bugzilla.kernel.org/show_bug.cgi?id=85851 Keyboard: LEN0071 Pointing: LEN0030
s230u: https://launchpadlibrarian.net/147231958/dmesg-reboot.txt Keyboard: PTL0001 Pointing: LEN0031
T540p: https://linux-hardware.org/index.php?probe=da766a30bc&log=dmesg Keyboard: LEN0071 Pointing: LEN0034
X240: https://linux-hardware.org/index.php?probe=fa7155b0e4&log=dmesg Keyboard: LEN0071 Pointing: LEN0035
T440p: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T440s: https://bugzilla.kernel.org/show_bug.cgi?id=91541 Keyboard: LEN0071 Pointing: LEN0036
T450: https://gist.github.com/kzar/1c38630eb22e4bf5b976 Keyboard: LEN0071 Pointing: LEN200e
Others: https://github.com/torvalds/linux/blob/master/drivers/input/mouse/synaptics....
Test result: This can make Windows automatically install the Lenovo touchpad driver. It also fixes the T440p touchpad issue.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com Signed-off-by: Iru Cai mytbk920423@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36371 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/mainboard/lenovo/t440p.md M src/drivers/pc80/pc/Kconfig M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/l520/Kconfig M src/mainboard/lenovo/s230u/Kconfig M src/mainboard/lenovo/t400/Kconfig M src/mainboard/lenovo/t410/Kconfig M src/mainboard/lenovo/t420/Kconfig M src/mainboard/lenovo/t420s/Kconfig M src/mainboard/lenovo/t430/Kconfig M src/mainboard/lenovo/t430s/Kconfig M src/mainboard/lenovo/t440p/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/lenovo/t60/Kconfig M src/mainboard/lenovo/x131e/Kconfig M src/mainboard/lenovo/x1_carbon_gen1/Kconfig M src/mainboard/lenovo/x200/Kconfig M src/mainboard/lenovo/x201/Kconfig M src/mainboard/lenovo/x220/Kconfig M src/mainboard/lenovo/x230/Kconfig M src/mainboard/lenovo/x60/Kconfig 22 files changed, 132 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/Documentation/mainboard/lenovo/t440p.md b/Documentation/mainboard/lenovo/t440p.md index fb01870..08df76f 100644 --- a/Documentation/mainboard/lenovo/t440p.md +++ b/Documentation/mainboard/lenovo/t440p.md @@ -31,8 +31,6 @@ ## Known Issues
- No audio output when using a headphone -- The touchpad is misconfigured, the 3 keys on top are all identified - as left button - Cannot get the mainboard serial number from the mainboard: the OEM UEFI firmware gets the serial number from an "emulated EEPROM" via I/O port 0x1630/0x1634, but it's still unknown how to make it work diff --git a/src/drivers/pc80/pc/Kconfig b/src/drivers/pc80/pc/Kconfig index 6813857..455ac2b 100644 --- a/src/drivers/pc80/pc/Kconfig +++ b/src/drivers/pc80/pc/Kconfig @@ -19,3 +19,15 @@ Otherwise say Y.
endif + +config PS2K_EISAID + string + default "PNP0303" + help + Mainboards can override the default to match vendor drivers and quirks. + +config PS2M_EISAID + string + default "PNP0F13" + help + Mainboards can override the default to match vendor drivers and quirks. diff --git a/src/drivers/pc80/pc/ps2_controller.asl b/src/drivers/pc80/pc/ps2_controller.asl index 210a687..d37ea2e 100644 --- a/src/drivers/pc80/pc/ps2_controller.asl +++ b/src/drivers/pc80/pc/ps2_controller.asl @@ -2,7 +2,7 @@ /* This file is part of the coreboot project. */ Device (PS2K) // Keyboard { - Name(_HID, EISAID("PNP0303")) + Name(_HID, EISAID(CONFIG_PS2K_EISAID)) Name(_CID, EISAID("PNP030B"))
Name(_CRS, ResourceTemplate() @@ -20,7 +20,8 @@
Device (PS2M) // Mouse { - Name(_HID, EISAID("PNP0F13")) + Name(_HID, EISAID(CONFIG_PS2M_EISAID)) + Name(_CID, EISAID("PNP0F13")) Name(_CRS, ResourceTemplate() { IRQ (Edge, ActiveHigh, Exclusive) { 0x0c } // IRQ 12 diff --git a/src/mainboard/lenovo/l520/Kconfig b/src/mainboard/lenovo/l520/Kconfig index 6716606..5b9344a 100644 --- a/src/mainboard/lenovo/l520/Kconfig +++ b/src/mainboard/lenovo/l520/Kconfig @@ -46,4 +46,10 @@ int default 2
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0017" + endif diff --git a/src/mainboard/lenovo/s230u/Kconfig b/src/mainboard/lenovo/s230u/Kconfig index 1248906..64f4b29 100644 --- a/src/mainboard/lenovo/s230u/Kconfig +++ b/src/mainboard/lenovo/s230u/Kconfig @@ -52,4 +52,10 @@ string default "8086,0166"
+config PS2K_EISAID + default "PTL0001" + +config PS2M_EISAID + default "LEN0031" + endif # BOARD_LENOVO_S230U diff --git a/src/mainboard/lenovo/t400/Kconfig b/src/mainboard/lenovo/t400/Kconfig index deb6c8e..e6f5631 100644 --- a/src/mainboard/lenovo/t400/Kconfig +++ b/src/mainboard/lenovo/t400/Kconfig @@ -79,4 +79,10 @@ hex default 0x200000
+config PS2K_EISAID + default "LEN0010" + +config PS2M_EISAID + default "IBM3780" + endif # BOARD_LENOVO_T400 diff --git a/src/mainboard/lenovo/t410/Kconfig b/src/mainboard/lenovo/t410/Kconfig index 86cfce8..ee79f11 100644 --- a/src/mainboard/lenovo/t410/Kconfig +++ b/src/mainboard/lenovo/t410/Kconfig @@ -63,4 +63,10 @@ int default 10
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0015" + endif diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index 7c715ed..dfc8ed1 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -75,4 +75,10 @@ string default "8086,0126"
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0015" + endif # BOARD_LENOVO_T420 diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig index 6af93ac..f29d50f 100644 --- a/src/mainboard/lenovo/t420s/Kconfig +++ b/src/mainboard/lenovo/t420s/Kconfig @@ -74,4 +74,10 @@ string default "8086,0126"
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0015" + endif # BOARD_LENOVO_T420S diff --git a/src/mainboard/lenovo/t430/Kconfig b/src/mainboard/lenovo/t430/Kconfig index 009377d..45c7ae3 100644 --- a/src/mainboard/lenovo/t430/Kconfig +++ b/src/mainboard/lenovo/t430/Kconfig @@ -68,4 +68,11 @@ config USBDEBUG_HCD_INDEX int default 2 + +config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0015" + endif diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig index 3ed0d0e..15b0912 100644 --- a/src/mainboard/lenovo/t430s/Kconfig +++ b/src/mainboard/lenovo/t430s/Kconfig @@ -84,4 +84,10 @@ bool default y
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0015" + endif # BOARD_LENOVO_T430S || BOARD_LENOVO_T431S diff --git a/src/mainboard/lenovo/t440p/Kconfig b/src/mainboard/lenovo/t440p/Kconfig index 95cb1dc..e678548 100644 --- a/src/mainboard/lenovo/t440p/Kconfig +++ b/src/mainboard/lenovo/t440p/Kconfig @@ -70,4 +70,10 @@ bool default n
+config PS2K_EISAID + default "LEN0071" + +config PS2M_EISAID + default "LEN0036" + endif diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index a628adc..aebb2de 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -84,4 +84,10 @@ string default "pci8086,0126.rom"
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0015" + endif diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 0f8d326..2a0e3ea 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -85,4 +85,10 @@ string default "8086,0166"
+config PS2K_EISAID + default "LEN0071" + +config PS2M_EISAID + default "LEN0015" + endif diff --git a/src/mainboard/lenovo/t60/Kconfig b/src/mainboard/lenovo/t60/Kconfig index 58d41a6..57172ca 100644 --- a/src/mainboard/lenovo/t60/Kconfig +++ b/src/mainboard/lenovo/t60/Kconfig @@ -46,4 +46,12 @@ int default 2
+config PS2K_EISAID + default "PNP0303" if BOARD_LENOVO_T60 + default "PNP0303" if BOARD_LENOVO_R60 + +config PS2M_EISAID + default "IBM0057" if BOARD_LENOVO_T60 + default "IBM0057" if BOARD_LENOVO_R60 + endif # BOARD_LENOVO_T60 || BOARD_LENOVO_Z61T || BOARD_LENOVO_R60 diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig index 29fda10..06c5d83 100644 --- a/src/mainboard/lenovo/x131e/Kconfig +++ b/src/mainboard/lenovo/x131e/Kconfig @@ -56,4 +56,10 @@ int default 2
+config PS2K_EISAID + default "MSF0001" + +config PS2M_EISAID + default "LEN0026" + endif # BOARD_LENOVO_X131E diff --git a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig index 830ace4..246e1db 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/Kconfig +++ b/src/mainboard/lenovo/x1_carbon_gen1/Kconfig @@ -73,4 +73,10 @@ string default "8086,0166"
+config PS2K_EISAID + default "LEN0071" + +config PS2M_EISAID + default "LEN0030" + endif # BOARD_LENOVO_X1_CARBON_GEN1 diff --git a/src/mainboard/lenovo/x200/Kconfig b/src/mainboard/lenovo/x200/Kconfig index 432c805..731f4cb 100644 --- a/src/mainboard/lenovo/x200/Kconfig +++ b/src/mainboard/lenovo/x200/Kconfig @@ -72,4 +72,10 @@ hex default 0x200000
+config PS2K_EISAID + default "LEN0010" if BOARD_LENOVO_X200 + +config PS2M_EISAID + default "IBM3780" if BOARD_LENOVO_X200 + endif # BOARD_LENOVO_X200 || BOARD_LENOVO_X301 diff --git a/src/mainboard/lenovo/x201/Kconfig b/src/mainboard/lenovo/x201/Kconfig index 42cf8f9..d73eac3 100644 --- a/src/mainboard/lenovo/x201/Kconfig +++ b/src/mainboard/lenovo/x201/Kconfig @@ -68,4 +68,10 @@ string default "-S -w EFFS"
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0018" + endif diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 7c4754d..33e15a8 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -87,4 +87,10 @@ default "8086,0116" if BOARD_LENOVO_X220I default "8086,0126"
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0020" + endif # BOARD_LENOVO_X220 || BOARD_LENOVO_X220I || BOARD_LENOVO_X1 diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index b25d7cf..7d563ef 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -75,4 +75,10 @@ string default "8086,0166"
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "LEN0020" + endif # BOARD_LENOVO_X230 || BOARD_LENOVO_X230T diff --git a/src/mainboard/lenovo/x60/Kconfig b/src/mainboard/lenovo/x60/Kconfig index 1815892..994a071 100644 --- a/src/mainboard/lenovo/x60/Kconfig +++ b/src/mainboard/lenovo/x60/Kconfig @@ -42,4 +42,10 @@ int default 2
+config PS2K_EISAID + default "PNP0303" + +config PS2M_EISAID + default "IBM3780" + endif
-
DaLao (Code Review) -
Iru Cai (vimacs) (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Peter Lemenkov (Code Review)
-
Prasun Gera (Code Review)