Attention is currently required from: Johnny Lin, Christian Walter, Arthur Heymans, Tim Chu.
Shuming Chu (Shuming) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73248 )
Change subject: soc/intel/xeon_sp/spr: Select DISABLE_ACPI_HIBERNATE to remove S4 state
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Just curious if we don't remove S4 is there any issue? […]
I think the answer is, there's no issue due to we don't really use S4.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73248
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5ddb1a98cd5bbd854b915c93694d1ebcb9bddd2
Gerrit-Change-Number: 73248
Gerrit-PatchSet: 1
Gerrit-Owner: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 01 Mar 2023 05:38:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-MessageType: comment