Attention is currently required from: Bao Zheng, Zheng Bao.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69043 )
Change subject: amdfwtool: Add support for 32M image size
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/69043/comment/c956369f_277fb8e5
PS1, Line 2308: case 0xFE020000: /* Fall through */
Does the hardware work this way? I think only 16M at most gets memory mapped.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69043
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica050dfecd258fdd6717c308907d7d4d2e85b926
Gerrit-Change-Number: 69043
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 01 Nov 2022 07:56:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment