Change in coreboot[master]: trogdor: Update pull for Sd-card detect pin

List overview All Threads
Download

newer

older

Change in coreboot[master]: Poor...

Change in coreboot[master]:...

Ravi kumar (Code Review)

20 Apr 2020 20 Apr '20

12:02 p.m.

Hello Sajida Bhanu,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/40534

to review the following change.

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

trogdor: Update pull for Sd-card detect pin

Configuring pull for SD-card detect pin. Without this SD-card detection is not working as expected

Signed-off-by: Shaik Sajida Bhanu sbhanu@codeaurora.org Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 --- M src/mainboard/google/trogdor/chromeos.c 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/40534/1

diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c index b13f88f..3d535c8 100644 --- a/src/mainboard/google/trogdor/chromeos.c +++ b/src/mainboard/google/trogdor/chromeos.c @@ -29,6 +29,7 @@ gpio_input_pullup(GPIO_AP_EC_INT); gpio_output(GPIO_AP_SUSPEND, 1); gpio_input(GPIO_WP_STATE); + gpio_input_pullup(GPIO_SD_CD_L); gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP); gpio_output(GPIO_AMP_ENABLE, 1); }

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Paul Menzel (Code Review)

21 Apr 21 Apr

1:10 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40534 )

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

Patch Set 1:

(6 comments)

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@7 PS1, Line 7: Sd-card SD card

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@9 PS1, Line 9: SD-card SD card

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@9 PS1, Line 9: Configuring Configure

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@10 PS1, Line 10: Without this SD-card detection is not working as expected 1. Add it on the line above. 2. Please add a dot/period at the end of sentences.

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@10 PS1, Line 10: SD-card SD card

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@11 PS1, Line 11: Is there an issue/bug report for this?

Is that according to the schematics?

-- To view, visit https://review.coreboot.org/c/coreboot/+/40534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Gerrit-Change-Number: 40534 Gerrit-PatchSet: 1 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sajida Bhanu sbhanu@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 21 Apr 2020 07:10:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sajida Bhanu (Code Review)

28 Apr 28 Apr

4:02 a.m.

Sajida Bhanu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40534 )

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

Patch Set 1:

(6 comments)

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@7 PS1, Line 7: Sd-card

...

SD card

Done

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@9 PS1, Line 9: SD-card

...

SD card

Done

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@9 PS1, Line 9: Configuring

...

Configure

Done

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@10 PS1, Line 10: SD-card

...

SD card

Done

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@10 PS1, Line 10: Without this SD-card detection is not working as expected

...

Add it on the line above. […]

sure

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@11 PS1, Line 11:

...

Is there an issue/bug report for this? […]

yes https://partnerissuetracker.corp.google.com/issues/80547577

Yes it is as per schematics of Tragdor board.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Gerrit-Change-Number: 40534 Gerrit-PatchSet: 1 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sajida Bhanu sbhanu@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 28 Apr 2020 10:02:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

6:30 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40534 )

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@11 PS1, Line 11: I believe, you should then use:

...

BUG=b:80547577

so that Gerrit converts it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Gerrit-Change-Number: 40534 Gerrit-PatchSet: 1 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sajida Bhanu sbhanu@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 28 Apr 2020 12:30:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sajida Bhanu sbhanu@codeaurora.org Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Julius Werner (Code Review)

7 May 7 May

5:26 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40534 )

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

Patch Set 3: Code-Review+2

Please rebase this in front of the display stuff so that we can merge it while that's still in review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Gerrit-Change-Number: 40534 Gerrit-PatchSet: 3 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sajida Bhanu sbhanu@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Thu, 07 May 2020 23:26:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ravi kumar (Code Review)

8 May 8 May

2:59 a.m.

Hello build bot (Jenkins), Sajida Bhanu, Julius Werner, mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40534

to look at the new patch set (#4).

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

trogdor: Update pull for Sd-card detect pin

Configuring pull for SD-card detect pin. Without this SD-card detection is not working as expected

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/40534/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/40534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Gerrit-Change-Number: 40534 Gerrit-PatchSet: 4 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sajida Bhanu sbhanu@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

14 May 14 May

5:25 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40534 )

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Gerrit-Change-Number: 40534 Gerrit-PatchSet: 7 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sajida Bhanu sbhanu@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Thu, 14 May 2020 23:25:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

5:29 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40534 )

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/40534/1//COMMIT_MSG@11 PS1, Line 11:

...

I believe, you should then use: […]

These numbers aren't really relevant to upstream coreboot anyway.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Gerrit-Change-Number: 40534 Gerrit-PatchSet: 7 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sajida Bhanu sbhanu@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Thu, 14 May 2020 23:29:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sajida Bhanu sbhanu@codeaurora.org Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Julius Werner (Code Review)

5:29 p.m.

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40534 )

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

trogdor: Update pull for Sd-card detect pin

Configuring pull for SD-card detect pin. Without this SD-card detection is not working as expected

Signed-off-by: Shaik Sajida Bhanu sbhanu@codeaurora.org Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40534 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/mainboard/google/trogdor/chromeos.c 1 file changed, 3 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c index 324d6ca..9360928 100644 --- a/src/mainboard/google/trogdor/chromeos.c +++ b/src/mainboard/google/trogdor/chromeos.c @@ -16,7 +16,9 @@ gpio_input_pullup(GPIO_AP_EC_INT); gpio_output(GPIO_AP_SUSPEND, 1); gpio_input(GPIO_WP_STATE); - gpio_input_pullup(GPIO_H1_AP_INT); + gpio_input_pullup(GPIO_SD_CD_L); + gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP); + gpio_output(GPIO_AMP_ENABLE, 0); }

void fill_lb_gpios(struct lb_gpios *gpios)

-- To view, visit https://review.coreboot.org/c/coreboot/+/40534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Gerrit-Change-Number: 40534 Gerrit-PatchSet: 8 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sajida Bhanu sbhanu@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: merged

9elements QA (Code Review)

6:10 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40534 )

Change subject: trogdor: Update pull for Sd-card detect pin ......................................................................

Patch Set 8:

Automatic boot test returned (PASS/FAIL/TOTAL): 2/2/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : FAIL : https://lava.9esec.io/r/3451 "QEMU x86 q35/ich9" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/3450 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3449 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3448

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I77bf355a049224784a160defa6bee66d0f9ceb75 Gerrit-Change-Number: 40534 Gerrit-PatchSet: 8 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Sajida Bhanu sbhanu@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Fri, 15 May 2020 00:10:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1824

days inactive

1849

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Julius Werner (Code Review)
Paul Menzel (Code Review)
Ravi kumar (Code Review)
Sajida Bhanu (Code Review)