Change in coreboot[master]: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA de...
Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47410 )
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices
Change-Id: I6289d2049fbbb6bb532be3d9e2355c563ec98d1b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/tigerlake/include/soc/pci_devs.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/47410/1
diff --git a/src/soc/intel/tigerlake/include/soc/pci_devs.h b/src/soc/intel/tigerlake/include/soc/pci_devs.h index cfb70cd..9a74e33 100644 --- a/src/soc/intel/tigerlake/include/soc/pci_devs.h +++ b/src/soc/intel/tigerlake/include/soc/pci_devs.h @@ -50,6 +50,8 @@ #define SA_DEV_TBT3 PCI_DEV(0, SA_DEV_SLOT_TBT, 3)
#define SA_DEV_SLOT_TCSS 0x0d +#define NUM_TCSS_DMA_FUNCTIONS 2 +#define SA_DEVFN_TCSS_DMA(x) PCI_DEVFN(SA_DEV_SLOT_TCSS, (x + 2)) #define SA_DEVFN_TCSS_XHCI PCI_DEVFN(SA_DEV_SLOT_TCSS, 0) #define SA_DEVFN_TCSS_XDCI PCI_DEVFN(SA_DEV_SLOT_TCSS, 1) #define SA_DEVFN_TCSS_DMA0 PCI_DEVFN(SA_DEV_SLOT_TCSS, 2)
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47410 )
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47410/1/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/47410/1/src/soc/intel/tigerlake/inc... PS1, Line 54: x (parens) around x
Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Nick Vaccaro, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47410
to look at the new patch set (#2).
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices
Change-Id: I6289d2049fbbb6bb532be3d9e2355c563ec98d1b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/tigerlake/include/soc/pci_devs.h 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/47410/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47410 )
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47410/1/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/47410/1/src/soc/intel/tigerlake/inc... PS1, Line 54: x
(parens) around x
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47410 )
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... PS2, Line 54: S nit: Add another space to align with the SA_DEVFN below?
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... PS2, Line 57: PCI_DEVFN(SA_DEV_SLOT_TCSS, 2) Use SA_DEVFN_TCSS_DMA(0)?
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... PS2, Line 58: PCI_DEVFN(SA_DEV_SLOT_TCSS, 3) Use SA_DEVFN_TCSS_DMA(1)?
Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Nick Vaccaro, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47410
to look at the new patch set (#3).
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices
Change-Id: I6289d2049fbbb6bb532be3d9e2355c563ec98d1b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/tigerlake/include/soc/pci_devs.h 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/47410/3
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47410 )
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... PS2, Line 54: S
nit: Add another space to align with the SA_DEVFN below?
Done
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... PS2, Line 57: PCI_DEVFN(SA_DEV_SLOT_TCSS, 2)
Use SA_DEVFN_TCSS_DMA(0)?
Done
https://review.coreboot.org/c/coreboot/+/47410/2/src/soc/intel/tigerlake/inc... PS2, Line 58: PCI_DEVFN(SA_DEV_SLOT_TCSS, 3)
Use SA_DEVFN_TCSS_DMA(1)?
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47410 )
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47410 )
Change subject: soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices ......................................................................
soc/intel/tigerlake: Add some helper macros for accessing TCSS DMA devices
Change-Id: I6289d2049fbbb6bb532be3d9e2355c563ec98d1b Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/47410 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/soc/intel/tigerlake/include/soc/pci_devs.h 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/include/soc/pci_devs.h b/src/soc/intel/tigerlake/include/soc/pci_devs.h index cfb70cd..ac0498f 100644 --- a/src/soc/intel/tigerlake/include/soc/pci_devs.h +++ b/src/soc/intel/tigerlake/include/soc/pci_devs.h @@ -50,10 +50,12 @@ #define SA_DEV_TBT3 PCI_DEV(0, SA_DEV_SLOT_TBT, 3)
#define SA_DEV_SLOT_TCSS 0x0d +#define NUM_TCSS_DMA_FUNCTIONS 2 +#define SA_DEVFN_TCSS_DMA(x) PCI_DEVFN(SA_DEV_SLOT_TCSS, ((x) + 2)) #define SA_DEVFN_TCSS_XHCI PCI_DEVFN(SA_DEV_SLOT_TCSS, 0) #define SA_DEVFN_TCSS_XDCI PCI_DEVFN(SA_DEV_SLOT_TCSS, 1) -#define SA_DEVFN_TCSS_DMA0 PCI_DEVFN(SA_DEV_SLOT_TCSS, 2) -#define SA_DEVFN_TCSS_DMA1 PCI_DEVFN(SA_DEV_SLOT_TCSS, 3) +#define SA_DEVFN_TCSS_DMA0 SA_DEVFN_TCSS_DMA(0) +#define SA_DEVFN_TCSS_DMA1 SA_DEVFN_TCSS_DMA(1) #define SA_DEV_TCSS_XHCI PCI_DEV(0, SA_DEV_SLOT_TCSS, 0) #define SA_DEV_TCSS_XDCI PCI_DEV(0, SA_DEV_SLOT_TCSS, 1) #define SA_DEV_TCSS_DMA0 PCI_DEV(0, SA_DEV_SLOT_TCSS, 2)
-
Caveh Jalali (Code Review) -
Furquan Shaikh (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)