Attention is currently required from: Felix Held, Martin Roth, Raul Rangel.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78191?usp=email )
Change subject: util/amdfwtool: Check for pkg-config presence ......................................................................
Patch Set 1:
(1 comment)
File util/amdfwtool/Makefile:
https://review.coreboot.org/c/coreboot/+/78191/comment/d4ff31cf_642447bc : PS1, Line 26: shell
We just need to check if pkg-config returned a valid code. […]
The proposed .SHELLSTATUS works with Makefile: ``` Makefile:29: *** "Ensure that pkg-config is installed.". Stop. ```
But when added to Makefile.inc which is used by util/abuild/abuild, it does not stop there.
``` make: pkg-config: No such file or directory AMDFWTOOL /usr/bin/ld: coreboot-builds/sharedutils/amdfwtool/signed_psp.o: in function `add_single_sha': /usr/local/google/home/kramasub/coreboot/util/amdfwtool/signed_psp.c:76:(.text+0x343): undefined reference to `SHA256' /usr/bin/ld: /usr/local/google/home/kramasub/coreboot/util/amdfwtool/signed_psp.c:73:(.text+0x429): undefined reference to `SHA384' collect2: error: ld returned 1 exit status make: *** [util/amdfwtool/Makefile.inc:23: coreboot-builds/sharedutils/amdfwtool/amdfwtool] Error 1 ```
Also the other PHONY targets fail too(eg. clean) since pkg-config is not present even though they don't depend on pkg-config. Is that behavior ok?
-
Karthik Ramasubramanian (Code Review)