[M] Change in coreboot[master]: soc/mediatek/mt8186: Reduce GPIO code size in bootblock - coreboot-gerrit

6 Apr 2023


      Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
jason-ch chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74062 )
Change subject: soc/mediatek/mt8186: Reduce GPIO code size in bootblock
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8186/gpio.c:
https://review.coreboot.org/c/coreboot/+/74062/comment/d25afa89_9d9c29bd 
PS2, Line 23: spi
...
Since TDM_RX_* are not SPI GPIOs (am I right?), we should rename this to `bootblock_gpio_driving_inf […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74062
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24775ba93cd74ae401747c2f5a26bbf1c8f6ac0a
Gerrit-Change-Number: 74062
Gerrit-PatchSet: 3
Gerrit-Owner: jason-ch chen Jason-ch.Chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 02:24:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment